From: Patrick Steinhardt <ps@pks.im>
To: Ramsay Jones <ramsay@ramsayjones.plus.com>
Cc: GIT Mailing-list <git@vger.kernel.org>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 2/2] t0610-reftable-basics: mitigate a flaky test on cygwin
Date: Tue, 20 Jan 2026 06:49:06 +0100 [thread overview]
Message-ID: <aW8XUqlbiJgr8Eib@pks.im> (raw)
In-Reply-To: <f4599b1e-78df-44f3-a9b8-ed28411e169c@ramsayjones.plus.com>
On Mon, Jan 19, 2026 at 05:10:46PM +0000, Ramsay Jones wrote:
> On 19/01/2026 6:50 am, Patrick Steinhardt wrote:
> > On Fri, Jan 16, 2026 at 08:39:56PM +0000, Ramsay Jones wrote:
> >> In order to fix this flaky test on cygwin, despite not knowing why it
> >> works, replace the shell redirection with the above 'test-tool truncate'
> >> invocation.
> >>
> >> Helped-by: Patrick Steinhardt <ps@pks.im>
> >
> > Oh, so is this the exact case that we were talking about? If so, it
> > might make sense to link to the mail thread so that folks can also read
> > a bit into our discussion around this.
>
> Indeed! I thought about referencing the email thread, but I decided that it
> didn't really offer any more supporting evidence than the commit message
> (in fact less - it doesn't mention the 'strace' scan).
>
> I can add that (again [1]), if you think it's worth it, but I just re-read
> the email thread and I'm not convinced it offers much extra value. So, I would
> rather not re-roll, but I will if you think it worth it. Let me know.
>
> [1] https://lore.kernel.org/git/f22c95ad-43c8-41de-8315-e707224e830b@ramsayjones.plus.com/
Fair enough, let's just keep it as-is. Thanks!
Patrick
prev parent reply other threads:[~2026-01-20 5:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-16 20:39 [PATCH 2/2] t0610-reftable-basics: mitigate a flaky test on cygwin Ramsay Jones
2026-01-19 6:50 ` Patrick Steinhardt
2026-01-19 17:10 ` Ramsay Jones
2026-01-20 5:49 ` Patrick Steinhardt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aW8XUqlbiJgr8Eib@pks.im \
--to=ps@pks.im \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ramsay@ramsayjones.plus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox