Re: [PATCH v2 10/17] refs/files: introduce function to perform normal ref checks

[Patrick Steinhardt <ps@pks.im>]

On Mon, Jan 12, 2026 at 06:37:05AM -0800, Junio C Hamano wrote:
> Junio C Hamano <gitster@pobox.com> writes:
> 
> > Patrick Steinhardt <ps@pks.im> writes:
> >
> >> On Mon, Jan 12, 2026 at 06:42:04AM -0500, Karthik Nayak wrote:
> >>> Patrick Steinhardt <ps@pks.im> writes:
> >>> 
> >>> > In a subsequent commit we'll introduce new generic checks for direct
> >>> > refs. These checks will be independent of the actual backend.
> >>> 
> >>> I don't think we've used the terminology 'direct refs' before. Took
> >>> me a second to understand. We generally use 'regular refs', but that
> >>> includes symrefs, so I think this does make sense.
> >>
> >> Yeah, I didn't really know what to call these other than "direct refs".
> >> We could instead say "non-symbolic refs", but that also feels kind of
> >> awkward. So I guess this is good enough...?
> >
> > The latter is understandable, if awkward.  The former is not.
> 
> Well, I failed to elaborate why I think "the former is not".
> 
> The former would have been, if we were calling HEAD as "indirect
> ref", instead of "symbolic ref".  But we use the latter, hence
> "direct ref" is much less understandable than "non-symbolic ref".

Fair enough. I've queued this change locally and will send it out with
the next iteration. Thanks!

Patrick