From: Patrick Steinhardt <ps@pks.im>
To: Aaron Plattner <aplattner@nvidia.com>
Cc: git@vger.kernel.org, Rahul Rameshbabu <rrameshbabu@nvidia.com>,
Lucas De Marchi <demarchi@kernel.org>
Subject: Re: [PATCH v3] remote-curl: Use auth for probe_rpc() requests too
Date: Tue, 13 Jan 2026 08:35:03 +0100 [thread overview]
Message-ID: <aWX1p2fjo2XPpXiP@pks.im> (raw)
In-Reply-To: <20260113072013.3775439-1-aplattner@nvidia.com>
On Mon, Jan 12, 2026 at 11:20:12PM -0800, Aaron Plattner wrote:
> v3: Combine the setup and test into a single subtest, use test_when_finished to
> remove large.git.
>
> Those are both good suggestions, thanks Patrick.
>
> I contemplated leaving large.git around since normally it gets cleaned up when
> the "trash directory.t5563-simple-http-auth" directory is removed, but it's 16
> MB so it's a bit big to leave around even in debug mode.
Thanks, this version looks good to me!
Patrick
prev parent reply other threads:[~2026-01-13 7:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-13 7:20 [PATCH v3] remote-curl: Use auth for probe_rpc() requests too Aaron Plattner
2026-01-13 7:35 ` Patrick Steinhardt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aWX1p2fjo2XPpXiP@pks.im \
--to=ps@pks.im \
--cc=aplattner@nvidia.com \
--cc=demarchi@kernel.org \
--cc=git@vger.kernel.org \
--cc=rrameshbabu@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox