public inbox for git@vger.kernel.org
 help / color / mirror / Atom feed
From: Patrick Steinhardt <ps@pks.im>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: What's cooking in git.git (Jan 2026, #04)
Date: Wed, 14 Jan 2026 18:35:28 +0100	[thread overview]
Message-ID: <aWfT4AX4RSieyAml@pks.im> (raw)
In-Reply-To: <xmqq8qe0gthp.fsf@gitster.g>

On Wed, Jan 14, 2026 at 06:26:58AM -0800, Junio C Hamano wrote:
> Patrick Steinhardt <ps@pks.im> writes:
> 
> > On Tue, Jan 13, 2026 at 12:10:13PM -0800, Junio C Hamano wrote:
> >> * ps/read-object-info-improvements (2026-01-12) 8 commits
> >>  - packfile: drop repository parameter from `packed_object_info()`
> >>  - packfile: skip unpacking object header for disk size requests
> >>  - packfile: disentangle return value of `packed_object_info()`
> >>  - packfile: always populate pack-specific info when reading object info
> >>  - packfile: extend `is_delta` field to allow for "unknown" state
> >>  - packfile: always declare object info to be OI_PACKED
> >>  - object-file: always set OI_LOOSE when reading object info
> >>  - Merge branch 'jc/object-read-stream-fix' into ps/read-object-info-improvements
> >> 
> >>  The object-info API has been cleaned up.
> >> 
> >>  Comments?
> >>  source: <20260112-b4-pks-odb-read-object-info-improvements-v5-0-9a6124e95bf2@pks.im>
> >
> > I think this topic should be ready by now. The last iteration only added
> > another test that catches a bug we recently started to hit in production
> > systems, and the previous iterations all received reviews.
> >
> > I can try to loop in another set of reviewers though if you prefer.
> 
> For a topic like this with multiple iterations, I always revisit the
> thread overview
> 
> https://lore.kernel.org/git/20260112-b4-pks-odb-read-object-info-improvements-v5-0-9a6124e95bf2@pks.im/
> 
> at lore, but it is hard to judge quickly if we have reached the
> point of diminishing returns when the last few rounds got almost no
> responses.

Fair. I mostly want to ensure that this topic will be part of the
upcoming Git 2.53 release given that it fixes a regression.

Patrick

      reply	other threads:[~2026-01-14 17:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-13 20:10 What's cooking in git.git (Jan 2026, #04) Junio C Hamano
2026-01-14  0:27 ` Junio C Hamano
2026-01-14  5:20 ` Patrick Steinhardt
2026-01-14 14:26   ` Junio C Hamano
2026-01-14 17:35     ` Patrick Steinhardt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aWfT4AX4RSieyAml@pks.im \
    --to=ps@pks.im \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox