From: "brian m. carlson" <sandals@crustytoothpaste.net>
To: Eric Sunshine <ericsunshine@gmail.com>
Cc: Junio C Hamano <junio@pobox.com>, git@vger.kernel.org
Subject: Re: What's cooking in git.git (Jan 2026, #09)
Date: Thu, 29 Jan 2026 23:25:35 +0000 [thread overview]
Message-ID: <aXvsb43Wq-YIYaVr@fruit.crustytoothpaste.net> (raw)
In-Reply-To: <CAPig+cStjN15WEKSN3b5VGLK-+N5pzj-dUDQ2rm15ne_9Q07FQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1043 bytes --]
On 2026-01-29 at 22:51:40, Eric Sunshine wrote:
> On Thu, Jan 29, 2026 at 5:01 PM brian m. carlson
> <sandals@crustytoothpaste.net> wrote:
> > I did not get a Windows VM working but I did discover the problem and
> > I'm working on a patch and will send it out once I have CI green.
> >
> > The problem is roughly that both the MSVC linker and MSYS linker are
> > both called link.exe. When compiling with Rust against MSVC, the MSVC
> > linker must be used, but the MSYS linker is first in PATH (because I
> > believe installing the Git for Windows SDK causes that to be the case),
> > causing build.rs to fail to compile.
>
> Didn't Ezekiel already tackle[*] this problem or am I misunderstanding?
CI still fails when rebasing my branch on `master`, so it doesn't appear
to have made it upstream quite yet. I'll resume working on this
tomorrow at $DAYJOB and then add a patch to my series. I may steal the
approach from Ezekiel's patch if it appears to work.
--
brian m. carlson (they/them)
Toronto, Ontario, CA
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 262 bytes --]
prev parent reply other threads:[~2026-01-29 23:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-27 17:42 What's cooking in git.git (Jan 2026, #09) Junio C Hamano
2026-01-27 22:03 ` Taylor Blau
2026-02-06 19:39 ` Junio C Hamano
2026-01-28 14:29 ` ds/revision-maximal-only (was Re: What's cooking in git.git (Jan 2026, #09)) Derrick Stolee
2026-01-28 22:50 ` What's cooking in git.git (Jan 2026, #09) brian m. carlson
2026-01-29 22:01 ` brian m. carlson
2026-01-29 22:51 ` Eric Sunshine
2026-01-29 23:25 ` brian m. carlson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXvsb43Wq-YIYaVr@fruit.crustytoothpaste.net \
--to=sandals@crustytoothpaste.net \
--cc=ericsunshine@gmail.com \
--cc=git@vger.kernel.org \
--cc=junio@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox