From: Patrick Steinhardt <ps@pks.im>
To: Justin Tobler <jltobler@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 3/5] ci: make test slicing consistent across Meson/Make
Date: Tue, 10 Feb 2026 06:34:22 +0100 [thread overview]
Message-ID: <aYrDXs9DMfBHi5jk@pks.im> (raw)
In-Reply-To: <aYojRnqBi8nzZhPD@denethor>
On Mon, Feb 09, 2026 at 12:19:57PM -0600, Justin Tobler wrote:
> On 26/02/09 05:56PM, Patrick Steinhardt wrote:
> > diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
> > index 2b175dc5c6..1b7a16e1f1 100644
> > --- a/.github/workflows/main.yml
> > +++ b/.github/workflows/main.yml
> > @@ -298,7 +298,7 @@ jobs:
> > path: build
> > - name: Test
> > shell: pwsh
> > - run: ci/run-test-slice-meson.sh build ${{matrix.nr}} 10
> > + run: ci/run-test-slice-meson.sh build ${{matrix.nr + 1}} 10
>
> Due to the changes in the prior patch, GitHub CI passing 0 as the slice
> value would cause a failure correct? I wonder if we should combine this
> change with the previous patch. Otherwise this patch looks good.
Note that this is the "-meson.sh" variant, so this is a different
script. I'm mostly just touching up this variant so that it behaves the
same as the non-Meson one.
Meson itself would die though in case it's passed an invalid range.
Patrick
next prev parent reply other threads:[~2026-02-10 5:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-09 16:56 [PATCH 0/5] Some assorted fixes for GitLab CI Patrick Steinhardt
2026-02-09 16:56 ` [PATCH 1/5] ci: handle failures of test-slice helper Patrick Steinhardt
2026-02-09 16:56 ` [PATCH 2/5] ci: don't skip smallest test slice in GitLab Patrick Steinhardt
2026-02-09 18:07 ` Justin Tobler
2026-02-09 16:56 ` [PATCH 3/5] ci: make test slicing consistent across Meson/Make Patrick Steinhardt
2026-02-09 18:19 ` Justin Tobler
2026-02-10 5:34 ` Patrick Steinhardt [this message]
2026-02-10 22:15 ` Junio C Hamano
2026-02-10 22:54 ` Jeff King
2026-02-11 6:33 ` Patrick Steinhardt
2026-02-09 16:56 ` [PATCH 4/5] gitlab-ci: use "run-test-slice-meson.sh" Patrick Steinhardt
2026-02-09 16:56 ` [PATCH 5/5] gitlab-ci: handle failed tests on MSVC+Meson job Patrick Steinhardt
2026-02-09 18:33 ` Justin Tobler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYrDXs9DMfBHi5jk@pks.im \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=jltobler@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox