From: Patrick Steinhardt <ps@pks.im>
To: "René Scharfe" <l.s.r@web.de>
Cc: Git List <git@vger.kernel.org>, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v2] xdiff-interface: stop using the_repository
Date: Tue, 10 Feb 2026 14:28:55 +0100 [thread overview]
Message-ID: <aYsylzWZXkKIYzOz@pks.im> (raw)
In-Reply-To: <59fe4ac7-605d-4eae-b13c-46996dd8814e@web.de>
On Mon, Feb 09, 2026 at 08:24:52PM +0100, René Scharfe wrote:
> Use the algorithm-agnostic is_null_oid() and push the dependency of
> read_mmblob() on the_repository->objects to its callers. This allows it
> to be used with arbitrary object databases.
>
> Signed-off-by: René Scharfe <l.s.r@web.de>
> ---
> Change since v1: don't add unnecessary #include
Looks good to me, thanks!
Patrick
next prev parent reply other threads:[~2026-02-10 13:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-08 13:47 [PATCH] xdiff-interface: stop using the_repository René Scharfe
2026-02-09 9:48 ` Patrick Steinhardt
2026-02-09 14:14 ` René Scharfe
2026-02-09 11:15 ` Junio C Hamano
2026-02-09 15:21 ` René Scharfe
2026-02-09 17:45 ` Junio C Hamano
2026-02-09 19:24 ` René Scharfe
2026-02-09 18:57 ` Elijah Newren
2026-02-09 20:01 ` Junio C Hamano
2026-02-15 18:42 ` René Scharfe
2026-02-15 18:42 ` René Scharfe
2026-02-09 19:24 ` [PATCH v2] " René Scharfe
2026-02-10 13:28 ` Patrick Steinhardt [this message]
2026-02-10 21:31 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYsylzWZXkKIYzOz@pks.im \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=l.s.r@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox