From: Patrick Steinhardt <ps@pks.im>
To: Justin Tobler <jltobler@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] object-file: use `container_of()` to convert from base types
Date: Thu, 19 Feb 2026 14:43:14 +0100 [thread overview]
Message-ID: <aZcTcgKDg6N4QW3j@pks.im> (raw)
In-Reply-To: <20260218210120.1146078-1-jltobler@gmail.com>
On Wed, Feb 18, 2026 at 03:01:20PM -0600, Justin Tobler wrote:
> To improve code hygiene, replace direct casts from `struct
> odb_transaction` and `struct odb_read_stream` to their concrete
> implementations with `container_of()`.
Right. The reason we want to do this is so that we become independent of
the order in which members in `struct odb_read_stream` are declared.
The changes all look good to me, thanks!
Patrick
next prev parent reply other threads:[~2026-02-19 13:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-18 21:01 [PATCH] object-file: use `container_of()` to convert from base types Justin Tobler
2026-02-19 13:43 ` Patrick Steinhardt [this message]
2026-02-20 16:07 ` Toon Claes
2026-02-22 7:07 ` Junio C Hamano
2026-02-22 9:41 ` Jeff King
2026-02-22 17:19 ` Justin Tobler
2026-02-22 20:36 ` Junio C Hamano
2026-02-22 20:16 ` [PATCH] object-file.c: avoid container_of() of a NULL container Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aZcTcgKDg6N4QW3j@pks.im \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=jltobler@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox