From: Patrick Steinhardt <ps@pks.im>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Daniel D. Beck via GitGitGadget" <gitgitgadget@gmail.com>,
git@vger.kernel.org, "Jean-Noël Avila" <jn.avila@free.fr>,
"Daniel D. Beck" <daniel@ddbeck.com>,
"Johannes Schindelin" <johannes.schindelin@gmx.de>
Subject: Re: [PATCH] doc: fetch: document `--jobs=0` behavior
Date: Fri, 20 Feb 2026 09:51:39 +0100 [thread overview]
Message-ID: <aZggm7R-4VohiCYm@pks.im> (raw)
In-Reply-To: <xmqq4inc5zlt.fsf@gitster.g>
On Thu, Feb 19, 2026 at 10:59:10AM -0800, Junio C Hamano wrote:
> Patrick Steinhardt <ps@pks.im> writes:
>
> > On Wed, Feb 18, 2026 at 07:32:39PM +0000, Daniel D. Beck via GitGitGadget wrote:
> >> diff --git a/Documentation/fetch-options.adoc b/Documentation/fetch-options.adoc
> >> index fcba46ee9e..e15cbc51f2 100644
> >> --- a/Documentation/fetch-options.adoc
> >> +++ b/Documentation/fetch-options.adoc
> >> @@ -234,6 +234,8 @@ endif::git-pull[]
> >> `--jobs=<n>`::
> >> Parallelize all forms of fetching up to _<n>_ jobs at a time.
> >> +
> >> +A value of 0 will use some reasonable default.
> >
> > Can't we do better though than saying "some reasonable default"? As a
> > user I would wonder what this is even supposed to mean. True, we don't
> > do so either in the documentation of "fetch.parallel". But arguably, we
> > should update both sites to reflect the status quo.
> >
> > Going into the code we seem to fall back to `online_cpus()`. So should
> > we document this accordingly?
>
> I do not have time to dig this out myself from ancient discussion
> threads, but we probably had the same discussion when "git config
> --help" described the fetch.parallel with exactly the same phrasing
> and decided to leave the exact implementation detail out of the
> end-user facing documentation.
Doesn't look like it. The thread in question is [1], and neither the
commit message nor the discussion around the patch mentioned why we
don't document what the reasonable default is.
Dscho, do you remember by chance why you decided to not be more specific
here?
Thanks!
Patrick
[1]: <pull.369.git.gitgitgadget@gmail.com>
next prev parent reply other threads:[~2026-02-20 8:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-18 19:32 [PATCH] doc: fetch: document `--jobs=0` behavior Daniel D. Beck via GitGitGadget
2026-02-19 11:39 ` Patrick Steinhardt
2026-02-19 18:59 ` Junio C Hamano
2026-02-20 8:51 ` Patrick Steinhardt [this message]
2026-02-24 9:47 ` Daniel Beck
2026-03-02 12:35 ` Johannes Schindelin
2026-03-02 19:33 ` Junio C Hamano
2026-02-19 17:38 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aZggm7R-4VohiCYm@pks.im \
--to=ps@pks.im \
--cc=daniel@ddbeck.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=jn.avila@free.fr \
--cc=johannes.schindelin@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox