public inbox for git@vger.kernel.org
 help / color / mirror / Atom feed
From: Justin Tobler <jltobler@gmail.com>
To: K Jayatheerth <jayatheerthkulkarni2005@gmail.com>
Cc: git@vger.kernel.org, karthik.188@gmail.com,
	ayu.chandekar@gmail.com,  siddharthasthana31@gmail.com,
	lucasseikioshiro@gmail.com
Subject: Re: [GSoC] repo: remove unused header
Date: Sat, 21 Feb 2026 23:13:31 -0600	[thread overview]
Message-ID: <aZqPXRHOHU3EjfvH@denethor> (raw)
In-Reply-To: <20260222004036.47744-1-jayatheerthkulkarni2005@gmail.com>

On 26/02/22 06:10AM, K Jayatheerth wrote:
> The "hex.h" header is included in "builtin/repo.c", but none of the
> functions or macros it provides are used in this file.
> 
> Signed-off-by: K Jayatheerth <jayatheerthkulkarni2005@gmail.com>
> ---
> 
> As instructed in the Getting Started section of SoC 2026 Ideas page in repo project
> This comes as a micro patch.
> 
>  builtin/repo.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/builtin/repo.c b/builtin/repo.c
> index 0ea045abc1..63d21df4c2 100644
> --- a/builtin/repo.c
> +++ b/builtin/repo.c
> @@ -2,7 +2,6 @@
>  
>  #include "builtin.h"
>  #include "environment.h"
> -#include "hex.h"

This include is indeed unused. I am currently working on a series [1]
that will use this header again. I can of course just re-add it in that
series as well though.

Thanks,
-Justin

[1]: <20260203221758.1164434-1-jltobler@gmail.com>


  reply	other threads:[~2026-02-22  5:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-22  0:40 [GSoC] repo: remove unused header K Jayatheerth
2026-02-22  5:13 ` Justin Tobler [this message]
2026-02-22  7:59   ` JAYATHEERTH K

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aZqPXRHOHU3EjfvH@denethor \
    --to=jltobler@gmail.com \
    --cc=ayu.chandekar@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=jayatheerthkulkarni2005@gmail.com \
    --cc=karthik.188@gmail.com \
    --cc=lucasseikioshiro@gmail.com \
    --cc=siddharthasthana31@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox