* [GSoC] repo: remove unused header
@ 2026-02-22 0:40 K Jayatheerth
2026-02-22 5:13 ` Justin Tobler
0 siblings, 1 reply; 3+ messages in thread
From: K Jayatheerth @ 2026-02-22 0:40 UTC (permalink / raw)
To: git
Cc: karthik.188, jltobler, ayu.chandekar, siddharthasthana31,
lucasseikioshiro, K Jayatheerth
The "hex.h" header is included in "builtin/repo.c", but none of the
functions or macros it provides are used in this file.
Signed-off-by: K Jayatheerth <jayatheerthkulkarni2005@gmail.com>
---
As instructed in the Getting Started section of SoC 2026 Ideas page in repo project
This comes as a micro patch.
builtin/repo.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/builtin/repo.c b/builtin/repo.c
index 0ea045abc1..63d21df4c2 100644
--- a/builtin/repo.c
+++ b/builtin/repo.c
@@ -2,7 +2,6 @@
#include "builtin.h"
#include "environment.h"
-#include "hex.h"
#include "odb.h"
#include "parse-options.h"
#include "path-walk.h"
--
2.52.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [GSoC] repo: remove unused header
2026-02-22 0:40 [GSoC] repo: remove unused header K Jayatheerth
@ 2026-02-22 5:13 ` Justin Tobler
2026-02-22 7:59 ` JAYATHEERTH K
0 siblings, 1 reply; 3+ messages in thread
From: Justin Tobler @ 2026-02-22 5:13 UTC (permalink / raw)
To: K Jayatheerth
Cc: git, karthik.188, ayu.chandekar, siddharthasthana31,
lucasseikioshiro
On 26/02/22 06:10AM, K Jayatheerth wrote:
> The "hex.h" header is included in "builtin/repo.c", but none of the
> functions or macros it provides are used in this file.
>
> Signed-off-by: K Jayatheerth <jayatheerthkulkarni2005@gmail.com>
> ---
>
> As instructed in the Getting Started section of SoC 2026 Ideas page in repo project
> This comes as a micro patch.
>
> builtin/repo.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/builtin/repo.c b/builtin/repo.c
> index 0ea045abc1..63d21df4c2 100644
> --- a/builtin/repo.c
> +++ b/builtin/repo.c
> @@ -2,7 +2,6 @@
>
> #include "builtin.h"
> #include "environment.h"
> -#include "hex.h"
This include is indeed unused. I am currently working on a series [1]
that will use this header again. I can of course just re-add it in that
series as well though.
Thanks,
-Justin
[1]: <20260203221758.1164434-1-jltobler@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [GSoC] repo: remove unused header
2026-02-22 5:13 ` Justin Tobler
@ 2026-02-22 7:59 ` JAYATHEERTH K
0 siblings, 0 replies; 3+ messages in thread
From: JAYATHEERTH K @ 2026-02-22 7:59 UTC (permalink / raw)
To: Justin Tobler
Cc: git, karthik.188, ayu.chandekar, siddharthasthana31,
lucasseikioshiro
On Sun, Feb 22, 2026 at 10:43 AM Justin Tobler <jltobler@gmail.com> wrote:
>
> On 26/02/22 06:10AM, K Jayatheerth wrote:
> > The "hex.h" header is included in "builtin/repo.c", but none of the
> > functions or macros it provides are used in this file.
> >
> > Signed-off-by: K Jayatheerth <jayatheerthkulkarni2005@gmail.com>
> > ---
> >
> > As instructed in the Getting Started section of SoC 2026 Ideas page in repo project
> > This comes as a micro patch.
> >
> > builtin/repo.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/builtin/repo.c b/builtin/repo.c
> > index 0ea045abc1..63d21df4c2 100644
> > --- a/builtin/repo.c
> > +++ b/builtin/repo.c
> > @@ -2,7 +2,6 @@
> >
> > #include "builtin.h"
> > #include "environment.h"
> > -#include "hex.h"
>
> This include is indeed unused. I am currently working on a series [1]
> that will use this header again. I can of course just re-add it in that
> series as well though.
>
Understood Justin
Thanks for the info
Regards
- Jayatheerth
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-02-22 7:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-22 0:40 [GSoC] repo: remove unused header K Jayatheerth
2026-02-22 5:13 ` Justin Tobler
2026-02-22 7:59 ` JAYATHEERTH K
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox