From: Justin Tobler <jltobler@gmail.com>
To: Jeff King <peff@peff.net>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] object-file: use `container_of()` to convert from base types
Date: Sun, 22 Feb 2026 11:19:29 -0600 [thread overview]
Message-ID: <aZs6OvvBB4WPNx8j@denethor> (raw)
In-Reply-To: <20260222094158.GA1319383@coredump.intra.peff.net>
On 26/02/22 04:41AM, Jeff King wrote:
> On Sat, Feb 21, 2026 at 11:07:08PM -0800, Junio C Hamano wrote:
>
> > Perhaps a fix-up patch on top of the topic branch like this?
> >
> > ----- >8 -----
> > Subject: [PATCH] object-file.c: avoid container_of() of a NULL container
> > [...]
> > static void prepare_loose_object_transaction(struct odb_transaction *base)
> > {
> > - struct odb_transaction_files *transaction =
> > - container_of(base, struct odb_transaction_files, base);
> > + struct odb_transaction_files *transaction = NULL;
> > +
> > + if (base)
> > + transaction =
> > + container_of(base, struct odb_transaction_files, base);
>
> That works, but you can also use container_of_or_null() in the
> initializer. IMHO the result is easier to read.
I agree that container_of_or_null() looks a bit better here. Happy to
know about this now.
Thanks,
-Justin
next prev parent reply other threads:[~2026-02-22 17:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-18 21:01 [PATCH] object-file: use `container_of()` to convert from base types Justin Tobler
2026-02-19 13:43 ` Patrick Steinhardt
2026-02-20 16:07 ` Toon Claes
2026-02-22 7:07 ` Junio C Hamano
2026-02-22 9:41 ` Jeff King
2026-02-22 17:19 ` Justin Tobler [this message]
2026-02-22 20:36 ` Junio C Hamano
2026-02-22 20:16 ` [PATCH] object-file.c: avoid container_of() of a NULL container Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aZs6OvvBB4WPNx8j@denethor \
--to=jltobler@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox