public inbox for git@vger.kernel.org
 help / color / mirror / Atom feed
From: Mirko Faina <mroik@delayed.space>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>,
	 Mirko Faina <mroik@delayed.space>
Subject: Re: [PATCH v4 4/4] format-patch: add commitListFormat config
Date: Fri, 27 Feb 2026 22:51:57 +0100	[thread overview]
Message-ID: <aaIQcXgOVLHXP_WM@exploit> (raw)
In-Reply-To: <xmqqecm6rs6s.fsf@gitster.g>

On Fri, Feb 27, 2026 at 09:51:07AM -0800, Junio C Hamano wrote:
> Some sort of DWIM (e.g., it is not "shortlog", so it must be "log:"
> as there is nothing else supported) can be beneficial to help make
> it less cumbersome for users to type for command line options, just
> like we did for "git log --pretty=X" where we take a string with '%'
> in it as a cue to default to "--pretty=tformat:".  But as "set and
> forget" facility, there is no strong need to prefer "%s (%an)" over
> "log:%s (%an)" on the configuration variable side (other than being
> consistent to the command line option parsing).  We would probably
> want to give an escape hatch in the design to avoid painting
> ourselves into a corner we cannot get out of (imagine what happens
> when later others want to use something completely different from
> the log-pretty machinery, making "not a shortlog, must be log:"
> assumption invalid).
> 
> Something like
> 
>   "log:" is prefixed to the string value, UNLESS the value matches
>   "^[-a-z0-9]*$" or the value matches "^[-a-z0-9]*:".
> 
> would probably be extensible enough.  To avoid exposing regexp to
> the users, we can say "a string that is not an alphanumeric token,
> nor an alphanumeric token followed by a colon, is prefixed with
> 'log:'", or something.
> 
> WIth such rules in place, a new fixed format other than "shortlog"
> can be introduced (e.g., "middlelog") without getting munged into
> nonsense "log:middlelog", and a new parameterized format other than
> "log:" can be introduced (e.g., "pretty:%(subject) %(author)")
> without turning into a nonsense "log:pretty:%(subject) %(author)".
> 
> Or we do not have to worry about these if we just use what the user
> gives us without any DWIM.  I just do not think we want to see the
> "not a shortlog?  must be log" burned into the syntax that will have
> to stay with us forever.

Since we already require the prefix in the command line might as well
just make it the same for the configuration file. That way, if someone
will ever introduce a new preset format other than shortlog we just
check for "log:" first and then cascade into checking the rest of the
presets.

Please confirm that you like this and I'll start making changes to the
patch.

Thank you

  reply	other threads:[~2026-02-27 21:52 UTC|newest]

Thread overview: 113+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-20 23:06 [RFC PATCH] format-patch: better commit list for cover letter Mirko Faina
2026-02-20 23:55 ` [RFC PATCH v2] " Mirko Faina
2026-02-21  0:51   ` Mirko Faina
2026-02-21  4:54 ` [RFC PATCH] " Junio C Hamano
2026-02-21  5:18   ` Mirko Faina
2026-02-21  5:55     ` Junio C Hamano
2026-02-21  6:02       ` Junio C Hamano
2026-02-21 15:59         ` Mirko Faina
2026-02-21 17:33           ` Junio C Hamano
2026-02-21 19:16             ` Mirko Faina
2026-02-24  4:03 ` [PATCH 0/3] format-patch: add cover-letter-format option Mirko Faina
2026-02-24  4:06   ` Mirko Faina
2026-02-24  9:29   ` [PATCH v2 0/2] " Mirko Faina
2026-02-24  9:29     ` [PATCH v2 1/2] format-patch: add ability to use alt cover format Mirko Faina
2026-02-24 17:40       ` Junio C Hamano
2026-02-24 23:54         ` Mirko Faina
2026-02-25  0:29           ` Junio C Hamano
2026-02-25 13:47           ` Jeff King
2026-02-24 20:25       ` Junio C Hamano
2026-02-25 13:56       ` Jeff King
2026-02-25 22:55         ` Mirko Faina
2026-02-24  9:29     ` [PATCH v2 2/2] format-patch: add commitListFormat config Mirko Faina
2026-02-24 18:07       ` Junio C Hamano
2026-02-25  0:14         ` Mirko Faina
2026-02-25 17:25           ` Junio C Hamano
2026-02-26 21:40           ` Mirko Faina
2026-02-26 22:19             ` Junio C Hamano
2026-02-24 20:38     ` [PATCH v2 0/2] format-patch: add cover-letter-format option Junio C Hamano
2026-02-24 21:39       ` Junio C Hamano
2026-02-25  0:19         ` Mirko Faina
2026-02-25  2:46           ` Junio C Hamano
2026-02-27  1:52     ` [PATCH v3 0/4] " Mirko Faina
2026-02-27  1:52       ` [PATCH v3 1/4] pretty.c: add %(count) and %(total) placeholders Mirko Faina
2026-02-27  1:52       ` [PATCH v3 2/4] format-patch: move cover letter summary generation Mirko Faina
2026-02-27  1:52       ` [PATCH v3 3/4] format-patch: add ability to use alt cover format Mirko Faina
2026-02-27  4:23         ` Junio C Hamano
2026-02-27 12:41           ` Mirko Faina
2026-02-27  1:52       ` [PATCH v3 4/4] format-patch: add commitListFormat config Mirko Faina
2026-02-27 13:18       ` [PATCH v4 0/4] format-patch: add cover-letter-format option Mirko Faina
2026-02-27 13:18         ` [PATCH v4 1/4] pretty.c: add %(count) and %(total) placeholders Mirko Faina
2026-02-27 13:18         ` [PATCH v4 2/4] format-patch: move cover letter summary generation Mirko Faina
2026-02-27 13:18         ` [PATCH v4 3/4] format-patch: add ability to use alt cover format Mirko Faina
2026-02-27 13:18         ` [PATCH v4 4/4] format-patch: add commitListFormat config Mirko Faina
2026-02-27 16:42           ` [PATCH v4 5/4] docs: add usage for the cover-letter fmt feature Mirko Faina
2026-02-27 17:51           ` [PATCH v4 4/4] format-patch: add commitListFormat config Junio C Hamano
2026-02-27 21:51             ` Mirko Faina [this message]
2026-02-27 22:21               ` Junio C Hamano
2026-02-27 22:48         ` [PATCH v5 0/5] format-patch: add cover-letter-format option Mirko Faina
2026-02-27 22:48           ` [PATCH v5 1/5] pretty.c: add %(count) and %(total) placeholders Mirko Faina
2026-02-27 22:48           ` [PATCH v5 2/5] format-patch: move cover letter summary generation Mirko Faina
2026-02-27 22:48           ` [PATCH v5 3/5] format-patch: add ability to use alt cover format Mirko Faina
2026-02-27 22:48           ` [PATCH v5 4/5] format-patch: add commitListFormat config Mirko Faina
2026-02-27 22:48           ` [PATCH v5 5/5] docs: add usage for the cover-letter fmt feature Mirko Faina
2026-03-06 22:33           ` [PATCH v5 0/5] format-patch: add cover-letter-format option Junio C Hamano
2026-03-06 22:49             ` Mirko Faina
2026-03-06 22:58           ` [PATCH v6 " Mirko Faina
2026-03-06 22:58             ` [PATCH v6 1/5] pretty.c: add %(count) and %(total) placeholders Mirko Faina
2026-03-06 22:58             ` [PATCH v6 2/5] format-patch: move cover letter summary generation Mirko Faina
2026-03-06 22:58             ` [PATCH v6 3/5] format-patch: add ability to use alt cover format Mirko Faina
2026-03-10 22:14               ` Junio C Hamano
2026-03-10 22:32                 ` Mirko Faina
2026-03-06 22:58             ` [PATCH v6 4/5] format-patch: add commitListFormat config Mirko Faina
2026-03-06 22:58             ` [PATCH v6 5/5] docs: add usage for the cover-letter fmt feature Mirko Faina
2026-03-06 23:18               ` Junio C Hamano
2026-03-06 23:34             ` [PATCH v7 0/5] format-patch: add cover-letter-format option Mirko Faina
2026-03-06 23:34               ` [PATCH v7 1/5] pretty.c: add %(count) and %(total) placeholders Mirko Faina
2026-03-10 14:32                 ` Phillip Wood
2026-03-10 20:55                   ` Mirko Faina
2026-03-06 23:34               ` [PATCH v7 2/5] format-patch: move cover letter summary generation Mirko Faina
2026-03-06 23:34               ` [PATCH v7 3/5] format-patch: add ability to use alt cover format Mirko Faina
2026-03-10 14:33                 ` Phillip Wood
2026-03-10 21:05                   ` Mroik
2026-03-06 23:34               ` [PATCH v7 4/5] format-patch: add commitListFormat config Mirko Faina
2026-03-10 14:34                 ` Phillip Wood
2026-03-10 16:45                   ` Junio C Hamano
2026-03-10 21:23                     ` Mirko Faina
2026-03-11 10:38                       ` Phillip Wood
2026-03-11 17:13                         ` Junio C Hamano
2026-03-11 10:32                     ` Phillip Wood
2026-03-11 17:18                       ` Junio C Hamano
2026-03-10 21:19                   ` Mirko Faina
2026-03-06 23:34               ` [PATCH v7 5/5] docs: add usage for the cover-letter fmt feature Mirko Faina
2026-03-10  9:51                 ` Bert Wesarg
2026-03-10 14:34                 ` Phillip Wood
2026-03-12 16:20               ` [PATCH v8 0/4] format-patch: add cover-letter-format option Mirko Faina
2026-03-12 16:20                 ` [PATCH v8 1/4] format-patch: move cover letter summary generation Mirko Faina
2026-03-12 16:28                   ` Junio C Hamano
2026-03-12 16:20                 ` [PATCH v8 2/4] format-patch: add ability to use alt cover format Mirko Faina
2026-03-12 16:52                   ` Junio C Hamano
2026-03-12 17:18                     ` Mirko Faina
2026-03-12 17:25                       ` Junio C Hamano
2026-03-12 17:27                         ` Junio C Hamano
2026-03-13 10:38                         ` Phillip Wood
2026-03-13 17:20                           ` Junio C Hamano
2026-03-13 19:17                             ` Mirko Faina
2026-03-13 20:22                               ` Junio C Hamano
2026-03-12 16:20                 ` [PATCH v8 3/4] format-patch: add "chronological" format for cover Mirko Faina
2026-03-12 16:55                   ` Junio C Hamano
2026-03-12 16:20                 ` [PATCH v8 4/4] format-patch: add commitListFormat config Mirko Faina
2026-03-12 17:00                   ` Junio C Hamano
2026-03-12 17:20                 ` [PATCH v8 0/4] format-patch: add cover-letter-format option Junio C Hamano
2026-03-12 17:45                   ` Mirko Faina
2026-03-12 18:12                     ` Junio C Hamano
2026-02-24  4:03 ` [PATCH 1/3] pretty.c: fix null pointer dereference Mirko Faina
2026-02-24  6:25   ` Junio C Hamano
2026-02-24  7:08     ` Mirko Faina
2026-02-24  7:43       ` Mirko Faina
2026-02-24  8:41       ` Jeff King
2026-02-24  4:03 ` [PATCH 2/3] format-patch: add ability to use alt cover format Mirko Faina
2026-02-24  9:02   ` Jeff King
2026-02-24  9:09     ` Mirko Faina
2026-02-24  9:18       ` Jeff King
2026-02-24  4:03 ` [PATCH 3/3] format-patch: add commitListFormat config Mirko Faina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aaIQcXgOVLHXP_WM@exploit \
    --to=mroik@delayed.space \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox