public inbox for git@vger.kernel.org
 help / color / mirror / Atom feed
From: Patrick Steinhardt <ps@pks.im>
To: Justin Tobler <jltobler@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] ci: unset GITLAB_FEATURES envvar to not bust xargs(1) limits
Date: Tue, 3 Mar 2026 07:15:59 +0100	[thread overview]
Message-ID: <aaZ8nyJFjFqct2Ri@pks.im> (raw)
In-Reply-To: <aaXArnhYbtX9gsUU@denethor>

On Mon, Mar 02, 2026 at 11:11:52AM -0600, Justin Tobler wrote:
> On 26/03/02 12:55PM, Patrick Steinhardt wrote:
[snip]
> > The GITLAB_FEATURES environment variable makes up for roughly a third of
> > the complete environment. This variable is a comma-separated list of
> > features available for the GitLab instance, and seemingly it has been
> > growing over time as GitLab added more and more features.
> > 
> > Fix the issue by unsetting the environment variable in "ci/lib.sh". This
> > ensures that the environment variables are now smaller than the upper
> > limit on argument length again, and that in turn fixes the assert in
> > xargs(1).
> 
> So if we unset GITLAB_FEATURES, that puts us at 10987 bytes (17373 -
> 6386) which would be under the upper limit. Unsetting this environment
> variable seems like a reasonable means to mitigate this problem. Naive
> question: is the upper limit something we could increase for the
> environment?

Unfortunately not. Under normal Linux systems you'd be able to do that,
but in MSYS2 the limits are hardcoded as far as I could see.

Thanks!

Patrick

  reply	other threads:[~2026-03-03  6:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-02 11:55 [PATCH] ci: unset GITLAB_FEATURES envvar to not bust xargs(1) limits Patrick Steinhardt
2026-03-02 17:11 ` Justin Tobler
2026-03-03  6:15   ` Patrick Steinhardt [this message]
2026-03-03  6:32     ` Justin Tobler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aaZ8nyJFjFqct2Ri@pks.im \
    --to=ps@pks.im \
    --cc=git@vger.kernel.org \
    --cc=jltobler@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox