From: Patrick Steinhardt <ps@pks.im>
To: Justin Tobler <jltobler@gmail.com>
Cc: git@vger.kernel.org, gitster@pobox.com,
kristofferhaugsbakk@fastmail.com, lucasseikioshiro@gmail.com
Subject: Re: [PATCH v3 2/6] builtin/repo: add helper for printing keyvalue output
Date: Tue, 3 Mar 2026 14:27:17 +0100 [thread overview]
Message-ID: <aabhtfWZG90YyhQ5@pks.im> (raw)
In-Reply-To: <20260302214526.2034279-3-jltobler@gmail.com>
On Mon, Mar 02, 2026 at 03:45:22PM -0600, Justin Tobler wrote:
> diff --git a/builtin/repo.c b/builtin/repo.c
> index c7c9f0f497..782194cf4c 100644
> --- a/builtin/repo.c
> +++ b/builtin/repo.c
> @@ -446,44 +446,51 @@ static void stats_table_clear(struct stats_table *table)
> string_list_clear(&table->rows, 1);
> }
>
> +static inline void print_keyvalue(const char *key, char key_delim, size_t value,
> + char value_delim)
> +{
> + printf("%s%c%" PRIuMAX "%c", key, key_delim, (uintmax_t)value,
> + value_delim);
> +}
> +
> static void structure_keyvalue_print(struct repo_structure *stats,
> char key_delim, char value_delim)
> {
> - printf("references.branches.count%c%" PRIuMAX "%c", key_delim,
> - (uintmax_t)stats->refs.branches, value_delim);
> - printf("references.tags.count%c%" PRIuMAX "%c", key_delim,
> - (uintmax_t)stats->refs.tags, value_delim);
> - printf("references.remotes.count%c%" PRIuMAX "%c", key_delim,
> - (uintmax_t)stats->refs.remotes, value_delim);
> - printf("references.others.count%c%" PRIuMAX "%c", key_delim,
> - (uintmax_t)stats->refs.others, value_delim);
> -
> - printf("objects.commits.count%c%" PRIuMAX "%c", key_delim,
> - (uintmax_t)stats->objects.type_counts.commits, value_delim);
> - printf("objects.trees.count%c%" PRIuMAX "%c", key_delim,
> - (uintmax_t)stats->objects.type_counts.trees, value_delim);
> - printf("objects.blobs.count%c%" PRIuMAX "%c", key_delim,
> - (uintmax_t)stats->objects.type_counts.blobs, value_delim);
> - printf("objects.tags.count%c%" PRIuMAX "%c", key_delim,
> - (uintmax_t)stats->objects.type_counts.tags, value_delim);
> -
> - printf("objects.commits.inflated_size%c%" PRIuMAX "%c", key_delim,
> - (uintmax_t)stats->objects.inflated_sizes.commits, value_delim);
> - printf("objects.trees.inflated_size%c%" PRIuMAX "%c", key_delim,
> - (uintmax_t)stats->objects.inflated_sizes.trees, value_delim);
> - printf("objects.blobs.inflated_size%c%" PRIuMAX "%c", key_delim,
> - (uintmax_t)stats->objects.inflated_sizes.blobs, value_delim);
> - printf("objects.tags.inflated_size%c%" PRIuMAX "%c", key_delim,
> - (uintmax_t)stats->objects.inflated_sizes.tags, value_delim);
> -
> - printf("objects.commits.disk_size%c%" PRIuMAX "%c", key_delim,
> - (uintmax_t)stats->objects.disk_sizes.commits, value_delim);
> - printf("objects.trees.disk_size%c%" PRIuMAX "%c", key_delim,
> - (uintmax_t)stats->objects.disk_sizes.trees, value_delim);
> - printf("objects.blobs.disk_size%c%" PRIuMAX "%c", key_delim,
> - (uintmax_t)stats->objects.disk_sizes.blobs, value_delim);
> - printf("objects.tags.disk_size%c%" PRIuMAX "%c", key_delim,
> - (uintmax_t)stats->objects.disk_sizes.tags, value_delim);
> + print_keyvalue("references.branches.count", key_delim,
> + stats->refs.branches, value_delim);
> + print_keyvalue("references.tags.count", key_delim,
> + stats->refs.tags, value_delim);
> + print_keyvalue("references.remotes.count", key_delim,
> + stats->refs.remotes, value_delim);
> + print_keyvalue("references.others.count", key_delim,
> + stats->refs.others, value_delim);
> +
> + print_keyvalue("objects.commits.count", key_delim,
> + stats->objects.type_counts.commits, value_delim);
> + print_keyvalue("objects.trees.count", key_delim,
> + stats->objects.type_counts.trees, value_delim);
> + print_keyvalue("objects.blobs.count", key_delim,
> + stats->objects.type_counts.blobs, value_delim);
> + print_keyvalue("objects.tags.count", key_delim,
> + stats->objects.type_counts.tags, value_delim);
> +
> + print_keyvalue("objects.commits.inflated_size", key_delim,
> + stats->objects.inflated_sizes.commits, value_delim);
> + print_keyvalue("objects.trees.inflated_size", key_delim,
> + stats->objects.inflated_sizes.trees, value_delim);
> + print_keyvalue("objects.blobs.inflated_size", key_delim,
> + stats->objects.inflated_sizes.blobs, value_delim);
> + print_keyvalue("objects.tags.inflated_size", key_delim,
> + stats->objects.inflated_sizes.tags, value_delim);
> +
> + print_keyvalue("objects.commits.disk_size", key_delim,
> + stats->objects.disk_sizes.commits, value_delim);
> + print_keyvalue("objects.trees.disk_size", key_delim,
> + stats->objects.disk_sizes.trees, value_delim);
> + print_keyvalue("objects.blobs.disk_size", key_delim,
> + stats->objects.disk_sizes.blobs, value_delim);
> + print_keyvalue("objects.tags.disk_size", key_delim,
> + stats->objects.disk_sizes.tags, value_delim);
It's still easy to miss any mismatch here, but I guess the result is
definitely easier to read regardless of that.
Thanks!
Patrick
next prev parent reply other threads:[~2026-03-03 13:27 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-03 22:17 [PATCH 0/5] builtin/repo: include largest object information Justin Tobler
2026-02-03 22:17 ` [PATCH 1/5] builtin/repo: update stats for each object Justin Tobler
2026-02-03 22:36 ` Junio C Hamano
2026-02-18 19:40 ` Justin Tobler
2026-02-26 19:20 ` Junio C Hamano
2026-02-26 19:29 ` Justin Tobler
2026-02-03 22:17 ` [PATCH 2/5] builtin/repo: collect largest inflated objects Justin Tobler
2026-02-03 22:45 ` Junio C Hamano
2026-02-18 20:01 ` Justin Tobler
2026-02-03 22:17 ` [PATCH 3/5] builtin/repo: add OID annotations to table output Justin Tobler
2026-02-13 13:14 ` Patrick Steinhardt
2026-02-18 20:13 ` Justin Tobler
2026-02-03 22:17 ` [PATCH 4/5] builtin/repo: find commit with most parents Justin Tobler
2026-02-03 22:48 ` Junio C Hamano
2026-02-03 23:14 ` Kristoffer Haugsbakk
2026-02-03 23:33 ` Junio C Hamano
2026-02-18 20:06 ` Justin Tobler
2026-02-03 22:17 ` [PATCH 5/5] builtin/repo: find tree with most entries Justin Tobler
2026-02-03 22:50 ` Junio C Hamano
2026-02-04 8:28 ` Patrick Steinhardt
2026-02-04 15:28 ` Junio C Hamano
2026-02-23 17:41 ` [PATCH v2 0/5] builtin/repo: include largest object information Justin Tobler
2026-02-23 17:41 ` [PATCH v2 1/5] builtin/repo: update stats for each object Justin Tobler
2026-02-23 17:41 ` [PATCH v2 2/5] builtin/repo: collect largest inflated objects Justin Tobler
2026-02-26 19:50 ` Junio C Hamano
2026-03-02 17:28 ` Justin Tobler
2026-02-28 23:36 ` Lucas Seiki Oshiro
2026-03-02 17:38 ` Justin Tobler
2026-02-23 17:41 ` [PATCH v2 3/5] builtin/repo: add OID annotations to table output Justin Tobler
2026-02-26 19:56 ` Junio C Hamano
2026-03-02 17:39 ` Justin Tobler
2026-02-23 17:41 ` [PATCH v2 4/5] builtin/repo: find commit with most parents Justin Tobler
2026-02-23 17:41 ` [PATCH v2 5/5] builtin/repo: find tree with most entries Justin Tobler
2026-02-24 9:35 ` [PATCH v2 0/5] builtin/repo: include largest object information Patrick Steinhardt
2026-02-28 23:43 ` Lucas Seiki Oshiro
2026-03-01 19:22 ` Justin Tobler
2026-03-02 21:45 ` [PATCH v3 0/6] " Justin Tobler
2026-03-02 21:45 ` [PATCH v3 1/6] builtin/repo: update stats for each object Justin Tobler
2026-03-02 21:45 ` [PATCH v3 2/6] builtin/repo: add helper for printing keyvalue output Justin Tobler
2026-03-03 13:27 ` Patrick Steinhardt [this message]
2026-03-03 17:40 ` Junio C Hamano
2026-03-03 18:08 ` Justin Tobler
2026-03-02 21:45 ` [PATCH v3 3/6] builtin/repo: collect largest inflated objects Justin Tobler
2026-03-03 13:27 ` Patrick Steinhardt
2026-03-02 21:45 ` [PATCH v3 4/6] builtin/repo: add OID annotations to table output Justin Tobler
2026-03-02 21:45 ` [PATCH v3 5/6] builtin/repo: find commit with most parents Justin Tobler
2026-03-02 21:45 ` [PATCH v3 6/6] builtin/repo: find tree with most entries Justin Tobler
2026-03-02 22:09 ` [PATCH v3 0/6] builtin/repo: include largest object information Junio C Hamano
2026-03-06 22:36 ` Junio C Hamano
2026-03-08 18:44 ` Justin Tobler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aabhtfWZG90YyhQ5@pks.im \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jltobler@gmail.com \
--cc=kristofferhaugsbakk@fastmail.com \
--cc=lucasseikioshiro@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox