From: Derrick Stolee <stolee@gmail.com>
To: Emily Shaffer <emilyshaffer@google.com>, git@vger.kernel.org
Subject: Re: [PATCH] submodule: add newline on invalid submodule error
Date: Fri, 7 Feb 2020 08:55:12 -0500 [thread overview]
Message-ID: <aacd5724-fdb6-832c-4af9-22c1831baea2@gmail.com> (raw)
In-Reply-To: <20200207004833.255965-1-emilyshaffer@google.com>
On 2/6/2020 7:48 PM, Emily Shaffer wrote:
> Since 'err' contains output for multiple submodules and is printed all
> at once by fetch_populated_submodules(), errors for each submodule
> should be newline separated for readability. The same strbuf is added to
> with a newline in the other half of the conditional where this error is
> detected, so make the two consistent.
A worthy goal, and thanks for pointing out that this matches the
"Fetching submodule %s%s\n" string in the other block.
> - _("Could not access submodule '%s'"),
> + _("Could not access submodule '%s'\n"),
My initial thought was that this `\n` should be added in front of the
string, and only if the string has existing data. However, that's not
what happens in the other block, so doing it that way would require
changing both places. This approach is also less error-prone, even if
it may result in an "extra" newline at the end of all the messages.
LGTM.
Thanks,
-Stolee
prev parent reply other threads:[~2020-02-07 13:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-07 0:48 [PATCH] submodule: add newline on invalid submodule error Emily Shaffer
2020-02-07 13:55 ` Derrick Stolee [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aacd5724-fdb6-832c-4af9-22c1831baea2@gmail.com \
--to=stolee@gmail.com \
--cc=emilyshaffer@google.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).