From: Patrick Steinhardt <ps@pks.im>
To: Yuvraj Singh Chauhan <ysinghcin@gmail.com>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH 1/2] t7412: fix typo 'submodue' in test_description
Date: Wed, 4 Mar 2026 06:16:18 +0100 [thread overview]
Message-ID: <aafAIqqq1PdzmQW3@pks.im> (raw)
In-Reply-To: <20260303175750.361563-1-ysinghcin@gmail.com>
On Tue, Mar 03, 2026 at 11:27:49PM +0530, Yuvraj Singh Chauhan wrote:
One micro nit, not worth rerolling over: I think in general we prefer to
have at least a sentence in the commit message body, even if it repeats
most of what the subject has already said.
At least for me it makes the review a bit easier, as the subject of the
message will be gone at the time I start writing a reply during the
review.
> Signed-off-by: Yuvraj Singh Chauhan <ysinghcin@gmail.com>
> ---
> t/t7412-submodule-absorbgitdirs.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/t/t7412-submodule-absorbgitdirs.sh b/t/t7412-submodule-absorbgitdirs.sh
> index 0490499573..41ee035e3c 100755
> --- a/t/t7412-submodule-absorbgitdirs.sh
> +++ b/t/t7412-submodule-absorbgitdirs.sh
> @@ -2,7 +2,7 @@
>
> test_description='Test submodule absorbgitdirs
>
> -This test verifies that `git submodue absorbgitdirs` moves a submodules git
> +This test verifies that `git submodule absorbgitdirs` moves a submodules git
> directory into the superproject.
> '
An obvious fix indeed.
Patrick
prev parent reply other threads:[~2026-03-04 5:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-03 17:57 [PATCH 1/2] t7412: fix typo 'submodue' in test_description Yuvraj Singh Chauhan
2026-03-03 17:57 ` [PATCH 2/2] t7412: modernize path checks to use test helper functions Yuvraj Singh Chauhan
2026-03-04 5:16 ` Patrick Steinhardt
2026-03-04 5:16 ` Patrick Steinhardt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aafAIqqq1PdzmQW3@pks.im \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ysinghcin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox