public inbox for git@vger.kernel.org
 help / color / mirror / Atom feed
From: Justin Tobler <jltobler@gmail.com>
To: Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>
Cc: git@vger.kernel.org, Patrick Steinhardt <ps@pks.im>
Subject: Re: [PATCH] Documentation: extend guidance for submitting patches
Date: Thu, 5 Mar 2026 19:48:49 -0600	[thread overview]
Message-ID: <aaowCeEMjpztZpti@denethor> (raw)
In-Reply-To: <be9cbba2-883a-4ef8-838e-0941b75eee6f@app.fastmail.com>

On 26/03/05 11:27PM, Kristoffer Haugsbakk wrote:
> On Thu, Mar 5, 2026, at 20:38, Justin Tobler wrote:
> > +It is also a good idea to check whether your topic has been discussed
> > +previously on the mailing list,
> 
> This is at the start of the document. “The mailing list” footnote
> (git-ml) does not get mentioned until line 535.
> 
> Although there is the initial mention of `MyFirstContribution` which
> prominently features the address at the start.

We also mention "the list" several times in the surround bullet points
prior to the footnote too. If we think it matters I can move the
footnote up.

> > or whether similar work is already in
> > +progress.  Prior discussions may contain useful context, design
> > +considerations, or earlier attempts at solving the same problem. Being
> > +aware of such discussions can help you avoid duplicating work and may
> > +allow you to coordinate with other contributors working in the same
> > +area.
> > +
> 
> This seems useful to cite. It seems less useful for people who go to the
> effort of reading this file themselves. They presumably care enough to
> try to get the procedural steps correct. It’s difficult to imagine that
> they either think that their idea has to be unique or that there isn’t a
> history.

Ya, I agree that most folks who feel inclined to read this document
proactively would likely also lookup previous/on-going mailing list
discussions. I do think this would be useful though to include so we can
point contributors this direction when needed.

Thanks,
-Justin

  reply	other threads:[~2026-03-06  1:48 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-05 19:38 [PATCH] Documentation: extend guidance for submitting patches Justin Tobler
2026-03-05 20:35 ` Junio C Hamano
2026-03-05 21:27   ` Justin Tobler
2026-03-05 21:35     ` Junio C Hamano
2026-03-05 21:43       ` Justin Tobler
2026-03-05 22:27 ` Kristoffer Haugsbakk
2026-03-06  1:48   ` Justin Tobler [this message]
2026-03-06 10:56     ` Kristoffer Haugsbakk
2026-03-06 12:58 ` brian m. carlson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aaowCeEMjpztZpti@denethor \
    --to=jltobler@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=kristofferhaugsbakk@fastmail.com \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox