From: Patrick Steinhardt <ps@pks.im>
To: Karthik Nayak <karthik.188@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v2 00/14] odb: generic object name handling
Date: Fri, 20 Mar 2026 11:30:35 +0100 [thread overview]
Message-ID: <ab0hy6AitZFMf3RO@pks.im> (raw)
In-Reply-To: <CAOLa=ZSeMS2iKzgMUWix_Sx+e24863PsOazRLrqHtS5hYSUk3A@mail.gmail.com>
On Fri, Mar 20, 2026 at 03:04:02AM -0700, Karthik Nayak wrote:
> Patrick Steinhardt <ps@pks.im> writes:
>
> > Hi,
> >
> > this patch series refactors handling of object names to become pluggable
> > and thus generic. This includes:
> >
> > - Disambiguation of object names with a common prefix. This is
> > required to list candidate objects in case the user has passed a
> > non-unique prefix.
> >
> > - Abbreviating an object ID to the shortest prefix required while
> > staying unique.
> >
> > The logic to compute these operations is specific to the backend, but
> > not generic. This patch series fixes that by moving the functionality
> > into the respective backends.
> >
> > This patch series may feel somewhat unexiting, but it's not. Especially
> > abbreviating object IDs is done in lots of places, so this functionality
> > is overall quite critical. So starting with this series, it is now
> > possible to do all kinds of local work with an alternative backend:
> > git-commit(1), git-log(1), git-rev-parse(1), git-merge(1) and many other
> > commands now work as expected. My MongoDB proof of concept [1] only
> > requires two commits (the object format extension) on top. And no, I
> > don't endorse MongoDB or propose it as a future potential backend. It
> > simply had a good C API that was easy to use.
> >
> > Of course, other functionality, especially everything that involves
> > packfiles, doesn't yet work.
> >
> > This patch series is built on top of ca1db8a0f7 (The 17th batch,
> > 2026-03-16) with ps/object-counting at 6801ffd37d (odb: introduce
> > generic object counting, 2026-03-12) merged into it.
> >
> > Changes in v2:
> > - Document `cb_iter` callback.
> > - Fix left-over conversion of `odb_source_loose_for_each_object()`.
> > - commit message typo fixes.
> > - Link to v1: https://lore.kernel.org/r/20260319-b4-pks-odb-source-abbrev-v1-0-5ddebad292b0@pks.im
>
> I only got around to reviewing v1 now, but the range-diff here looks
> good.
Thanks for your review!
Patrick
prev parent reply other threads:[~2026-03-20 10:30 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-19 6:52 [PATCH 00/14] odb: generic object name handling Patrick Steinhardt
2026-03-19 6:52 ` [PATCH 01/14] oidtree: modernize the code a bit Patrick Steinhardt
2026-03-19 16:08 ` Junio C Hamano
2026-03-20 6:40 ` Patrick Steinhardt
2026-03-20 22:30 ` brian m. carlson
2026-03-23 6:22 ` Patrick Steinhardt
2026-03-19 6:53 ` [PATCH 02/14] oidtree: extend iteration to allow for arbitrary return codes Patrick Steinhardt
2026-03-19 16:27 ` Junio C Hamano
2026-03-20 6:40 ` Patrick Steinhardt
2026-03-19 16:27 ` Karthik Nayak
2026-03-19 6:53 ` [PATCH 03/14] odb: introduce `struct odb_for_each_object_options` Patrick Steinhardt
2026-03-19 14:25 ` Junio C Hamano
2026-03-19 14:59 ` Patrick Steinhardt
2026-03-20 9:01 ` Karthik Nayak
2026-03-19 6:53 ` [PATCH 04/14] object-name: move logic to iterate through loose prefixed objects Patrick Steinhardt
2026-03-19 6:53 ` [PATCH 05/14] object-name: move logic to iterate through packed " Patrick Steinhardt
2026-03-19 6:53 ` [PATCH 06/14] object-name: extract function to parse object ID prefixes Patrick Steinhardt
2026-03-19 6:53 ` [PATCH 07/14] object-name: backend-generic `repo_collect_ambiguous()` Patrick Steinhardt
2026-03-19 14:26 ` Junio C Hamano
2026-03-19 14:59 ` Patrick Steinhardt
2026-03-20 9:23 ` Karthik Nayak
2026-03-19 6:53 ` [PATCH 08/14] object-name: backend-generic `get_short_oid()` Patrick Steinhardt
2026-03-19 6:53 ` [PATCH 09/14] object-name: merge `update_candidates()` and `match_prefix()` Patrick Steinhardt
2026-03-19 6:53 ` [PATCH 10/14] object-name: abbreviate loose object names without `disambiguate_state` Patrick Steinhardt
2026-03-19 6:53 ` [PATCH 11/14] object-name: simplify computing common prefixes Patrick Steinhardt
2026-03-20 10:01 ` Karthik Nayak
2026-03-20 10:30 ` Patrick Steinhardt
2026-03-19 6:53 ` [PATCH 12/14] object-name: move logic to compute loose abbreviation length Patrick Steinhardt
2026-03-19 6:53 ` [PATCH 13/14] object-file: move logic to compute packed " Patrick Steinhardt
2026-03-19 6:53 ` [PATCH 14/14] odb: introduce generic `odb_find_abbrev_len()` Patrick Steinhardt
2026-03-20 7:07 ` [PATCH v2 00/14] odb: generic object name handling Patrick Steinhardt
2026-03-20 7:07 ` [PATCH v2 01/14] oidtree: modernize the code a bit Patrick Steinhardt
2026-03-20 7:07 ` [PATCH v2 02/14] oidtree: extend iteration to allow for arbitrary return codes Patrick Steinhardt
2026-03-20 7:07 ` [PATCH v2 03/14] odb: introduce `struct odb_for_each_object_options` Patrick Steinhardt
2026-03-20 7:07 ` [PATCH v2 04/14] object-name: move logic to iterate through loose prefixed objects Patrick Steinhardt
2026-03-20 7:07 ` [PATCH v2 05/14] object-name: move logic to iterate through packed " Patrick Steinhardt
2026-03-20 7:07 ` [PATCH v2 06/14] object-name: extract function to parse object ID prefixes Patrick Steinhardt
2026-03-20 7:07 ` [PATCH v2 07/14] object-name: backend-generic `repo_collect_ambiguous()` Patrick Steinhardt
2026-03-20 7:07 ` [PATCH v2 08/14] object-name: backend-generic `get_short_oid()` Patrick Steinhardt
2026-03-20 7:07 ` [PATCH v2 09/14] object-name: merge `update_candidates()` and `match_prefix()` Patrick Steinhardt
2026-03-20 7:07 ` [PATCH v2 10/14] object-name: abbreviate loose object names without `disambiguate_state` Patrick Steinhardt
2026-03-20 7:07 ` [PATCH v2 11/14] object-name: simplify computing common prefixes Patrick Steinhardt
2026-03-20 7:07 ` [PATCH v2 12/14] object-name: move logic to compute loose abbreviation length Patrick Steinhardt
2026-03-20 7:07 ` [PATCH v2 13/14] object-file: move logic to compute packed " Patrick Steinhardt
2026-03-20 7:07 ` [PATCH v2 14/14] odb: introduce generic `odb_find_abbrev_len()` Patrick Steinhardt
2026-03-20 10:04 ` [PATCH v2 00/14] odb: generic object name handling Karthik Nayak
2026-03-20 10:30 ` Patrick Steinhardt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab0hy6AitZFMf3RO@pks.im \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=karthik.188@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox