public inbox for git@vger.kernel.org
 help / color / mirror / Atom feed
From: Patrick Steinhardt <ps@pks.im>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 0/8] Some build system improvements
Date: Wed, 11 Mar 2026 08:32:08 +0100	[thread overview]
Message-ID: <abEaeC1kRsGyQYWy@pks.im> (raw)
In-Reply-To: <xmqqwlzjtufv.fsf@gitster.g>

On Tue, Mar 10, 2026 at 11:23:32AM -0700, Junio C Hamano wrote:
> Patrick Steinhardt <ps@pks.im> writes:
> 
> > Patrick Steinhardt (8):
> >       Introduce new "tools/" directory
> >       contrib: move "coccinelle/" directory into "tools/"
> 
> Even though "make coccicheck" may not care where the coccinelle
> stuff lives, if this step changes the location of the resulting
> coccinelle-generated patch in the tree, it will have fallouts to
> developer workflows.  The blast radius may be limited, as those
> other than Git developers will be hurt, though.
> 
> I mention this to forewarn others early, but I do not have a strong
> objection against this step; at least not yet, even though I may
> change my mind if the fallout turns out to be greater than I
> anticipated.

Yup, that's completely fair. Thanks!

Patrick

  reply	other threads:[~2026-03-11  7:32 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-10 17:52 [PATCH 0/8] Some build system improvements Patrick Steinhardt
2026-03-10 17:52 ` [PATCH 1/8] Introduce new "tools/" directory Patrick Steinhardt
2026-03-10 17:52 ` [PATCH 2/8] contrib: move "coccinelle/" directory into "tools/" Patrick Steinhardt
2026-03-10 17:52 ` [PATCH 3/8] contrib: move "coverage-diff.sh" script " Patrick Steinhardt
2026-03-10 17:52 ` [PATCH 4/8] contrib: move "update-unicode.sh" " Patrick Steinhardt
2026-03-10 17:52 ` [PATCH 5/8] builds: move build scripts " Patrick Steinhardt
2026-03-10 17:52 ` [PATCH 6/8] git-compat-util.h: move warning infra to prepare for PCHs Patrick Steinhardt
2026-03-10 17:52 ` [PATCH 7/8] meson: compile compatibility sources separately Patrick Steinhardt
2026-03-11 14:32   ` Phillip Wood
2026-03-11 14:56     ` Phillip Wood
2026-03-11 23:27       ` SZEDER Gábor
2026-03-12  6:21         ` Patrick Steinhardt
2026-03-13 10:33           ` Phillip Wood
2026-03-16  8:09             ` Patrick Steinhardt
2026-03-12  6:22       ` Patrick Steinhardt
2026-03-13 10:33         ` Phillip Wood
2026-03-16  8:09           ` Patrick Steinhardt
2026-03-16 10:52             ` Phillip Wood
2026-03-17 15:38   ` Kristoffer Haugsbakk
2026-03-19  5:32     ` Patrick Steinhardt
2026-03-10 17:52 ` [PATCH 8/8] meson: precompile "git-compat-util.h" Patrick Steinhardt
2026-03-11 14:32   ` Phillip Wood
2026-03-12  6:21     ` Patrick Steinhardt
2026-03-10 18:23 ` [PATCH 0/8] Some build system improvements Junio C Hamano
2026-03-11  7:32   ` Patrick Steinhardt [this message]
2026-03-13 22:21 ` Junio C Hamano
2026-03-16  8:09   ` Patrick Steinhardt
2026-03-16 10:07 ` [PATCH v2 " Patrick Steinhardt
2026-03-16 10:07   ` [PATCH v2 1/8] Introduce new "tools/" directory Patrick Steinhardt
2026-03-16 10:07   ` [PATCH v2 2/8] contrib: move "coccinelle/" directory into "tools/" Patrick Steinhardt
2026-03-16 10:07   ` [PATCH v2 3/8] contrib: move "coverage-diff.sh" script " Patrick Steinhardt
2026-03-16 10:07   ` [PATCH v2 4/8] contrib: move "update-unicode.sh" " Patrick Steinhardt
2026-03-16 10:08   ` [PATCH v2 5/8] builds: move build scripts " Patrick Steinhardt
2026-03-16 10:08   ` [PATCH v2 6/8] git-compat-util.h: move warning infra to prepare for PCHs Patrick Steinhardt
2026-03-16 10:08   ` [PATCH v2 7/8] meson: compile compatibility sources separately Patrick Steinhardt
2026-03-16 10:08   ` [PATCH v2 8/8] meson: precompile "git-compat-util.h" Patrick Steinhardt
2026-03-16 10:54   ` [PATCH v2 0/8] Some build system improvements Phillip Wood
2026-03-19  5:33 ` [PATCH v3 " Patrick Steinhardt
2026-03-19  5:33   ` [PATCH v3 1/8] Introduce new "tools/" directory Patrick Steinhardt
2026-03-19  5:33   ` [PATCH v3 2/8] contrib: move "coccinelle/" directory into "tools/" Patrick Steinhardt
2026-03-19  5:33   ` [PATCH v3 3/8] contrib: move "coverage-diff.sh" script " Patrick Steinhardt
2026-03-20 12:15     ` Toon Claes
2026-03-19  5:33   ` [PATCH v3 4/8] contrib: move "update-unicode.sh" " Patrick Steinhardt
2026-03-19  5:33   ` [PATCH v3 5/8] builds: move build scripts " Patrick Steinhardt
2026-03-19  5:33   ` [PATCH v3 6/8] git-compat-util.h: move warning infra to prepare for PCHs Patrick Steinhardt
2026-03-20 12:34     ` Toon Claes
2026-03-19  5:33   ` [PATCH v3 7/8] meson: compile compatibility sources separately Patrick Steinhardt
2026-03-19  5:33   ` [PATCH v3 8/8] meson: precompile "git-compat-util.h" Patrick Steinhardt
2026-03-20 12:37     ` Toon Claes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=abEaeC1kRsGyQYWy@pks.im \
    --to=ps@pks.im \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox