From: Patrick Steinhardt <ps@pks.im>
To: "Burak Kaan Karaçay" <bkkaracay@gmail.com>
Cc: git@vger.kernel.org, christian.couder@gmail.com,
karthik.188@gmail.com, jltobler@gmail.com,
ayu.chandekar@gmail.com, siddharthasthana31@gmail.com,
l.s.r@web.de, peff@peff.net, gitster@pobox.com
Subject: Re: [PATCH v2] run-command: wean start_command() off the_repository
Date: Thu, 12 Mar 2026 11:01:03 +0100 [thread overview]
Message-ID: <abKO3155A9mw2pbO@pks.im> (raw)
In-Reply-To: <20260312085341.631318-1-bkkaracay@gmail.com>
On Thu, Mar 12, 2026 at 11:53:41AM +0300, Burak Kaan Karaçay wrote:
> The start_command() relies on the_repository due to the
> close_object_store flag in 'struct child_process'. When this flag is
> set, start_command() closes the object store associated with
> the_repository before spawning a child process.
>
> To eliminate this dependency, replace the 'close_object_store' with the
> new 'odb_to_close' field. This allows callers to specify the object
> store that needs to be closed.
I really like this solution.
There's now only a single other function that still uses
`the_repository` in `prepare_auto_maintenance()`. Do we maybe want to
add a second commit that converts this function and its caller
`run_auto_maintenance()` to receive the repository as parameter so that
we can drop the `USE_THE_REPOSITORY_VARIABLE` declaration?
Thanks!
Patrick
next prev parent reply other threads:[~2026-03-12 10:01 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-11 15:19 [PATCH 0/4] wean start_command() off the_repository Burak Kaan Karaçay
2026-03-11 15:19 ` [PATCH 1/4] run-command: add repo_start_command() Burak Kaan Karaçay
2026-03-11 15:19 ` [PATCH 2/4] run-command: use repo_start_command() in strict callers Burak Kaan Karaçay
2026-03-11 19:26 ` Junio C Hamano
2026-03-11 15:19 ` [PATCH 3/4] run-command: redefine start_command() as a wrapper macro Burak Kaan Karaçay
2026-03-11 15:19 ` [PATCH 4/4] cocci: convert start_command() to repo_start_command() Burak Kaan Karaçay
2026-03-11 18:18 ` [PATCH 0/4] wean start_command() off the_repository René Scharfe
2026-03-11 18:45 ` Jeff King
2026-03-11 19:09 ` Burak Kaan Karaçay
2026-03-11 19:35 ` Junio C Hamano
2026-03-11 19:30 ` Junio C Hamano
2026-03-12 8:53 ` [PATCH v2] run-command: " Burak Kaan Karaçay
2026-03-12 10:01 ` Patrick Steinhardt [this message]
2026-03-12 14:44 ` [PATCH v3 0/2] run-command: stop using the_repository Burak Kaan Karaçay
2026-03-12 14:44 ` [PATCH v3 1/2] run-command: wean start_command() off the_repository Burak Kaan Karaçay
2026-03-12 14:44 ` [PATCH v3 2/2] run-command: wean auto_maintenance() functions " Burak Kaan Karaçay
2026-03-12 15:29 ` [PATCH v3 0/2] run-command: stop using the_repository Junio C Hamano
2026-03-13 6:23 ` Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abKO3155A9mw2pbO@pks.im \
--to=ps@pks.im \
--cc=ayu.chandekar@gmail.com \
--cc=bkkaracay@gmail.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jltobler@gmail.com \
--cc=karthik.188@gmail.com \
--cc=l.s.r@web.de \
--cc=peff@peff.net \
--cc=siddharthasthana31@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox