From: Michael Spang <spang@google.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Johannes Sixt <j6t@kdbg.org>, git@vger.kernel.org
Subject: Re: [PATCH] Fix git rev-list --reverse --max-count=N
Date: Wed, 27 Jan 2010 17:51:02 -0500 [thread overview]
Message-ID: <abef960f1001271451n5ed454aaye1591ea35729b53f@mail.gmail.com> (raw)
In-Reply-To: <7vsk9rnpxo.fsf@alter.siamese.dyndns.org>
On Wed, Jan 27, 2010 at 5:28 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Johannes Sixt <j6t@kdbg.org> writes:
>
> The interaction between --max-count and --reverse was designed a long time
> ago to support "I want to review the recent N commits in order to make
> sure that they are natural and logical progression". So an unconditional
> change of semantics to break that expectation this late in the game will
> never be acceptable, and giving title to such a patch with a word "Fix"
> won't fly well (it simply _breaks_ behaviour users have long learned to
> expect).
You have my apology for calling it a fix. I just don't have the same
visibility into what undocumented behavior users depend on that you
do, and so I thought it actually was one.
The patch can die here. I understand the current behavior now, and I
don't have a strong need for the behavior I expected (piping to head
works fine).
Michael
prev parent reply other threads:[~2010-01-27 22:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-27 20:03 [PATCH] Fix git rev-list --reverse --max-count=N Michael Spang
2010-01-27 22:09 ` Johannes Sixt
2010-01-27 22:17 ` Sverre Rabbelier
2010-01-27 22:21 ` Michael Spang
2010-01-27 22:28 ` Junio C Hamano
2010-01-27 22:51 ` Michael Spang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abef960f1001271451n5ed454aaye1591ea35729b53f@mail.gmail.com \
--to=spang@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).