public inbox for git@vger.kernel.org
 help / color / mirror / Atom feed
From: Patrick Steinhardt <ps@pks.im>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 03/14] odb: introduce `struct odb_for_each_object_options`
Date: Thu, 19 Mar 2026 15:59:19 +0100	[thread overview]
Message-ID: <abwPR1NgOShKXh8P@pks.im> (raw)
In-Reply-To: <xmqqse9vnbgb.fsf@gitster.g>

On Thu, Mar 19, 2026 at 07:25:08AM -0700, Junio C Hamano wrote:
> Patrick Steinhardt <ps@pks.im> writes:
> 
> > While we could of course add the prefix to the function signature, or
> > alternative introduce a new function, both of these options don't really
> > seem to be that sensible.
> 
> "alternative" -> "alternatigvely"?

I prefer "alternatively" :) Will fix.

> > Instead, introduce a new `struct odb_for_each_object_options` that can
> > be passed to a new `odb_for_each_object_ext()` function. Splice through
> > the options structure into the respective object database sources.
> 
> A lot of churn, but we only need to suffer once and reap a lot of
> benefit later, I guess ;-).

Right, that's the idea. I also got the intent to eventually support
object filters in `odb_for_each_object_ext()`, which will be required
for example by git-cat-file(1). This would require splicing through
another parameter, but with this change here it will only require us to
add another new field to the options structure.

Patrick

  reply	other threads:[~2026-03-19 14:59 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-19  6:52 [PATCH 00/14] odb: generic object name handling Patrick Steinhardt
2026-03-19  6:52 ` [PATCH 01/14] oidtree: modernize the code a bit Patrick Steinhardt
2026-03-19 16:08   ` Junio C Hamano
2026-03-20  6:40     ` Patrick Steinhardt
2026-03-20 22:30       ` brian m. carlson
2026-03-23  6:22         ` Patrick Steinhardt
2026-03-19  6:53 ` [PATCH 02/14] oidtree: extend iteration to allow for arbitrary return codes Patrick Steinhardt
2026-03-19 16:27   ` Junio C Hamano
2026-03-20  6:40     ` Patrick Steinhardt
2026-03-19 16:27   ` Karthik Nayak
2026-03-19  6:53 ` [PATCH 03/14] odb: introduce `struct odb_for_each_object_options` Patrick Steinhardt
2026-03-19 14:25   ` Junio C Hamano
2026-03-19 14:59     ` Patrick Steinhardt [this message]
2026-03-20  9:01   ` Karthik Nayak
2026-03-19  6:53 ` [PATCH 04/14] object-name: move logic to iterate through loose prefixed objects Patrick Steinhardt
2026-03-19  6:53 ` [PATCH 05/14] object-name: move logic to iterate through packed " Patrick Steinhardt
2026-03-19  6:53 ` [PATCH 06/14] object-name: extract function to parse object ID prefixes Patrick Steinhardt
2026-03-19  6:53 ` [PATCH 07/14] object-name: backend-generic `repo_collect_ambiguous()` Patrick Steinhardt
2026-03-19 14:26   ` Junio C Hamano
2026-03-19 14:59     ` Patrick Steinhardt
2026-03-20  9:23   ` Karthik Nayak
2026-03-19  6:53 ` [PATCH 08/14] object-name: backend-generic `get_short_oid()` Patrick Steinhardt
2026-03-19  6:53 ` [PATCH 09/14] object-name: merge `update_candidates()` and `match_prefix()` Patrick Steinhardt
2026-03-19  6:53 ` [PATCH 10/14] object-name: abbreviate loose object names without `disambiguate_state` Patrick Steinhardt
2026-03-19  6:53 ` [PATCH 11/14] object-name: simplify computing common prefixes Patrick Steinhardt
2026-03-20 10:01   ` Karthik Nayak
2026-03-20 10:30     ` Patrick Steinhardt
2026-03-19  6:53 ` [PATCH 12/14] object-name: move logic to compute loose abbreviation length Patrick Steinhardt
2026-03-19  6:53 ` [PATCH 13/14] object-file: move logic to compute packed " Patrick Steinhardt
2026-03-19  6:53 ` [PATCH 14/14] odb: introduce generic `odb_find_abbrev_len()` Patrick Steinhardt
2026-03-20  7:07 ` [PATCH v2 00/14] odb: generic object name handling Patrick Steinhardt
2026-03-20  7:07   ` [PATCH v2 01/14] oidtree: modernize the code a bit Patrick Steinhardt
2026-03-20  7:07   ` [PATCH v2 02/14] oidtree: extend iteration to allow for arbitrary return codes Patrick Steinhardt
2026-03-20  7:07   ` [PATCH v2 03/14] odb: introduce `struct odb_for_each_object_options` Patrick Steinhardt
2026-03-20  7:07   ` [PATCH v2 04/14] object-name: move logic to iterate through loose prefixed objects Patrick Steinhardt
2026-03-20  7:07   ` [PATCH v2 05/14] object-name: move logic to iterate through packed " Patrick Steinhardt
2026-03-20  7:07   ` [PATCH v2 06/14] object-name: extract function to parse object ID prefixes Patrick Steinhardt
2026-03-20  7:07   ` [PATCH v2 07/14] object-name: backend-generic `repo_collect_ambiguous()` Patrick Steinhardt
2026-03-20  7:07   ` [PATCH v2 08/14] object-name: backend-generic `get_short_oid()` Patrick Steinhardt
2026-03-20  7:07   ` [PATCH v2 09/14] object-name: merge `update_candidates()` and `match_prefix()` Patrick Steinhardt
2026-03-20  7:07   ` [PATCH v2 10/14] object-name: abbreviate loose object names without `disambiguate_state` Patrick Steinhardt
2026-03-20  7:07   ` [PATCH v2 11/14] object-name: simplify computing common prefixes Patrick Steinhardt
2026-03-20  7:07   ` [PATCH v2 12/14] object-name: move logic to compute loose abbreviation length Patrick Steinhardt
2026-03-20  7:07   ` [PATCH v2 13/14] object-file: move logic to compute packed " Patrick Steinhardt
2026-03-20  7:07   ` [PATCH v2 14/14] odb: introduce generic `odb_find_abbrev_len()` Patrick Steinhardt
2026-03-20 10:04   ` [PATCH v2 00/14] odb: generic object name handling Karthik Nayak
2026-03-20 10:30     ` Patrick Steinhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=abwPR1NgOShKXh8P@pks.im \
    --to=ps@pks.im \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox