From: Patrick Steinhardt <ps@pks.im>
To: Ramsay Jones <ramsay@ramsayjones.plus.com>
Cc: Junio C Hamano <gitster@pobox.com>,
GIT Mailing-list <git@vger.kernel.org>
Subject: Re: Subject: [PATCH] object-file: fix sparse 'plain integer as NULL pointer' error
Date: Fri, 20 Mar 2026 07:14:23 +0100 [thread overview]
Message-ID: <abzlv_6qzZcjluic@pks.im> (raw)
In-Reply-To: <12187836-0b2d-4e82-ae0c-4da972aee7e7@ramsayjones.plus.com>
On Fri, Mar 20, 2026 at 03:44:08AM +0000, Ramsay Jones wrote:
>
> On 20/03/2026 02:04, Ramsay Jones wrote:
> >
> > On 20/03/2026 1:35 am, Junio C Hamano wrote:
> > > Ramsay Jones <ramsay@ramsayjones.plus.com> writes:
> > >
> > > > Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> > > > ---
> > > >
> > > > Hi Patrick,
> > > >
> > > > When you next re-roll your 'ps/object-counting' branch, could you please squash this
> > > > into the patch equivalent to the commit 2b24db1110 ("object-file: generalize counting
> > > > objects",2026-03-12) in tonight's 'seen' branch.
> > > The topic being in 'next' since March 17th, that is a bit awkward to
> > > arrange. I can queue the fix on top instead.
> > Hmm, odd. I didn't do a 'branch --contains', obviously, but this only started tonight
> > (and I built git yesterday - master, next and seen), so I just assumed ... ;)
> >
> > Sorry about that.
> >
>
> Heh, I could not sleep, so took another look! :)
>
>
> The problem was actually caused by the 'ps/odb-generic-object-name-handling'
> branch and commit 936c2bfecb ("odb: introduce
>
> `struct odb_for_each_object_options`", 2026-03-19). In particular, that
> commit changes the type of the last parameter of the
>
> odb_source_loose_for_each_object() function from 'unsigned' to 'const struct
> odb_for_each_object_options *', without
>
> changing one call site from '0' to 'NULL'.
>
>
> OK, I can go to bed now!
Thanks for catching this! Fixed locally now.
Patrick
next prev parent reply other threads:[~2026-03-20 6:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-19 22:49 Subject: [PATCH] object-file: fix sparse 'plain integer as NULL pointer' error Ramsay Jones
2026-03-20 1:35 ` Junio C Hamano
2026-03-20 2:04 ` Ramsay Jones
2026-03-20 3:44 ` Ramsay Jones
2026-03-20 6:14 ` Patrick Steinhardt [this message]
2026-03-20 6:05 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abzlv_6qzZcjluic@pks.im \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ramsay@ramsayjones.plus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox