git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Derrick Stolee <stolee@gmail.com>
To: Jeff King <peff@peff.net>
Cc: Bradley Smith <brad@brad-smith.co.uk>,
	Junio C Hamano <gitster@pobox.com>,
	James Coglan <jcoglan@gmail.com>,
	git@vger.kernel.org
Subject: Re: Assertion in git log graphing [regression in v2.25]
Date: Tue, 7 Jan 2020 09:43:55 -0500	[thread overview]
Message-ID: <ac6d3172-699e-5a61-fa60-420980c49fad@gmail.com> (raw)
In-Reply-To: <39277f9a-f88d-94a3-2a8b-b6e0a3dfdc62@gmail.com>

On 1/7/2020 9:22 AM, Derrick Stolee wrote:
> Note how 6_M4 has three parents, and the first parent has a horizontal
> edge. Even giving an extra padding line between horizontal edges, we
> _could_ output the following instead:
> 
> 
> | | | | | | *   6_M4
> | |_|_|_|_|/|\
> |/| | | | |/ /
> | | |_|_|/| /
> | |/| | | |/
> | | | |_|/|
> | | |/| | |
> | | * | | | 6_G

I should have tested this example with v2.24.1, which gives this output
in this section:

| | | | | | *-.   6_M4
| | | | | | |\ \  
| |_|_|_|_|/ / /  
|/| | | | | / /   
| | |_|_|_|/ /    
| |/| | | | /     
| | | |_|_|/      
| | |/| | |       
| | * | | | 6_G

So, this is likely the behavior we would prefer.

For the release, it is likely best to keep the change that does not
collapse properly and fix this collapse bug later. (It is likely an
invasive change.)

Thanks,
-Stolee

  reply	other threads:[~2020-01-07 14:43 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-07 11:24 Assertion in git log graphing Bradley Smith
2020-01-07 11:48 ` Assertion in git log graphing [regression in v2.25] Jeff King
2020-01-07 12:22   ` Derrick Stolee
2020-01-07 12:42     ` Derrick Stolee
2020-01-07 12:50       ` Eric Sunshine
2020-01-07 12:56         ` Derrick Stolee
2020-01-07 13:14           ` Eric Sunshine
2020-01-07 13:25   ` Derrick Stolee
2020-01-07 14:04     ` Jeff King
2020-01-07 14:22       ` Derrick Stolee
2020-01-07 14:43         ` Derrick Stolee [this message]
2020-01-07 14:57 ` Assertion in git log graphing Derrick Stolee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ac6d3172-699e-5a61-fa60-420980c49fad@gmail.com \
    --to=stolee@gmail.com \
    --cc=brad@brad-smith.co.uk \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jcoglan@gmail.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).