* [PATCH 0/7] improve "git format-patch --commit-list-format"
@ 2026-03-14 23:20 Mirko Faina
2026-03-14 23:20 ` [PATCH 1/7] pretty.c: better die message %(count) and %(total) Mirko Faina
` (7 more replies)
0 siblings, 8 replies; 42+ messages in thread
From: Mirko Faina @ 2026-03-14 23:20 UTC (permalink / raw)
To: git; +Cc: Mirko Faina
This series aims to improve the --commit-list-format (former
--cover-letter-format) option for format-patch by improving a bit the
user interaction with the option (and its configuration variable
counterpart), removing the ability to use the configuration variable in
an ambiguous way (which also causes problems when interacting with it
through the cli interface) and introducing a new format preset.
This series is based on top of 67006b9db8 (The 15th batch, 2026-03-12)
with the following series merged into it:
- mf/format-patch-cover-letter-format at 51ed9f7e72 (docs: add usage
for the cover-letter fmt feature, 2026-03-07)
[1/7] pretty.c: better die message %(count) and %(total) (Mirko Faina)
[2/7] format-patch: refactor generate_commit_list_cover (Mirko Faina)
[3/7] format-patch: rename --cover-letter-format option (Mirko Faina)
[4/7] format.commitListFormat: strip meaning from empty (Mirko Faina)
[5/7] format-patch: wrap generate_commit_list_cover() (Mirko Faina)
[6/7] format-patch: add preset for --commit-list-format (Mirko Faina)
[7/7] format-patch: --commit-list-format without prefix (Mirko Faina)
Documentation/config/format.adoc | 2 +-
Documentation/git-format-patch.adoc | 19 ++++----
builtin/log.c | 35 +++++++-------
pretty.c | 4 +-
t/t4014-format-patch.sh | 72 +++++++++++++++++++----------
t/t9902-completion.sh | 1 -
6 files changed, 80 insertions(+), 53 deletions(-)
--
2.53.0.959.g497ff81fa9
^ permalink raw reply [flat|nested] 42+ messages in thread* [PATCH 1/7] pretty.c: better die message %(count) and %(total) 2026-03-14 23:20 [PATCH 0/7] improve "git format-patch --commit-list-format" Mirko Faina @ 2026-03-14 23:20 ` Mirko Faina 2026-03-14 23:20 ` [PATCH 2/7] format-patch: refactor generate_commit_list_cover Mirko Faina ` (6 subsequent siblings) 7 siblings, 0 replies; 42+ messages in thread From: Mirko Faina @ 2026-03-14 23:20 UTC (permalink / raw) To: git; +Cc: Mirko Faina Improve die messages for commands that do not support %(count) and %(total) Signed-off-by: Mirko Faina <mroik@delayed.space> --- pretty.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pretty.c b/pretty.c index 74673714c8..814803980b 100644 --- a/pretty.c +++ b/pretty.c @@ -1551,7 +1551,7 @@ static size_t format_commit_one(struct strbuf *sb, /* in UTF-8 */ if (starts_with(placeholder, "(count)")) { if (!c->pretty_ctx->rev) - die(_("this format specifier can't be used with this command")); + die(_("%s is not supported by this command"), "%(count)"); strbuf_addf(sb, "%0*d", decimal_width(c->pretty_ctx->rev->total), c->pretty_ctx->rev->nr); return 7; @@ -1559,7 +1559,7 @@ static size_t format_commit_one(struct strbuf *sb, /* in UTF-8 */ if (starts_with(placeholder, "(total)")) { if (!c->pretty_ctx->rev) - die(_("this format specifier can't be used with this command")); + die(_("%s is not supported by this command"), "%(total)"); strbuf_addf(sb, "%d", c->pretty_ctx->rev->total); return 7; } -- 2.53.0.959.g497ff81fa9 ^ permalink raw reply related [flat|nested] 42+ messages in thread
* [PATCH 2/7] format-patch: refactor generate_commit_list_cover 2026-03-14 23:20 [PATCH 0/7] improve "git format-patch --commit-list-format" Mirko Faina 2026-03-14 23:20 ` [PATCH 1/7] pretty.c: better die message %(count) and %(total) Mirko Faina @ 2026-03-14 23:20 ` Mirko Faina 2026-03-14 23:20 ` [PATCH 3/7] format-patch: rename --cover-letter-format option Mirko Faina ` (5 subsequent siblings) 7 siblings, 0 replies; 42+ messages in thread From: Mirko Faina @ 2026-03-14 23:20 UTC (permalink / raw) To: git; +Cc: Mirko Faina Refactor for readability and remove unnecessary initialization. Signed-off-by: Mirko Faina <mroik@delayed.space> --- builtin/log.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/builtin/log.c b/builtin/log.c index 716ebc2701..997bdd608e 100644 --- a/builtin/log.c +++ b/builtin/log.c @@ -1376,12 +1376,11 @@ static void generate_commit_list_cover(FILE *cover_file, const char *format, struct pretty_print_context ctx = {0}; struct rev_info rev = REV_INFO_INIT; - strbuf_init(&commit_line, 0); rev.total = n; ctx.rev = &rev; - for (int i = n - 1; i >= 0; i--) { - rev.nr = n - i; - repo_format_commit_message(the_repository, list[i], format, + for (int i = 1; i <= n; i++) { + rev.nr = i; + repo_format_commit_message(the_repository, list[n - i], format, &commit_line, &ctx); fprintf(cover_file, "%s\n", commit_line.buf); strbuf_reset(&commit_line); -- 2.53.0.959.g497ff81fa9 ^ permalink raw reply related [flat|nested] 42+ messages in thread
* [PATCH 3/7] format-patch: rename --cover-letter-format option 2026-03-14 23:20 [PATCH 0/7] improve "git format-patch --commit-list-format" Mirko Faina 2026-03-14 23:20 ` [PATCH 1/7] pretty.c: better die message %(count) and %(total) Mirko Faina 2026-03-14 23:20 ` [PATCH 2/7] format-patch: refactor generate_commit_list_cover Mirko Faina @ 2026-03-14 23:20 ` Mirko Faina 2026-03-14 23:20 ` [PATCH 4/7] format.commitListFormat: strip meaning from empty Mirko Faina ` (4 subsequent siblings) 7 siblings, 0 replies; 42+ messages in thread From: Mirko Faina @ 2026-03-14 23:20 UTC (permalink / raw) To: git; +Cc: Mirko Faina To align the name of the configuration variable and the name of the command line option, either one should change name. By changing the name of the option we get the added benefit of having --cover-<TAB> expand to --cover-letter without ambiguity. If the user gives the --cover-letter-format option it would be reasonable to expect that the user wants to generate the cover letter despite not giving --cover-letter. Rename --cover-letter-format to --commit-list-format and make it imply --cover-letter unless --no-cover-letter is given. Signed-off-by: Mirko Faina <mroik@delayed.space> --- Documentation/git-format-patch.adoc | 17 ++++++------ builtin/log.c | 4 ++- t/t4014-format-patch.sh | 41 +++++++++++++++-------------- t/t9902-completion.sh | 1 - 4 files changed, 32 insertions(+), 31 deletions(-) diff --git a/Documentation/git-format-patch.adoc b/Documentation/git-format-patch.adoc index 31fa492335..45ca72e670 100644 --- a/Documentation/git-format-patch.adoc +++ b/Documentation/git-format-patch.adoc @@ -24,7 +24,7 @@ SYNOPSIS [(--reroll-count|-v) <n>] [--to=<email>] [--cc=<email>] [--[no-]cover-letter] [--quiet] - [--cover-letter-format=<format-spec>] + [--commit-list-format=<format-spec>] [--[no-]encode-email-headers] [--no-notes | --notes[=<ref>]] [--interdiff=<previous>] @@ -323,16 +323,15 @@ feeding the result to `git send-email`. containing the branch description, shortlog and the overall diffstat. You can fill in a description in the file before sending it out. ---cover-letter-format=<format-spec>:: - Specify the format in which to generate the commit list of the - patch series. This option is available if the user wants to use - an alternative to the default `shortlog` format. The accepted - values for format-spec are "shortlog" or a format string - prefixed with `log:`. +--commit-list-format=<format-spec>:: + Specify the format in which to generate the commit list of the patch + series. The accepted values for format-spec are "shortlog" or a format + string prefixed with `log:`. e.g. `log: %s (%an)` - If defined, defaults to the `format.commitListFormat` configuration + If not given, defaults to the `format.commitListFormat` configuration variable. - This option is relevant only if a cover letter is generated. + This option implies the use of `--cover-letter` unless + `--no-cover-letter` is given. --encode-email-headers:: --no-encode-email-headers:: diff --git a/builtin/log.c b/builtin/log.c index 997bdd608e..a7f129d583 100644 --- a/builtin/log.c +++ b/builtin/log.c @@ -2014,7 +2014,7 @@ int cmd_format_patch(int argc, N_("print patches to standard out")), OPT_BOOL(0, "cover-letter", &cover_letter, N_("generate a cover letter")), - OPT_STRING(0, "cover-letter-format", &cover_letter_fmt, N_("format-spec"), + OPT_STRING(0, "commit-list-format", &cover_letter_fmt, N_("format-spec"), N_("format spec used for the commit list in the cover letter")), OPT_BOOL(0, "numbered-files", &just_numbers, N_("use simple number sequence for output file names")), @@ -2358,6 +2358,8 @@ int cmd_format_patch(int argc, cover_letter_fmt = cfg.fmt_cover_letter_commit_list; if (!cover_letter_fmt) cover_letter_fmt = "shortlog"; + } else if (cover_letter == -1) { + cover_letter = 1; } if (cover_letter == -1) { diff --git a/t/t4014-format-patch.sh b/t/t4014-format-patch.sh index 7c67bdf922..d2a775f78d 100755 --- a/t/t4014-format-patch.sh +++ b/t/t4014-format-patch.sh @@ -383,49 +383,50 @@ test_expect_success 'filename limit applies only to basename' ' test_expect_success 'cover letter with subject, author and count' ' rm -rf patches && test_when_finished "git reset --hard HEAD~1" && - test_when_finished "rm -rf patches result test_file" && + test_when_finished "rm -rf patches test_file" && touch test_file && git add test_file && git commit -m "This is a subject" && - git format-patch --cover-letter \ - --cover-letter-format="log:[%(count)/%(total)] %s (%an)" -o patches HEAD~1 && - grep "^\[1/1\] This is a subject (A U Thor)$" patches/0000-cover-letter.patch >result && - test_line_count = 1 result + git format-patch --commit-list-format="log:[%(count)/%(total)] %s (%an)" \ + -o patches HEAD~1 && + test_grep "^\[1/1\] This is a subject (A U Thor)$" patches/0000-cover-letter.patch ' -test_expected_success 'cover letter with author and count' ' +test_expect_success 'cover letter with author and count' ' test_when_finished "git reset --hard HEAD~1" && - test_when_finished "rm -rf patches result test_file" && + test_when_finished "rm -rf patches test_file" && touch test_file && git add test_file && git commit -m "This is a subject" && - git format-patch --cover-letter \ - --cover-letter-format="log:[%(count)/%(total)] %an" -o patches HEAD~1 && - grep "^\[1/1\] A U Thor$" patches/0000-cover-letter.patch >result && - test_line_count = 1 result + git format-patch --commit-list-format="log:[%(count)/%(total)] %an" \ + -o patches HEAD~1 && + test_grep "^\[1/1\] A U Thor$" patches/0000-cover-letter.patch ' test_expect_success 'cover letter shortlog' ' test_when_finished "git reset --hard HEAD~1" && - test_when_finished "rm -rf patches result test_file" && + test_when_finished "rm -rf expect patches result test_file" && + cat >expect <<-"EOF" && + A U Thor (1): + This is a subject + EOF touch test_file && git add test_file && git commit -m "This is a subject" && - git format-patch --cover-letter --cover-letter-format=shortlog \ - -o patches HEAD~1 && - sed -n -e "/^A U Thor/p;" patches/0000-cover-letter.patch >result && - test_line_count = 1 result + git format-patch --commit-list-format=shortlog -o patches HEAD~1 && + grep -E -A 1 "^A U Thor \([[:digit:]]+\):$" patches/0000-cover-letter.patch >result && + cat result && + test_cmp expect result ' -test_expect_success 'cover letter no format' ' +test_expect_success 'no cover letter but with format specified' ' test_when_finished "git reset --hard HEAD~1" && test_when_finished "rm -rf patches result test_file" && touch test_file && git add test_file && git commit -m "This is a subject" && - git format-patch --cover-letter -o patches HEAD~1 && - sed -n -e "/^A U Thor/p;" patches/0000-cover-letter.patch >result && - test_line_count = 1 result + git format-patch --no-cover-letter --commit-list-format="[%(count)] %s" -o patches HEAD~1 && + test_path_is_missing patches/0000-cover-letter.patch ' test_expect_success 'cover letter config with count, subject and author' ' diff --git a/t/t9902-completion.sh b/t/t9902-completion.sh index 35e20b5351..2f9a597ec7 100755 --- a/t/t9902-completion.sh +++ b/t/t9902-completion.sh @@ -2775,7 +2775,6 @@ test_expect_success PERL 'send-email' ' test_completion "git send-email --cov" <<-\EOF && --cover-from-description=Z --cover-letter Z - --cover-letter-format=Z EOF test_completion "git send-email --val" <<-\EOF && --validate Z -- 2.53.0.959.g497ff81fa9 ^ permalink raw reply related [flat|nested] 42+ messages in thread
* [PATCH 4/7] format.commitListFormat: strip meaning from empty 2026-03-14 23:20 [PATCH 0/7] improve "git format-patch --commit-list-format" Mirko Faina ` (2 preceding siblings ...) 2026-03-14 23:20 ` [PATCH 3/7] format-patch: rename --cover-letter-format option Mirko Faina @ 2026-03-14 23:20 ` Mirko Faina 2026-03-14 23:20 ` [PATCH 5/7] format-patch: wrap generate_commit_list_cover() Mirko Faina ` (3 subsequent siblings) 7 siblings, 0 replies; 42+ messages in thread From: Mirko Faina @ 2026-03-14 23:20 UTC (permalink / raw) To: git; +Cc: Mirko Faina The configuration variable format.commitListFormat allows for an empty value. This is unusual and can create issues when interacting with this configuration variable through the cli interface. Strip meaning to format.commitListFormat with an empty value. Signed-off-by: Mirko Faina <mroik@delayed.space> --- builtin/log.c | 11 +---------- t/t4014-format-patch.sh | 11 ----------- 2 files changed, 1 insertion(+), 21 deletions(-) diff --git a/builtin/log.c b/builtin/log.c index a7f129d583..47126f9064 100644 --- a/builtin/log.c +++ b/builtin/log.c @@ -1055,17 +1055,8 @@ static int git_format_config(const char *var, const char *value, return 0; } if (!strcmp(var, "format.commitlistformat")) { - struct strbuf tmp = STRBUF_INIT; - strbuf_init(&tmp, 0); - if (value) - strbuf_addstr(&tmp, value); - else - strbuf_addstr(&tmp, "log:[%(count)/%(total)] %s"); - FREE_AND_NULL(cfg->fmt_cover_letter_commit_list); - git_config_string(&cfg->fmt_cover_letter_commit_list, var, tmp.buf); - strbuf_release(&tmp); - return 0; + return git_config_string(&cfg->fmt_cover_letter_commit_list, var, value); } if (!strcmp(var, "format.outputdirectory")) { FREE_AND_NULL(cfg->config_output_directory); diff --git a/t/t4014-format-patch.sh b/t/t4014-format-patch.sh index d2a775f78d..ca37f40a6a 100755 --- a/t/t4014-format-patch.sh +++ b/t/t4014-format-patch.sh @@ -451,17 +451,6 @@ test_expect_success 'cover letter config with count and author' ' test_line_count = 2 result ' -test_expect_success 'cover letter config commitlistformat set but no format' ' - test_when_finished "rm -rf patches result" && - test_when_finished "git config unset format.coverletter" && - test_when_finished "git config unset format.commitlistformat" && - git config set format.coverletter true && - printf "\tcommitlistformat" >> .git/config && - git format-patch -o patches HEAD~2 && - grep -E "^[[[:digit:]]+/[[:digit:]]+] .*" patches/0000-cover-letter.patch >result && - test_line_count = 2 result -' - test_expect_success 'cover letter config commitlistformat set to shortlog' ' test_when_finished "rm -rf patches result" && test_when_finished "git config unset format.coverletter" && -- 2.53.0.959.g497ff81fa9 ^ permalink raw reply related [flat|nested] 42+ messages in thread
* [PATCH 5/7] format-patch: wrap generate_commit_list_cover() 2026-03-14 23:20 [PATCH 0/7] improve "git format-patch --commit-list-format" Mirko Faina ` (3 preceding siblings ...) 2026-03-14 23:20 ` [PATCH 4/7] format.commitListFormat: strip meaning from empty Mirko Faina @ 2026-03-14 23:20 ` Mirko Faina 2026-03-17 15:32 ` Kristoffer Haugsbakk 2026-03-14 23:20 ` [PATCH 6/7] format-patch: add preset for --commit-list-format Mirko Faina ` (2 subsequent siblings) 7 siblings, 1 reply; 42+ messages in thread From: Mirko Faina @ 2026-03-14 23:20 UTC (permalink / raw) To: git; +Cc: Mirko Faina While most conventions should not allow for the text lines in commit messages to get too long, when they do it could make emails harder to read. Teach generate_commit_list_cover() to wrap its commit lines if they happend to be too long. Signed-off-by: Mirko Faina <mroik@delayed.space> --- builtin/log.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/builtin/log.c b/builtin/log.c index 47126f9064..d1765ce4ad 100644 --- a/builtin/log.c +++ b/builtin/log.c @@ -40,6 +40,7 @@ #include "progress.h" #include "commit-slab.h" #include "advice.h" +#include "utf8.h" #include "commit-reach.h" #include "range-diff.h" @@ -1364,6 +1365,7 @@ static void generate_commit_list_cover(FILE *cover_file, const char *format, struct commit **list, int n) { struct strbuf commit_line = STRBUF_INIT; + struct strbuf wrapped_line = STRBUF_INIT; struct pretty_print_context ctx = {0}; struct rev_info rev = REV_INFO_INIT; @@ -1373,12 +1375,16 @@ static void generate_commit_list_cover(FILE *cover_file, const char *format, rev.nr = i; repo_format_commit_message(the_repository, list[n - i], format, &commit_line, &ctx); - fprintf(cover_file, "%s\n", commit_line.buf); + strbuf_add_wrapped_text(&wrapped_line, commit_line.buf, 0, 0, + MAIL_DEFAULT_WRAP); + fprintf(cover_file, "%s\n", wrapped_line.buf); strbuf_reset(&commit_line); + strbuf_reset(&wrapped_line); } fprintf(cover_file, "\n"); strbuf_release(&commit_line); + strbuf_release(&wrapped_line); } static void make_cover_letter(struct rev_info *rev, int use_separate_file, -- 2.53.0.959.g497ff81fa9 ^ permalink raw reply related [flat|nested] 42+ messages in thread
* Re: [PATCH 5/7] format-patch: wrap generate_commit_list_cover() 2026-03-14 23:20 ` [PATCH 5/7] format-patch: wrap generate_commit_list_cover() Mirko Faina @ 2026-03-17 15:32 ` Kristoffer Haugsbakk 2026-03-17 16:18 ` Mirko Faina 0 siblings, 1 reply; 42+ messages in thread From: Kristoffer Haugsbakk @ 2026-03-17 15:32 UTC (permalink / raw) To: Mirko Faina, git On Sun, Mar 15, 2026, at 00:20, Mirko Faina wrote: > While most conventions should not allow for the text lines in commit > messages to get too long, when they do it could make emails harder to > read. > > Teach generate_commit_list_cover() to wrap its commit lines if they > happend to be too long. s/happend/happen/ But “happen to be” is a bit redundant. You can just say: wrap if they are too long. > > Signed-off-by: Mirko Faina <mroik@delayed.space> >[snip] ^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH 5/7] format-patch: wrap generate_commit_list_cover() 2026-03-17 15:32 ` Kristoffer Haugsbakk @ 2026-03-17 16:18 ` Mirko Faina 0 siblings, 0 replies; 42+ messages in thread From: Mirko Faina @ 2026-03-17 16:18 UTC (permalink / raw) To: Kristoffer Haugsbakk; +Cc: git, Mirko Faina On Tue, Mar 17, 2026 at 04:32:26PM +0100, Kristoffer Haugsbakk wrote: > On Sun, Mar 15, 2026, at 00:20, Mirko Faina wrote: > > While most conventions should not allow for the text lines in commit > > messages to get too long, when they do it could make emails harder to > > read. > > > > Teach generate_commit_list_cover() to wrap its commit lines if they > > happend to be too long. > > s/happend/happen/ > > But “happen to be” is a bit redundant. You can just say: wrap if they > are too long. Will do, thanks ^ permalink raw reply [flat|nested] 42+ messages in thread
* [PATCH 6/7] format-patch: add preset for --commit-list-format 2026-03-14 23:20 [PATCH 0/7] improve "git format-patch --commit-list-format" Mirko Faina ` (4 preceding siblings ...) 2026-03-14 23:20 ` [PATCH 5/7] format-patch: wrap generate_commit_list_cover() Mirko Faina @ 2026-03-14 23:20 ` Mirko Faina 2026-03-14 23:20 ` [PATCH 7/7] format-patch: --commit-list-format without prefix Mirko Faina 2026-03-19 22:38 ` [PATCH v2 0/8] improve "git format-patch --commit-list-format" Mirko Faina 7 siblings, 0 replies; 42+ messages in thread From: Mirko Faina @ 2026-03-14 23:20 UTC (permalink / raw) To: git; +Cc: Mirko Faina "git format-patch --commit-list-format" enables the user to make their own format for the commit list in the cover letter. It would be nice to have a ready to use format to replace shortlog. Teach make_cover_letter() the "modern" format preset. This new format is the same as: "log:[%(count)/%(total)] %s". Signed-off-by: Mirko Faina <mroik@delayed.space> --- Documentation/config/format.adoc | 2 +- Documentation/git-format-patch.adoc | 4 ++-- builtin/log.c | 3 +++ t/t4014-format-patch.sh | 20 +++++++++++++++----- 4 files changed, 21 insertions(+), 8 deletions(-) diff --git a/Documentation/config/format.adoc b/Documentation/config/format.adoc index ea5ec5df7a..ef1ed1d250 100644 --- a/Documentation/config/format.adoc +++ b/Documentation/config/format.adoc @@ -104,7 +104,7 @@ format.coverLetter:: format.commitListFormat:: When the `--cover-letter-format` option is not given, `format-patch` uses the value of this variable to decide how to format the title of - each commit. Default to `shortlog`. + each commit. Defaults to `shortlog`. format.outputDirectory:: Set a custom directory to store the resulting files instead of the diff --git a/Documentation/git-format-patch.adoc b/Documentation/git-format-patch.adoc index 45ca72e670..55cc680685 100644 --- a/Documentation/git-format-patch.adoc +++ b/Documentation/git-format-patch.adoc @@ -325,8 +325,8 @@ feeding the result to `git send-email`. --commit-list-format=<format-spec>:: Specify the format in which to generate the commit list of the patch - series. The accepted values for format-spec are "shortlog" or a format - string prefixed with `log:`. + series. The accepted values for format-spec are `shortlog`, `modern` or a + format string prefixed with `log:`. e.g. `log: %s (%an)` If not given, defaults to the `format.commitListFormat` configuration variable. diff --git a/builtin/log.c b/builtin/log.c index d1765ce4ad..c6cf04350a 100644 --- a/builtin/log.c +++ b/builtin/log.c @@ -1445,6 +1445,9 @@ static void make_cover_letter(struct rev_info *rev, int use_separate_file, generate_commit_list_cover(rev->diffopt.file, format, list, nr); else if (!strcmp(format, "shortlog")) generate_shortlog_cover_letter(&log, rev, list, nr); + else if (!strcmp(format, "modern")) + generate_commit_list_cover(rev->diffopt.file, "[%(count)/%(total)] %s", + list, nr); else die(_("'%s' is not a valid format string"), format); diff --git a/t/t4014-format-patch.sh b/t/t4014-format-patch.sh index ca37f40a6a..7571cc582b 100755 --- a/t/t4014-format-patch.sh +++ b/t/t4014-format-patch.sh @@ -392,18 +392,17 @@ test_expect_success 'cover letter with subject, author and count' ' test_grep "^\[1/1\] This is a subject (A U Thor)$" patches/0000-cover-letter.patch ' -test_expect_success 'cover letter with author and count' ' +test_expect_success 'cover letter modern format' ' test_when_finished "git reset --hard HEAD~1" && test_when_finished "rm -rf patches test_file" && touch test_file && git add test_file && git commit -m "This is a subject" && - git format-patch --commit-list-format="log:[%(count)/%(total)] %an" \ - -o patches HEAD~1 && - test_grep "^\[1/1\] A U Thor$" patches/0000-cover-letter.patch + git format-patch --commit-list-format="modern" -o patches HEAD~1 && + test_grep "^\[1/1\] This is a subject$" patches/0000-cover-letter.patch ' -test_expect_success 'cover letter shortlog' ' +test_expect_success 'cover letter shortlog format' ' test_when_finished "git reset --hard HEAD~1" && test_when_finished "rm -rf expect patches result test_file" && cat >expect <<-"EOF" && @@ -451,6 +450,17 @@ test_expect_success 'cover letter config with count and author' ' test_line_count = 2 result ' +test_expect_success 'cover letter config commitlistformat set to modern' ' + test_when_finished "rm -rf patches result" && + test_when_finished "git config unset format.coverletter" && + test_when_finished "git config unset format.commitlistformat" && + git config set format.coverletter true && + git config set format.commitlistformat modern && + git format-patch -o patches HEAD~2 && + grep -E "^[[[:digit:]]+/[[:digit:]]+] .*$" patches/0000-cover-letter.patch >result && + test_line_count = 2 result +' + test_expect_success 'cover letter config commitlistformat set to shortlog' ' test_when_finished "rm -rf patches result" && test_when_finished "git config unset format.coverletter" && -- 2.53.0.959.g497ff81fa9 ^ permalink raw reply related [flat|nested] 42+ messages in thread
* [PATCH 7/7] format-patch: --commit-list-format without prefix 2026-03-14 23:20 [PATCH 0/7] improve "git format-patch --commit-list-format" Mirko Faina ` (5 preceding siblings ...) 2026-03-14 23:20 ` [PATCH 6/7] format-patch: add preset for --commit-list-format Mirko Faina @ 2026-03-14 23:20 ` Mirko Faina 2026-03-17 15:29 ` Kristoffer Haugsbakk 2026-03-19 22:38 ` [PATCH v2 0/8] improve "git format-patch --commit-list-format" Mirko Faina 7 siblings, 1 reply; 42+ messages in thread From: Mirko Faina @ 2026-03-14 23:20 UTC (permalink / raw) To: git; +Cc: Mirko Faina Having to prefix a custom format-string with "log:" when passed from the cli interface can be annoying for many users. It would be great if it could be dropped an it were still accepted. Teach make_cover_letter() to accept custom format-strings if a placeholder is detected. Note that both here and in "git log --format" the check is done naively by just checking for the presence of a '%'. Signed-off-by: Mirko Faina <mroik@delayed.space> --- Documentation/git-format-patch.adoc | 4 +++- builtin/log.c | 2 ++ t/t4014-format-patch.sh | 24 ++++++++++++++++++++++++ 3 files changed, 29 insertions(+), 1 deletion(-) diff --git a/Documentation/git-format-patch.adoc b/Documentation/git-format-patch.adoc index 55cc680685..c52dbcc170 100644 --- a/Documentation/git-format-patch.adoc +++ b/Documentation/git-format-patch.adoc @@ -326,8 +326,10 @@ feeding the result to `git send-email`. --commit-list-format=<format-spec>:: Specify the format in which to generate the commit list of the patch series. The accepted values for format-spec are `shortlog`, `modern` or a - format string prefixed with `log:`. + format-string prefixed with `log:`. e.g. `log: %s (%an)` + The user is allowed to drop the prefix if the format-string contains a + `%<placeholder>`. If not given, defaults to the `format.commitListFormat` configuration variable. This option implies the use of `--cover-letter` unless diff --git a/builtin/log.c b/builtin/log.c index c6cf04350a..ad7b7215fe 100644 --- a/builtin/log.c +++ b/builtin/log.c @@ -1448,6 +1448,8 @@ static void make_cover_letter(struct rev_info *rev, int use_separate_file, else if (!strcmp(format, "modern")) generate_commit_list_cover(rev->diffopt.file, "[%(count)/%(total)] %s", list, nr); + else if (strchr(format, '%')) + generate_commit_list_cover(rev->diffopt.file, format, list, nr); else die(_("'%s' is not a valid format string"), format); diff --git a/t/t4014-format-patch.sh b/t/t4014-format-patch.sh index 7571cc582b..7517094bd6 100755 --- a/t/t4014-format-patch.sh +++ b/t/t4014-format-patch.sh @@ -392,6 +392,30 @@ test_expect_success 'cover letter with subject, author and count' ' test_grep "^\[1/1\] This is a subject (A U Thor)$" patches/0000-cover-letter.patch ' +test_expect_success 'cover letter with custom format no prefix' ' + rm -rf patches && + test_when_finished "git reset --hard HEAD~1" && + test_when_finished "rm -rf patches test_file" && + touch test_file && + git add test_file && + git commit -m "This is a subject" && + git format-patch --commit-list-format="[%(count)/%(total)] %s (%an)" \ + -o patches HEAD~1 && + test_grep "^\[1/1\] This is a subject (A U Thor)$" patches/0000-cover-letter.patch +' + +test_expect_success 'cover letter fail when no prefix and no placeholder' ' + rm -rf patches && + test_when_finished "git reset --hard HEAD~1" && + test_when_finished "rm -rf patches test_file err" && + touch test_file && + git add test_file && + git commit -m "This is a subject" && + test_must_fail git format-patch --commit-list-format="this should fail" \ + -o patches HEAD~1 2>err && + test_grep "is not a valid format string" err +' + test_expect_success 'cover letter modern format' ' test_when_finished "git reset --hard HEAD~1" && test_when_finished "rm -rf patches test_file" && -- 2.53.0.959.g497ff81fa9 ^ permalink raw reply related [flat|nested] 42+ messages in thread
* Re: [PATCH 7/7] format-patch: --commit-list-format without prefix 2026-03-14 23:20 ` [PATCH 7/7] format-patch: --commit-list-format without prefix Mirko Faina @ 2026-03-17 15:29 ` Kristoffer Haugsbakk 2026-03-17 16:20 ` Mirko Faina 0 siblings, 1 reply; 42+ messages in thread From: Kristoffer Haugsbakk @ 2026-03-17 15:29 UTC (permalink / raw) To: Mirko Faina, git On Sun, Mar 15, 2026, at 00:20, Mirko Faina wrote: > Having to prefix a custom format-string with "log:" when passed from the > cli interface can be annoying for many users. It would be great if it s/cli interface/CLI/ s/for many users// ? It’s a general assertion. > could be dropped an it were still accepted. s/an/and/ But maybe instead: I would be great if this prefix wasn't required. > > Teach make_cover_letter() to accept custom format-strings if a > placeholder is detected. > > Note that both here and in "git log --format" the check is done naively > by just checking for the presence of a '%'. > > Signed-off-by: Mirko Faina <mroik@delayed.space> > --- >[snip] ^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH 7/7] format-patch: --commit-list-format without prefix 2026-03-17 15:29 ` Kristoffer Haugsbakk @ 2026-03-17 16:20 ` Mirko Faina 0 siblings, 0 replies; 42+ messages in thread From: Mirko Faina @ 2026-03-17 16:20 UTC (permalink / raw) To: Kristoffer Haugsbakk; +Cc: git, Mirko Faina On Tue, Mar 17, 2026 at 04:29:23PM +0100, Kristoffer Haugsbakk wrote: > On Sun, Mar 15, 2026, at 00:20, Mirko Faina wrote: > > Having to prefix a custom format-string with "log:" when passed from the > > cli interface can be annoying for many users. It would be great if it > > s/cli interface/CLI/ > > s/for many users// ? It’s a general assertion. > > > could be dropped an it were still accepted. > > s/an/and/ > > But maybe instead: > > I would be great if this prefix wasn't required. s/I/It/ :P Will do, thank you ^ permalink raw reply [flat|nested] 42+ messages in thread
* [PATCH v2 0/8] improve "git format-patch --commit-list-format" 2026-03-14 23:20 [PATCH 0/7] improve "git format-patch --commit-list-format" Mirko Faina ` (6 preceding siblings ...) 2026-03-14 23:20 ` [PATCH 7/7] format-patch: --commit-list-format without prefix Mirko Faina @ 2026-03-19 22:38 ` Mirko Faina 2026-03-19 22:38 ` [PATCH v2 1/8] pretty.c: better die message %(count) and %(total) Mirko Faina ` (8 more replies) 7 siblings, 9 replies; 42+ messages in thread From: Mirko Faina @ 2026-03-19 22:38 UTC (permalink / raw) To: git; +Cc: Mirko Faina, Kristoffer Haugsbakk I've applied the suggestions that Kristoffer made and added an additional patch that documents %(count) and %(total), but I'm not sure if I've placed them in the right location. It's in the "Placeholders that expand to information extracted from the commit" section despite not being the most accurate, but making a new section just for "Placeholders that expand to information from patch series" didn't seem right. This series is based on top of 67006b9db8 (The 15th batch, 2026-03-12) with the following series merged into it: - mf/format-patch-cover-letter-format at 51ed9f7e72 (docs: add usage for the cover-letter fmt feature, 2026-03-07) [1/8] pretty.c: better die message %(count) and %(total) (Mirko Faina) [2/8] format-patch: refactor generate_commit_list_cover (Mirko Faina) [3/8] format-patch: rename --cover-letter-format option (Mirko Faina) [4/8] docs/pretty-formats: add %(count) and %(total) (Mirko Faina) [5/8] format.commitListFormat: strip meaning from empty (Mirko Faina) [6/8] format-patch: wrap generate_commit_list_cover() (Mirko Faina) [7/8] format-patch: add preset for --commit-list-format (Mirko Faina) [8/8] format-patch: --commit-list-format without prefix (Mirko Faina) Documentation/config/format.adoc | 2 +- Documentation/git-format-patch.adoc | 19 ++++---- Documentation/pretty-formats.adoc | 4 ++ builtin/log.c | 35 +++++++------- pretty.c | 4 +- t/t4014-format-patch.sh | 72 +++++++++++++++++++---------- t/t9902-completion.sh | 1 - 7 files changed, 84 insertions(+), 53 deletions(-) -- 2.53.0.1018.g2bb0e51243 ^ permalink raw reply [flat|nested] 42+ messages in thread
* [PATCH v2 1/8] pretty.c: better die message %(count) and %(total) 2026-03-19 22:38 ` [PATCH v2 0/8] improve "git format-patch --commit-list-format" Mirko Faina @ 2026-03-19 22:38 ` Mirko Faina 2026-03-19 22:38 ` [PATCH v2 2/8] format-patch: refactor generate_commit_list_cover Mirko Faina ` (7 subsequent siblings) 8 siblings, 0 replies; 42+ messages in thread From: Mirko Faina @ 2026-03-19 22:38 UTC (permalink / raw) To: git; +Cc: Mirko Faina, Kristoffer Haugsbakk Improve die messages for commands that do not support %(count) and %(total) Signed-off-by: Mirko Faina <mroik@delayed.space> --- pretty.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pretty.c b/pretty.c index 74673714c8..814803980b 100644 --- a/pretty.c +++ b/pretty.c @@ -1551,7 +1551,7 @@ static size_t format_commit_one(struct strbuf *sb, /* in UTF-8 */ if (starts_with(placeholder, "(count)")) { if (!c->pretty_ctx->rev) - die(_("this format specifier can't be used with this command")); + die(_("%s is not supported by this command"), "%(count)"); strbuf_addf(sb, "%0*d", decimal_width(c->pretty_ctx->rev->total), c->pretty_ctx->rev->nr); return 7; @@ -1559,7 +1559,7 @@ static size_t format_commit_one(struct strbuf *sb, /* in UTF-8 */ if (starts_with(placeholder, "(total)")) { if (!c->pretty_ctx->rev) - die(_("this format specifier can't be used with this command")); + die(_("%s is not supported by this command"), "%(total)"); strbuf_addf(sb, "%d", c->pretty_ctx->rev->total); return 7; } -- 2.53.0.1018.g2bb0e51243 ^ permalink raw reply related [flat|nested] 42+ messages in thread
* [PATCH v2 2/8] format-patch: refactor generate_commit_list_cover 2026-03-19 22:38 ` [PATCH v2 0/8] improve "git format-patch --commit-list-format" Mirko Faina 2026-03-19 22:38 ` [PATCH v2 1/8] pretty.c: better die message %(count) and %(total) Mirko Faina @ 2026-03-19 22:38 ` Mirko Faina 2026-03-19 22:38 ` [PATCH v2 3/8] format-patch: rename --cover-letter-format option Mirko Faina ` (6 subsequent siblings) 8 siblings, 0 replies; 42+ messages in thread From: Mirko Faina @ 2026-03-19 22:38 UTC (permalink / raw) To: git; +Cc: Mirko Faina, Kristoffer Haugsbakk Refactor for readability and remove unnecessary initialization. Signed-off-by: Mirko Faina <mroik@delayed.space> --- builtin/log.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/builtin/log.c b/builtin/log.c index 716ebc2701..997bdd608e 100644 --- a/builtin/log.c +++ b/builtin/log.c @@ -1376,12 +1376,11 @@ static void generate_commit_list_cover(FILE *cover_file, const char *format, struct pretty_print_context ctx = {0}; struct rev_info rev = REV_INFO_INIT; - strbuf_init(&commit_line, 0); rev.total = n; ctx.rev = &rev; - for (int i = n - 1; i >= 0; i--) { - rev.nr = n - i; - repo_format_commit_message(the_repository, list[i], format, + for (int i = 1; i <= n; i++) { + rev.nr = i; + repo_format_commit_message(the_repository, list[n - i], format, &commit_line, &ctx); fprintf(cover_file, "%s\n", commit_line.buf); strbuf_reset(&commit_line); -- 2.53.0.1018.g2bb0e51243 ^ permalink raw reply related [flat|nested] 42+ messages in thread
* [PATCH v2 3/8] format-patch: rename --cover-letter-format option 2026-03-19 22:38 ` [PATCH v2 0/8] improve "git format-patch --commit-list-format" Mirko Faina 2026-03-19 22:38 ` [PATCH v2 1/8] pretty.c: better die message %(count) and %(total) Mirko Faina 2026-03-19 22:38 ` [PATCH v2 2/8] format-patch: refactor generate_commit_list_cover Mirko Faina @ 2026-03-19 22:38 ` Mirko Faina 2026-03-19 22:38 ` [PATCH v2 4/8] docs/pretty-formats: add %(count) and %(total) Mirko Faina ` (5 subsequent siblings) 8 siblings, 0 replies; 42+ messages in thread From: Mirko Faina @ 2026-03-19 22:38 UTC (permalink / raw) To: git; +Cc: Mirko Faina, Kristoffer Haugsbakk To align the name of the configuration variable and the name of the command line option, either one should change name. By changing the name of the option we get the added benefit of having --cover-<TAB> expand to --cover-letter without ambiguity. If the user gives the --cover-letter-format option it would be reasonable to expect that the user wants to generate the cover letter despite not giving --cover-letter. Rename --cover-letter-format to --commit-list-format and make it imply --cover-letter unless --no-cover-letter is given. Signed-off-by: Mirko Faina <mroik@delayed.space> --- Documentation/git-format-patch.adoc | 17 ++++++------ builtin/log.c | 4 ++- t/t4014-format-patch.sh | 41 +++++++++++++++-------------- t/t9902-completion.sh | 1 - 4 files changed, 32 insertions(+), 31 deletions(-) diff --git a/Documentation/git-format-patch.adoc b/Documentation/git-format-patch.adoc index 31fa492335..45ca72e670 100644 --- a/Documentation/git-format-patch.adoc +++ b/Documentation/git-format-patch.adoc @@ -24,7 +24,7 @@ SYNOPSIS [(--reroll-count|-v) <n>] [--to=<email>] [--cc=<email>] [--[no-]cover-letter] [--quiet] - [--cover-letter-format=<format-spec>] + [--commit-list-format=<format-spec>] [--[no-]encode-email-headers] [--no-notes | --notes[=<ref>]] [--interdiff=<previous>] @@ -323,16 +323,15 @@ feeding the result to `git send-email`. containing the branch description, shortlog and the overall diffstat. You can fill in a description in the file before sending it out. ---cover-letter-format=<format-spec>:: - Specify the format in which to generate the commit list of the - patch series. This option is available if the user wants to use - an alternative to the default `shortlog` format. The accepted - values for format-spec are "shortlog" or a format string - prefixed with `log:`. +--commit-list-format=<format-spec>:: + Specify the format in which to generate the commit list of the patch + series. The accepted values for format-spec are "shortlog" or a format + string prefixed with `log:`. e.g. `log: %s (%an)` - If defined, defaults to the `format.commitListFormat` configuration + If not given, defaults to the `format.commitListFormat` configuration variable. - This option is relevant only if a cover letter is generated. + This option implies the use of `--cover-letter` unless + `--no-cover-letter` is given. --encode-email-headers:: --no-encode-email-headers:: diff --git a/builtin/log.c b/builtin/log.c index 997bdd608e..a7f129d583 100644 --- a/builtin/log.c +++ b/builtin/log.c @@ -2014,7 +2014,7 @@ int cmd_format_patch(int argc, N_("print patches to standard out")), OPT_BOOL(0, "cover-letter", &cover_letter, N_("generate a cover letter")), - OPT_STRING(0, "cover-letter-format", &cover_letter_fmt, N_("format-spec"), + OPT_STRING(0, "commit-list-format", &cover_letter_fmt, N_("format-spec"), N_("format spec used for the commit list in the cover letter")), OPT_BOOL(0, "numbered-files", &just_numbers, N_("use simple number sequence for output file names")), @@ -2358,6 +2358,8 @@ int cmd_format_patch(int argc, cover_letter_fmt = cfg.fmt_cover_letter_commit_list; if (!cover_letter_fmt) cover_letter_fmt = "shortlog"; + } else if (cover_letter == -1) { + cover_letter = 1; } if (cover_letter == -1) { diff --git a/t/t4014-format-patch.sh b/t/t4014-format-patch.sh index 7c67bdf922..d2a775f78d 100755 --- a/t/t4014-format-patch.sh +++ b/t/t4014-format-patch.sh @@ -383,49 +383,50 @@ test_expect_success 'filename limit applies only to basename' ' test_expect_success 'cover letter with subject, author and count' ' rm -rf patches && test_when_finished "git reset --hard HEAD~1" && - test_when_finished "rm -rf patches result test_file" && + test_when_finished "rm -rf patches test_file" && touch test_file && git add test_file && git commit -m "This is a subject" && - git format-patch --cover-letter \ - --cover-letter-format="log:[%(count)/%(total)] %s (%an)" -o patches HEAD~1 && - grep "^\[1/1\] This is a subject (A U Thor)$" patches/0000-cover-letter.patch >result && - test_line_count = 1 result + git format-patch --commit-list-format="log:[%(count)/%(total)] %s (%an)" \ + -o patches HEAD~1 && + test_grep "^\[1/1\] This is a subject (A U Thor)$" patches/0000-cover-letter.patch ' -test_expected_success 'cover letter with author and count' ' +test_expect_success 'cover letter with author and count' ' test_when_finished "git reset --hard HEAD~1" && - test_when_finished "rm -rf patches result test_file" && + test_when_finished "rm -rf patches test_file" && touch test_file && git add test_file && git commit -m "This is a subject" && - git format-patch --cover-letter \ - --cover-letter-format="log:[%(count)/%(total)] %an" -o patches HEAD~1 && - grep "^\[1/1\] A U Thor$" patches/0000-cover-letter.patch >result && - test_line_count = 1 result + git format-patch --commit-list-format="log:[%(count)/%(total)] %an" \ + -o patches HEAD~1 && + test_grep "^\[1/1\] A U Thor$" patches/0000-cover-letter.patch ' test_expect_success 'cover letter shortlog' ' test_when_finished "git reset --hard HEAD~1" && - test_when_finished "rm -rf patches result test_file" && + test_when_finished "rm -rf expect patches result test_file" && + cat >expect <<-"EOF" && + A U Thor (1): + This is a subject + EOF touch test_file && git add test_file && git commit -m "This is a subject" && - git format-patch --cover-letter --cover-letter-format=shortlog \ - -o patches HEAD~1 && - sed -n -e "/^A U Thor/p;" patches/0000-cover-letter.patch >result && - test_line_count = 1 result + git format-patch --commit-list-format=shortlog -o patches HEAD~1 && + grep -E -A 1 "^A U Thor \([[:digit:]]+\):$" patches/0000-cover-letter.patch >result && + cat result && + test_cmp expect result ' -test_expect_success 'cover letter no format' ' +test_expect_success 'no cover letter but with format specified' ' test_when_finished "git reset --hard HEAD~1" && test_when_finished "rm -rf patches result test_file" && touch test_file && git add test_file && git commit -m "This is a subject" && - git format-patch --cover-letter -o patches HEAD~1 && - sed -n -e "/^A U Thor/p;" patches/0000-cover-letter.patch >result && - test_line_count = 1 result + git format-patch --no-cover-letter --commit-list-format="[%(count)] %s" -o patches HEAD~1 && + test_path_is_missing patches/0000-cover-letter.patch ' test_expect_success 'cover letter config with count, subject and author' ' diff --git a/t/t9902-completion.sh b/t/t9902-completion.sh index 35e20b5351..2f9a597ec7 100755 --- a/t/t9902-completion.sh +++ b/t/t9902-completion.sh @@ -2775,7 +2775,6 @@ test_expect_success PERL 'send-email' ' test_completion "git send-email --cov" <<-\EOF && --cover-from-description=Z --cover-letter Z - --cover-letter-format=Z EOF test_completion "git send-email --val" <<-\EOF && --validate Z -- 2.53.0.1018.g2bb0e51243 ^ permalink raw reply related [flat|nested] 42+ messages in thread
* [PATCH v2 4/8] docs/pretty-formats: add %(count) and %(total) 2026-03-19 22:38 ` [PATCH v2 0/8] improve "git format-patch --commit-list-format" Mirko Faina ` (2 preceding siblings ...) 2026-03-19 22:38 ` [PATCH v2 3/8] format-patch: rename --cover-letter-format option Mirko Faina @ 2026-03-19 22:38 ` Mirko Faina 2026-03-23 10:29 ` Kristoffer Haugsbakk 2026-03-19 22:38 ` [PATCH v2 5/8] format.commitListFormat: strip meaning from empty Mirko Faina ` (4 subsequent siblings) 8 siblings, 1 reply; 42+ messages in thread From: Mirko Faina @ 2026-03-19 22:38 UTC (permalink / raw) To: git; +Cc: Mirko Faina, Kristoffer Haugsbakk When --commit-list-format has been introduced to format-patch, two new placeholders have been added to the PRETTY FORMATS code without being documented. Do so now. Signed-off-by: Mirko Faina <mroik@delayed.space> --- Documentation/pretty-formats.adoc | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Documentation/pretty-formats.adoc b/Documentation/pretty-formats.adoc index 5405e57a60..67dc0f2a82 100644 --- a/Documentation/pretty-formats.adoc +++ b/Documentation/pretty-formats.adoc @@ -253,6 +253,10 @@ The placeholders are: linkgit:git-rev-list[1]) +%d+:: ref names, like the --decorate option of linkgit:git-log[1] +%D+:: ref names without the " (", ")" wrapping. ++%(count)+:: the number of a patch within a patch series. Used only in + `--commit-list-format` in `format-patch` ++%(total)+:: the number of tatal patches in a patch series. Used only in + `--commit-list-format` in `format-patch` ++%(decorate++`[:<option>,...]`++)++:: ref names with custom decorations. The `decorate` string may be followed by a colon and zero or more comma-separated options. Option values may contain -- 2.53.0.1018.g2bb0e51243 ^ permalink raw reply related [flat|nested] 42+ messages in thread
* Re: [PATCH v2 4/8] docs/pretty-formats: add %(count) and %(total) 2026-03-19 22:38 ` [PATCH v2 4/8] docs/pretty-formats: add %(count) and %(total) Mirko Faina @ 2026-03-23 10:29 ` Kristoffer Haugsbakk 2026-03-23 14:00 ` Mirko Faina 0 siblings, 1 reply; 42+ messages in thread From: Kristoffer Haugsbakk @ 2026-03-23 10:29 UTC (permalink / raw) To: Mirko Faina, git On Thu, Mar 19, 2026, at 23:38, Mirko Faina wrote: > When --commit-list-format has been introduced to format-patch, two new The past tense here is wrong. s/has been/was/ > placeholders have been added to the PRETTY FORMATS code without being s/have been/were/ > documented. Do so now. > > Signed-off-by: Mirko Faina <mroik@delayed.space> > --- > Documentation/pretty-formats.adoc | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/pretty-formats.adoc > b/Documentation/pretty-formats.adoc > index 5405e57a60..67dc0f2a82 100644 > --- a/Documentation/pretty-formats.adoc > +++ b/Documentation/pretty-formats.adoc > @@ -253,6 +253,10 @@ The placeholders are: > linkgit:git-rev-list[1]) > +%d+:: ref names, like the --decorate option of linkgit:git-log[1] > +%D+:: ref names without the " (", ")" wrapping. > ++%(count)+:: the number of a patch within a patch series. Used only in > + `--commit-list-format` in `format-patch` > ++%(total)+:: the number of tatal patches in a patch series. Used only s/the number of tatal patches/the total number of patches/ ? > in > + `--commit-list-format` in `format-patch` > ++%(decorate++`[:<option>,...]`++)++:: > ref names with custom decorations. The `decorate` string may be > followed by a > colon and zero or more comma-separated options. Option values may > contain > -- > 2.53.0.1018.g2bb0e51243 ^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH v2 4/8] docs/pretty-formats: add %(count) and %(total) 2026-03-23 10:29 ` Kristoffer Haugsbakk @ 2026-03-23 14:00 ` Mirko Faina 0 siblings, 0 replies; 42+ messages in thread From: Mirko Faina @ 2026-03-23 14:00 UTC (permalink / raw) To: Kristoffer Haugsbakk; +Cc: git, Mirko Faina On Mon, Mar 23, 2026 at 11:29:21AM +0100, Kristoffer Haugsbakk wrote: > On Thu, Mar 19, 2026, at 23:38, Mirko Faina wrote: > > When --commit-list-format has been introduced to format-patch, two new > > The past tense here is wrong. > > s/has been/was/ > > > placeholders have been added to the PRETTY FORMATS code without being > > s/have been/were/ Will fix. > > documented. Do so now. > > > > Signed-off-by: Mirko Faina <mroik@delayed.space> > > --- > > Documentation/pretty-formats.adoc | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/Documentation/pretty-formats.adoc > > b/Documentation/pretty-formats.adoc > > index 5405e57a60..67dc0f2a82 100644 > > --- a/Documentation/pretty-formats.adoc > > +++ b/Documentation/pretty-formats.adoc > > @@ -253,6 +253,10 @@ The placeholders are: > > linkgit:git-rev-list[1]) > > +%d+:: ref names, like the --decorate option of linkgit:git-log[1] > > +%D+:: ref names without the " (", ")" wrapping. > > ++%(count)+:: the number of a patch within a patch series. Used only in > > + `--commit-list-format` in `format-patch` > > ++%(total)+:: the number of tatal patches in a patch series. Used only > > s/the number of tatal patches/the total number of patches/ ? Will fix. Thank you for the review ^ permalink raw reply [flat|nested] 42+ messages in thread
* [PATCH v2 5/8] format.commitListFormat: strip meaning from empty 2026-03-19 22:38 ` [PATCH v2 0/8] improve "git format-patch --commit-list-format" Mirko Faina ` (3 preceding siblings ...) 2026-03-19 22:38 ` [PATCH v2 4/8] docs/pretty-formats: add %(count) and %(total) Mirko Faina @ 2026-03-19 22:38 ` Mirko Faina 2026-03-19 22:38 ` [PATCH v2 6/8] format-patch: wrap generate_commit_list_cover() Mirko Faina ` (3 subsequent siblings) 8 siblings, 0 replies; 42+ messages in thread From: Mirko Faina @ 2026-03-19 22:38 UTC (permalink / raw) To: git; +Cc: Mirko Faina, Kristoffer Haugsbakk The configuration variable format.commitListFormat allows for an empty value. This is unusual and can create issues when interacting with this configuration variable through the cli interface. Strip meaning to format.commitListFormat with an empty value. Signed-off-by: Mirko Faina <mroik@delayed.space> --- builtin/log.c | 11 +---------- t/t4014-format-patch.sh | 11 ----------- 2 files changed, 1 insertion(+), 21 deletions(-) diff --git a/builtin/log.c b/builtin/log.c index a7f129d583..47126f9064 100644 --- a/builtin/log.c +++ b/builtin/log.c @@ -1055,17 +1055,8 @@ static int git_format_config(const char *var, const char *value, return 0; } if (!strcmp(var, "format.commitlistformat")) { - struct strbuf tmp = STRBUF_INIT; - strbuf_init(&tmp, 0); - if (value) - strbuf_addstr(&tmp, value); - else - strbuf_addstr(&tmp, "log:[%(count)/%(total)] %s"); - FREE_AND_NULL(cfg->fmt_cover_letter_commit_list); - git_config_string(&cfg->fmt_cover_letter_commit_list, var, tmp.buf); - strbuf_release(&tmp); - return 0; + return git_config_string(&cfg->fmt_cover_letter_commit_list, var, value); } if (!strcmp(var, "format.outputdirectory")) { FREE_AND_NULL(cfg->config_output_directory); diff --git a/t/t4014-format-patch.sh b/t/t4014-format-patch.sh index d2a775f78d..ca37f40a6a 100755 --- a/t/t4014-format-patch.sh +++ b/t/t4014-format-patch.sh @@ -451,17 +451,6 @@ test_expect_success 'cover letter config with count and author' ' test_line_count = 2 result ' -test_expect_success 'cover letter config commitlistformat set but no format' ' - test_when_finished "rm -rf patches result" && - test_when_finished "git config unset format.coverletter" && - test_when_finished "git config unset format.commitlistformat" && - git config set format.coverletter true && - printf "\tcommitlistformat" >> .git/config && - git format-patch -o patches HEAD~2 && - grep -E "^[[[:digit:]]+/[[:digit:]]+] .*" patches/0000-cover-letter.patch >result && - test_line_count = 2 result -' - test_expect_success 'cover letter config commitlistformat set to shortlog' ' test_when_finished "rm -rf patches result" && test_when_finished "git config unset format.coverletter" && -- 2.53.0.1018.g2bb0e51243 ^ permalink raw reply related [flat|nested] 42+ messages in thread
* [PATCH v2 6/8] format-patch: wrap generate_commit_list_cover() 2026-03-19 22:38 ` [PATCH v2 0/8] improve "git format-patch --commit-list-format" Mirko Faina ` (4 preceding siblings ...) 2026-03-19 22:38 ` [PATCH v2 5/8] format.commitListFormat: strip meaning from empty Mirko Faina @ 2026-03-19 22:38 ` Mirko Faina 2026-03-19 22:38 ` [PATCH v2 7/8] format-patch: add preset for --commit-list-format Mirko Faina ` (2 subsequent siblings) 8 siblings, 0 replies; 42+ messages in thread From: Mirko Faina @ 2026-03-19 22:38 UTC (permalink / raw) To: git; +Cc: Mirko Faina, Kristoffer Haugsbakk While most conventions should not allow for the text lines in commit messages to get too long, when they do it could make emails harder to read. Teach generate_commit_list_cover() to wrap its commit lines if they are too long. Signed-off-by: Mirko Faina <mroik@delayed.space> --- builtin/log.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/builtin/log.c b/builtin/log.c index 47126f9064..d1765ce4ad 100644 --- a/builtin/log.c +++ b/builtin/log.c @@ -40,6 +40,7 @@ #include "progress.h" #include "commit-slab.h" #include "advice.h" +#include "utf8.h" #include "commit-reach.h" #include "range-diff.h" @@ -1364,6 +1365,7 @@ static void generate_commit_list_cover(FILE *cover_file, const char *format, struct commit **list, int n) { struct strbuf commit_line = STRBUF_INIT; + struct strbuf wrapped_line = STRBUF_INIT; struct pretty_print_context ctx = {0}; struct rev_info rev = REV_INFO_INIT; @@ -1373,12 +1375,16 @@ static void generate_commit_list_cover(FILE *cover_file, const char *format, rev.nr = i; repo_format_commit_message(the_repository, list[n - i], format, &commit_line, &ctx); - fprintf(cover_file, "%s\n", commit_line.buf); + strbuf_add_wrapped_text(&wrapped_line, commit_line.buf, 0, 0, + MAIL_DEFAULT_WRAP); + fprintf(cover_file, "%s\n", wrapped_line.buf); strbuf_reset(&commit_line); + strbuf_reset(&wrapped_line); } fprintf(cover_file, "\n"); strbuf_release(&commit_line); + strbuf_release(&wrapped_line); } static void make_cover_letter(struct rev_info *rev, int use_separate_file, -- 2.53.0.1018.g2bb0e51243 ^ permalink raw reply related [flat|nested] 42+ messages in thread
* [PATCH v2 7/8] format-patch: add preset for --commit-list-format 2026-03-19 22:38 ` [PATCH v2 0/8] improve "git format-patch --commit-list-format" Mirko Faina ` (5 preceding siblings ...) 2026-03-19 22:38 ` [PATCH v2 6/8] format-patch: wrap generate_commit_list_cover() Mirko Faina @ 2026-03-19 22:38 ` Mirko Faina 2026-03-19 22:38 ` [PATCH v2 8/8] format-patch: --commit-list-format without prefix Mirko Faina 2026-03-23 16:57 ` [PATCH v3 0/8] improve "git format-patch --commit-list-format" Mirko Faina 8 siblings, 0 replies; 42+ messages in thread From: Mirko Faina @ 2026-03-19 22:38 UTC (permalink / raw) To: git; +Cc: Mirko Faina, Kristoffer Haugsbakk "git format-patch --commit-list-format" enables the user to make their own format for the commit list in the cover letter. It would be nice to have a ready to use format to replace shortlog. Teach make_cover_letter() the "modern" format preset. This new format is the same as: "log:[%(count)/%(total)] %s". Signed-off-by: Mirko Faina <mroik@delayed.space> --- Documentation/config/format.adoc | 2 +- Documentation/git-format-patch.adoc | 4 ++-- builtin/log.c | 3 +++ t/t4014-format-patch.sh | 20 +++++++++++++++----- 4 files changed, 21 insertions(+), 8 deletions(-) diff --git a/Documentation/config/format.adoc b/Documentation/config/format.adoc index ea5ec5df7a..ef1ed1d250 100644 --- a/Documentation/config/format.adoc +++ b/Documentation/config/format.adoc @@ -104,7 +104,7 @@ format.coverLetter:: format.commitListFormat:: When the `--cover-letter-format` option is not given, `format-patch` uses the value of this variable to decide how to format the title of - each commit. Default to `shortlog`. + each commit. Defaults to `shortlog`. format.outputDirectory:: Set a custom directory to store the resulting files instead of the diff --git a/Documentation/git-format-patch.adoc b/Documentation/git-format-patch.adoc index 45ca72e670..55cc680685 100644 --- a/Documentation/git-format-patch.adoc +++ b/Documentation/git-format-patch.adoc @@ -325,8 +325,8 @@ feeding the result to `git send-email`. --commit-list-format=<format-spec>:: Specify the format in which to generate the commit list of the patch - series. The accepted values for format-spec are "shortlog" or a format - string prefixed with `log:`. + series. The accepted values for format-spec are `shortlog`, `modern` or a + format string prefixed with `log:`. e.g. `log: %s (%an)` If not given, defaults to the `format.commitListFormat` configuration variable. diff --git a/builtin/log.c b/builtin/log.c index d1765ce4ad..c6cf04350a 100644 --- a/builtin/log.c +++ b/builtin/log.c @@ -1445,6 +1445,9 @@ static void make_cover_letter(struct rev_info *rev, int use_separate_file, generate_commit_list_cover(rev->diffopt.file, format, list, nr); else if (!strcmp(format, "shortlog")) generate_shortlog_cover_letter(&log, rev, list, nr); + else if (!strcmp(format, "modern")) + generate_commit_list_cover(rev->diffopt.file, "[%(count)/%(total)] %s", + list, nr); else die(_("'%s' is not a valid format string"), format); diff --git a/t/t4014-format-patch.sh b/t/t4014-format-patch.sh index ca37f40a6a..7571cc582b 100755 --- a/t/t4014-format-patch.sh +++ b/t/t4014-format-patch.sh @@ -392,18 +392,17 @@ test_expect_success 'cover letter with subject, author and count' ' test_grep "^\[1/1\] This is a subject (A U Thor)$" patches/0000-cover-letter.patch ' -test_expect_success 'cover letter with author and count' ' +test_expect_success 'cover letter modern format' ' test_when_finished "git reset --hard HEAD~1" && test_when_finished "rm -rf patches test_file" && touch test_file && git add test_file && git commit -m "This is a subject" && - git format-patch --commit-list-format="log:[%(count)/%(total)] %an" \ - -o patches HEAD~1 && - test_grep "^\[1/1\] A U Thor$" patches/0000-cover-letter.patch + git format-patch --commit-list-format="modern" -o patches HEAD~1 && + test_grep "^\[1/1\] This is a subject$" patches/0000-cover-letter.patch ' -test_expect_success 'cover letter shortlog' ' +test_expect_success 'cover letter shortlog format' ' test_when_finished "git reset --hard HEAD~1" && test_when_finished "rm -rf expect patches result test_file" && cat >expect <<-"EOF" && @@ -451,6 +450,17 @@ test_expect_success 'cover letter config with count and author' ' test_line_count = 2 result ' +test_expect_success 'cover letter config commitlistformat set to modern' ' + test_when_finished "rm -rf patches result" && + test_when_finished "git config unset format.coverletter" && + test_when_finished "git config unset format.commitlistformat" && + git config set format.coverletter true && + git config set format.commitlistformat modern && + git format-patch -o patches HEAD~2 && + grep -E "^[[[:digit:]]+/[[:digit:]]+] .*$" patches/0000-cover-letter.patch >result && + test_line_count = 2 result +' + test_expect_success 'cover letter config commitlistformat set to shortlog' ' test_when_finished "rm -rf patches result" && test_when_finished "git config unset format.coverletter" && -- 2.53.0.1018.g2bb0e51243 ^ permalink raw reply related [flat|nested] 42+ messages in thread
* [PATCH v2 8/8] format-patch: --commit-list-format without prefix 2026-03-19 22:38 ` [PATCH v2 0/8] improve "git format-patch --commit-list-format" Mirko Faina ` (6 preceding siblings ...) 2026-03-19 22:38 ` [PATCH v2 7/8] format-patch: add preset for --commit-list-format Mirko Faina @ 2026-03-19 22:38 ` Mirko Faina 2026-03-23 16:57 ` [PATCH v3 0/8] improve "git format-patch --commit-list-format" Mirko Faina 8 siblings, 0 replies; 42+ messages in thread From: Mirko Faina @ 2026-03-19 22:38 UTC (permalink / raw) To: git; +Cc: Mirko Faina, Kristoffer Haugsbakk Having to prefix a custom format-string with "log:" when passed from the CLI can be annoying. It would be great if this prefix wasn't required. Teach make_cover_letter() to accept custom format-strings without the "log:" prefix if a placeholder is detected. Note that both here and in "git log --format" the check is done naively by just checking for the presence of a '%'. Signed-off-by: Mirko Faina <mroik@delayed.space> --- Documentation/git-format-patch.adoc | 4 +++- builtin/log.c | 2 ++ t/t4014-format-patch.sh | 24 ++++++++++++++++++++++++ 3 files changed, 29 insertions(+), 1 deletion(-) diff --git a/Documentation/git-format-patch.adoc b/Documentation/git-format-patch.adoc index 55cc680685..c52dbcc170 100644 --- a/Documentation/git-format-patch.adoc +++ b/Documentation/git-format-patch.adoc @@ -326,8 +326,10 @@ feeding the result to `git send-email`. --commit-list-format=<format-spec>:: Specify the format in which to generate the commit list of the patch series. The accepted values for format-spec are `shortlog`, `modern` or a - format string prefixed with `log:`. + format-string prefixed with `log:`. e.g. `log: %s (%an)` + The user is allowed to drop the prefix if the format-string contains a + `%<placeholder>`. If not given, defaults to the `format.commitListFormat` configuration variable. This option implies the use of `--cover-letter` unless diff --git a/builtin/log.c b/builtin/log.c index c6cf04350a..ad7b7215fe 100644 --- a/builtin/log.c +++ b/builtin/log.c @@ -1448,6 +1448,8 @@ static void make_cover_letter(struct rev_info *rev, int use_separate_file, else if (!strcmp(format, "modern")) generate_commit_list_cover(rev->diffopt.file, "[%(count)/%(total)] %s", list, nr); + else if (strchr(format, '%')) + generate_commit_list_cover(rev->diffopt.file, format, list, nr); else die(_("'%s' is not a valid format string"), format); diff --git a/t/t4014-format-patch.sh b/t/t4014-format-patch.sh index 7571cc582b..7517094bd6 100755 --- a/t/t4014-format-patch.sh +++ b/t/t4014-format-patch.sh @@ -392,6 +392,30 @@ test_expect_success 'cover letter with subject, author and count' ' test_grep "^\[1/1\] This is a subject (A U Thor)$" patches/0000-cover-letter.patch ' +test_expect_success 'cover letter with custom format no prefix' ' + rm -rf patches && + test_when_finished "git reset --hard HEAD~1" && + test_when_finished "rm -rf patches test_file" && + touch test_file && + git add test_file && + git commit -m "This is a subject" && + git format-patch --commit-list-format="[%(count)/%(total)] %s (%an)" \ + -o patches HEAD~1 && + test_grep "^\[1/1\] This is a subject (A U Thor)$" patches/0000-cover-letter.patch +' + +test_expect_success 'cover letter fail when no prefix and no placeholder' ' + rm -rf patches && + test_when_finished "git reset --hard HEAD~1" && + test_when_finished "rm -rf patches test_file err" && + touch test_file && + git add test_file && + git commit -m "This is a subject" && + test_must_fail git format-patch --commit-list-format="this should fail" \ + -o patches HEAD~1 2>err && + test_grep "is not a valid format string" err +' + test_expect_success 'cover letter modern format' ' test_when_finished "git reset --hard HEAD~1" && test_when_finished "rm -rf patches test_file" && -- 2.53.0.1018.g2bb0e51243 ^ permalink raw reply related [flat|nested] 42+ messages in thread
* [PATCH v3 0/8] improve "git format-patch --commit-list-format" 2026-03-19 22:38 ` [PATCH v2 0/8] improve "git format-patch --commit-list-format" Mirko Faina ` (7 preceding siblings ...) 2026-03-19 22:38 ` [PATCH v2 8/8] format-patch: --commit-list-format without prefix Mirko Faina @ 2026-03-23 16:57 ` Mirko Faina 2026-03-23 16:57 ` [PATCH v3 1/8] pretty.c: better die message %(count) and %(total) Mirko Faina ` (9 more replies) 8 siblings, 10 replies; 42+ messages in thread From: Mirko Faina @ 2026-03-23 16:57 UTC (permalink / raw) To: git; +Cc: Mirko Faina, Kristoffer Haugsbakk Not much has changed, just applied the suggestions Kristoffer made. Thank you again for the review [1/8] pretty.c: better die message %(count) and %(total) (Mirko Faina) [2/8] format-patch: refactor generate_commit_list_cover (Mirko Faina) [3/8] format-patch: rename --cover-letter-format option (Mirko Faina) [4/8] docs/pretty-formats: add %(count) and %(total) (Mirko Faina) [5/8] format.commitListFormat: strip meaning from empty (Mirko Faina) [6/8] format-patch: wrap generate_commit_list_cover() (Mirko Faina) [7/8] format-patch: add preset for --commit-list-format (Mirko Faina) [8/8] format-patch: --commit-list-format without prefix (Mirko Faina) Documentation/config/format.adoc | 2 +- Documentation/git-format-patch.adoc | 19 ++++---- Documentation/pretty-formats.adoc | 4 ++ builtin/log.c | 35 +++++++------- pretty.c | 4 +- t/t4014-format-patch.sh | 72 +++++++++++++++++++---------- t/t9902-completion.sh | 1 - 7 files changed, 84 insertions(+), 53 deletions(-) Range-diff against v2: 1: a0d26c5999 = 1: a0d26c5999 pretty.c: better die message %(count) and %(total) 2: 883dd358b6 = 2: 883dd358b6 format-patch: refactor generate_commit_list_cover 3: 5d061d6398 = 3: 5d061d6398 format-patch: rename --cover-letter-format option 4: 7b1e5cbb24 ! 4: ce7d1bd1fe docs/pretty-formats: add %(count) and %(total) @@ Metadata ## Commit message ## docs/pretty-formats: add %(count) and %(total) - When --commit-list-format has been introduced to format-patch, two new - placeholders have been added to the PRETTY FORMATS code without being + When --commit-list-format was introduced to format-patch, two new + placeholders were added to the PRETTY FORMATS code without being documented. Do so now. Signed-off-by: Mirko Faina <mroik@delayed.space> @@ Documentation/pretty-formats.adoc: The placeholders are: +%D+:: ref names without the " (", ")" wrapping. ++%(count)+:: the number of a patch within a patch series. Used only in + `--commit-list-format` in `format-patch` -++%(total)+:: the number of tatal patches in a patch series. Used only in +++%(total)+:: the total number of patches in a patch series. Used only in + `--commit-list-format` in `format-patch` ++%(decorate++`[:<option>,...]`++)++:: ref names with custom decorations. The `decorate` string may be followed by a 5: 3cb0a0a088 ! 5: 66d30249bb format.commitListFormat: strip meaning from empty @@ Commit message The configuration variable format.commitListFormat allows for an empty value. This is unusual and can create issues when interacting with this - configuration variable through the cli interface. + configuration variable through the CLI. Strip meaning to format.commitListFormat with an empty value. 6: 3f547451a2 = 6: c722fc9d0f format-patch: wrap generate_commit_list_cover() 7: fdcb68e650 = 7: bdd8f1fb57 format-patch: add preset for --commit-list-format 8: ef0d3ed876 = 8: d125458e33 format-patch: --commit-list-format without prefix -- 2.53.0.1118.gaef5881109 ^ permalink raw reply [flat|nested] 42+ messages in thread
* [PATCH v3 1/8] pretty.c: better die message %(count) and %(total) 2026-03-23 16:57 ` [PATCH v3 0/8] improve "git format-patch --commit-list-format" Mirko Faina @ 2026-03-23 16:57 ` Mirko Faina 2026-03-23 16:57 ` [PATCH v3 2/8] format-patch: refactor generate_commit_list_cover Mirko Faina ` (8 subsequent siblings) 9 siblings, 0 replies; 42+ messages in thread From: Mirko Faina @ 2026-03-23 16:57 UTC (permalink / raw) To: git; +Cc: Mirko Faina, Kristoffer Haugsbakk Improve die messages for commands that do not support %(count) and %(total) Signed-off-by: Mirko Faina <mroik@delayed.space> --- pretty.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pretty.c b/pretty.c index 74673714c8..814803980b 100644 --- a/pretty.c +++ b/pretty.c @@ -1551,7 +1551,7 @@ static size_t format_commit_one(struct strbuf *sb, /* in UTF-8 */ if (starts_with(placeholder, "(count)")) { if (!c->pretty_ctx->rev) - die(_("this format specifier can't be used with this command")); + die(_("%s is not supported by this command"), "%(count)"); strbuf_addf(sb, "%0*d", decimal_width(c->pretty_ctx->rev->total), c->pretty_ctx->rev->nr); return 7; @@ -1559,7 +1559,7 @@ static size_t format_commit_one(struct strbuf *sb, /* in UTF-8 */ if (starts_with(placeholder, "(total)")) { if (!c->pretty_ctx->rev) - die(_("this format specifier can't be used with this command")); + die(_("%s is not supported by this command"), "%(total)"); strbuf_addf(sb, "%d", c->pretty_ctx->rev->total); return 7; } -- 2.53.0.1118.gaef5881109 ^ permalink raw reply related [flat|nested] 42+ messages in thread
* [PATCH v3 2/8] format-patch: refactor generate_commit_list_cover 2026-03-23 16:57 ` [PATCH v3 0/8] improve "git format-patch --commit-list-format" Mirko Faina 2026-03-23 16:57 ` [PATCH v3 1/8] pretty.c: better die message %(count) and %(total) Mirko Faina @ 2026-03-23 16:57 ` Mirko Faina 2026-03-23 16:57 ` [PATCH v3 3/8] format-patch: rename --cover-letter-format option Mirko Faina ` (7 subsequent siblings) 9 siblings, 0 replies; 42+ messages in thread From: Mirko Faina @ 2026-03-23 16:57 UTC (permalink / raw) To: git; +Cc: Mirko Faina, Kristoffer Haugsbakk Refactor for readability and remove unnecessary initialization. Signed-off-by: Mirko Faina <mroik@delayed.space> --- builtin/log.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/builtin/log.c b/builtin/log.c index 716ebc2701..997bdd608e 100644 --- a/builtin/log.c +++ b/builtin/log.c @@ -1376,12 +1376,11 @@ static void generate_commit_list_cover(FILE *cover_file, const char *format, struct pretty_print_context ctx = {0}; struct rev_info rev = REV_INFO_INIT; - strbuf_init(&commit_line, 0); rev.total = n; ctx.rev = &rev; - for (int i = n - 1; i >= 0; i--) { - rev.nr = n - i; - repo_format_commit_message(the_repository, list[i], format, + for (int i = 1; i <= n; i++) { + rev.nr = i; + repo_format_commit_message(the_repository, list[n - i], format, &commit_line, &ctx); fprintf(cover_file, "%s\n", commit_line.buf); strbuf_reset(&commit_line); -- 2.53.0.1118.gaef5881109 ^ permalink raw reply related [flat|nested] 42+ messages in thread
* [PATCH v3 3/8] format-patch: rename --cover-letter-format option 2026-03-23 16:57 ` [PATCH v3 0/8] improve "git format-patch --commit-list-format" Mirko Faina 2026-03-23 16:57 ` [PATCH v3 1/8] pretty.c: better die message %(count) and %(total) Mirko Faina 2026-03-23 16:57 ` [PATCH v3 2/8] format-patch: refactor generate_commit_list_cover Mirko Faina @ 2026-03-23 16:57 ` Mirko Faina 2026-03-23 16:57 ` [PATCH v3 4/8] docs/pretty-formats: add %(count) and %(total) Mirko Faina ` (6 subsequent siblings) 9 siblings, 0 replies; 42+ messages in thread From: Mirko Faina @ 2026-03-23 16:57 UTC (permalink / raw) To: git; +Cc: Mirko Faina, Kristoffer Haugsbakk To align the name of the configuration variable and the name of the command line option, either one should change name. By changing the name of the option we get the added benefit of having --cover-<TAB> expand to --cover-letter without ambiguity. If the user gives the --cover-letter-format option it would be reasonable to expect that the user wants to generate the cover letter despite not giving --cover-letter. Rename --cover-letter-format to --commit-list-format and make it imply --cover-letter unless --no-cover-letter is given. Signed-off-by: Mirko Faina <mroik@delayed.space> --- Documentation/git-format-patch.adoc | 17 ++++++------ builtin/log.c | 4 ++- t/t4014-format-patch.sh | 41 +++++++++++++++-------------- t/t9902-completion.sh | 1 - 4 files changed, 32 insertions(+), 31 deletions(-) diff --git a/Documentation/git-format-patch.adoc b/Documentation/git-format-patch.adoc index 31fa492335..45ca72e670 100644 --- a/Documentation/git-format-patch.adoc +++ b/Documentation/git-format-patch.adoc @@ -24,7 +24,7 @@ SYNOPSIS [(--reroll-count|-v) <n>] [--to=<email>] [--cc=<email>] [--[no-]cover-letter] [--quiet] - [--cover-letter-format=<format-spec>] + [--commit-list-format=<format-spec>] [--[no-]encode-email-headers] [--no-notes | --notes[=<ref>]] [--interdiff=<previous>] @@ -323,16 +323,15 @@ feeding the result to `git send-email`. containing the branch description, shortlog and the overall diffstat. You can fill in a description in the file before sending it out. ---cover-letter-format=<format-spec>:: - Specify the format in which to generate the commit list of the - patch series. This option is available if the user wants to use - an alternative to the default `shortlog` format. The accepted - values for format-spec are "shortlog" or a format string - prefixed with `log:`. +--commit-list-format=<format-spec>:: + Specify the format in which to generate the commit list of the patch + series. The accepted values for format-spec are "shortlog" or a format + string prefixed with `log:`. e.g. `log: %s (%an)` - If defined, defaults to the `format.commitListFormat` configuration + If not given, defaults to the `format.commitListFormat` configuration variable. - This option is relevant only if a cover letter is generated. + This option implies the use of `--cover-letter` unless + `--no-cover-letter` is given. --encode-email-headers:: --no-encode-email-headers:: diff --git a/builtin/log.c b/builtin/log.c index 997bdd608e..a7f129d583 100644 --- a/builtin/log.c +++ b/builtin/log.c @@ -2014,7 +2014,7 @@ int cmd_format_patch(int argc, N_("print patches to standard out")), OPT_BOOL(0, "cover-letter", &cover_letter, N_("generate a cover letter")), - OPT_STRING(0, "cover-letter-format", &cover_letter_fmt, N_("format-spec"), + OPT_STRING(0, "commit-list-format", &cover_letter_fmt, N_("format-spec"), N_("format spec used for the commit list in the cover letter")), OPT_BOOL(0, "numbered-files", &just_numbers, N_("use simple number sequence for output file names")), @@ -2358,6 +2358,8 @@ int cmd_format_patch(int argc, cover_letter_fmt = cfg.fmt_cover_letter_commit_list; if (!cover_letter_fmt) cover_letter_fmt = "shortlog"; + } else if (cover_letter == -1) { + cover_letter = 1; } if (cover_letter == -1) { diff --git a/t/t4014-format-patch.sh b/t/t4014-format-patch.sh index 7c67bdf922..d2a775f78d 100755 --- a/t/t4014-format-patch.sh +++ b/t/t4014-format-patch.sh @@ -383,49 +383,50 @@ test_expect_success 'filename limit applies only to basename' ' test_expect_success 'cover letter with subject, author and count' ' rm -rf patches && test_when_finished "git reset --hard HEAD~1" && - test_when_finished "rm -rf patches result test_file" && + test_when_finished "rm -rf patches test_file" && touch test_file && git add test_file && git commit -m "This is a subject" && - git format-patch --cover-letter \ - --cover-letter-format="log:[%(count)/%(total)] %s (%an)" -o patches HEAD~1 && - grep "^\[1/1\] This is a subject (A U Thor)$" patches/0000-cover-letter.patch >result && - test_line_count = 1 result + git format-patch --commit-list-format="log:[%(count)/%(total)] %s (%an)" \ + -o patches HEAD~1 && + test_grep "^\[1/1\] This is a subject (A U Thor)$" patches/0000-cover-letter.patch ' -test_expected_success 'cover letter with author and count' ' +test_expect_success 'cover letter with author and count' ' test_when_finished "git reset --hard HEAD~1" && - test_when_finished "rm -rf patches result test_file" && + test_when_finished "rm -rf patches test_file" && touch test_file && git add test_file && git commit -m "This is a subject" && - git format-patch --cover-letter \ - --cover-letter-format="log:[%(count)/%(total)] %an" -o patches HEAD~1 && - grep "^\[1/1\] A U Thor$" patches/0000-cover-letter.patch >result && - test_line_count = 1 result + git format-patch --commit-list-format="log:[%(count)/%(total)] %an" \ + -o patches HEAD~1 && + test_grep "^\[1/1\] A U Thor$" patches/0000-cover-letter.patch ' test_expect_success 'cover letter shortlog' ' test_when_finished "git reset --hard HEAD~1" && - test_when_finished "rm -rf patches result test_file" && + test_when_finished "rm -rf expect patches result test_file" && + cat >expect <<-"EOF" && + A U Thor (1): + This is a subject + EOF touch test_file && git add test_file && git commit -m "This is a subject" && - git format-patch --cover-letter --cover-letter-format=shortlog \ - -o patches HEAD~1 && - sed -n -e "/^A U Thor/p;" patches/0000-cover-letter.patch >result && - test_line_count = 1 result + git format-patch --commit-list-format=shortlog -o patches HEAD~1 && + grep -E -A 1 "^A U Thor \([[:digit:]]+\):$" patches/0000-cover-letter.patch >result && + cat result && + test_cmp expect result ' -test_expect_success 'cover letter no format' ' +test_expect_success 'no cover letter but with format specified' ' test_when_finished "git reset --hard HEAD~1" && test_when_finished "rm -rf patches result test_file" && touch test_file && git add test_file && git commit -m "This is a subject" && - git format-patch --cover-letter -o patches HEAD~1 && - sed -n -e "/^A U Thor/p;" patches/0000-cover-letter.patch >result && - test_line_count = 1 result + git format-patch --no-cover-letter --commit-list-format="[%(count)] %s" -o patches HEAD~1 && + test_path_is_missing patches/0000-cover-letter.patch ' test_expect_success 'cover letter config with count, subject and author' ' diff --git a/t/t9902-completion.sh b/t/t9902-completion.sh index 35e20b5351..2f9a597ec7 100755 --- a/t/t9902-completion.sh +++ b/t/t9902-completion.sh @@ -2775,7 +2775,6 @@ test_expect_success PERL 'send-email' ' test_completion "git send-email --cov" <<-\EOF && --cover-from-description=Z --cover-letter Z - --cover-letter-format=Z EOF test_completion "git send-email --val" <<-\EOF && --validate Z -- 2.53.0.1118.gaef5881109 ^ permalink raw reply related [flat|nested] 42+ messages in thread
* [PATCH v3 4/8] docs/pretty-formats: add %(count) and %(total) 2026-03-23 16:57 ` [PATCH v3 0/8] improve "git format-patch --commit-list-format" Mirko Faina ` (2 preceding siblings ...) 2026-03-23 16:57 ` [PATCH v3 3/8] format-patch: rename --cover-letter-format option Mirko Faina @ 2026-03-23 16:57 ` Mirko Faina 2026-03-23 16:57 ` [PATCH v3 5/8] format.commitListFormat: strip meaning from empty Mirko Faina ` (5 subsequent siblings) 9 siblings, 0 replies; 42+ messages in thread From: Mirko Faina @ 2026-03-23 16:57 UTC (permalink / raw) To: git; +Cc: Mirko Faina, Kristoffer Haugsbakk When --commit-list-format was introduced to format-patch, two new placeholders were added to the PRETTY FORMATS code without being documented. Do so now. Signed-off-by: Mirko Faina <mroik@delayed.space> --- Documentation/pretty-formats.adoc | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Documentation/pretty-formats.adoc b/Documentation/pretty-formats.adoc index 5405e57a60..2ae0eb11a9 100644 --- a/Documentation/pretty-formats.adoc +++ b/Documentation/pretty-formats.adoc @@ -253,6 +253,10 @@ The placeholders are: linkgit:git-rev-list[1]) +%d+:: ref names, like the --decorate option of linkgit:git-log[1] +%D+:: ref names without the " (", ")" wrapping. ++%(count)+:: the number of a patch within a patch series. Used only in + `--commit-list-format` in `format-patch` ++%(total)+:: the total number of patches in a patch series. Used only in + `--commit-list-format` in `format-patch` ++%(decorate++`[:<option>,...]`++)++:: ref names with custom decorations. The `decorate` string may be followed by a colon and zero or more comma-separated options. Option values may contain -- 2.53.0.1118.gaef5881109 ^ permalink raw reply related [flat|nested] 42+ messages in thread
* [PATCH v3 5/8] format.commitListFormat: strip meaning from empty 2026-03-23 16:57 ` [PATCH v3 0/8] improve "git format-patch --commit-list-format" Mirko Faina ` (3 preceding siblings ...) 2026-03-23 16:57 ` [PATCH v3 4/8] docs/pretty-formats: add %(count) and %(total) Mirko Faina @ 2026-03-23 16:57 ` Mirko Faina 2026-03-23 16:57 ` [PATCH v3 6/8] format-patch: wrap generate_commit_list_cover() Mirko Faina ` (4 subsequent siblings) 9 siblings, 0 replies; 42+ messages in thread From: Mirko Faina @ 2026-03-23 16:57 UTC (permalink / raw) To: git; +Cc: Mirko Faina, Kristoffer Haugsbakk The configuration variable format.commitListFormat allows for an empty value. This is unusual and can create issues when interacting with this configuration variable through the CLI. Strip meaning to format.commitListFormat with an empty value. Signed-off-by: Mirko Faina <mroik@delayed.space> --- builtin/log.c | 11 +---------- t/t4014-format-patch.sh | 11 ----------- 2 files changed, 1 insertion(+), 21 deletions(-) diff --git a/builtin/log.c b/builtin/log.c index a7f129d583..47126f9064 100644 --- a/builtin/log.c +++ b/builtin/log.c @@ -1055,17 +1055,8 @@ static int git_format_config(const char *var, const char *value, return 0; } if (!strcmp(var, "format.commitlistformat")) { - struct strbuf tmp = STRBUF_INIT; - strbuf_init(&tmp, 0); - if (value) - strbuf_addstr(&tmp, value); - else - strbuf_addstr(&tmp, "log:[%(count)/%(total)] %s"); - FREE_AND_NULL(cfg->fmt_cover_letter_commit_list); - git_config_string(&cfg->fmt_cover_letter_commit_list, var, tmp.buf); - strbuf_release(&tmp); - return 0; + return git_config_string(&cfg->fmt_cover_letter_commit_list, var, value); } if (!strcmp(var, "format.outputdirectory")) { FREE_AND_NULL(cfg->config_output_directory); diff --git a/t/t4014-format-patch.sh b/t/t4014-format-patch.sh index d2a775f78d..ca37f40a6a 100755 --- a/t/t4014-format-patch.sh +++ b/t/t4014-format-patch.sh @@ -451,17 +451,6 @@ test_expect_success 'cover letter config with count and author' ' test_line_count = 2 result ' -test_expect_success 'cover letter config commitlistformat set but no format' ' - test_when_finished "rm -rf patches result" && - test_when_finished "git config unset format.coverletter" && - test_when_finished "git config unset format.commitlistformat" && - git config set format.coverletter true && - printf "\tcommitlistformat" >> .git/config && - git format-patch -o patches HEAD~2 && - grep -E "^[[[:digit:]]+/[[:digit:]]+] .*" patches/0000-cover-letter.patch >result && - test_line_count = 2 result -' - test_expect_success 'cover letter config commitlistformat set to shortlog' ' test_when_finished "rm -rf patches result" && test_when_finished "git config unset format.coverletter" && -- 2.53.0.1118.gaef5881109 ^ permalink raw reply related [flat|nested] 42+ messages in thread
* [PATCH v3 6/8] format-patch: wrap generate_commit_list_cover() 2026-03-23 16:57 ` [PATCH v3 0/8] improve "git format-patch --commit-list-format" Mirko Faina ` (4 preceding siblings ...) 2026-03-23 16:57 ` [PATCH v3 5/8] format.commitListFormat: strip meaning from empty Mirko Faina @ 2026-03-23 16:57 ` Mirko Faina 2026-03-23 16:57 ` [PATCH v3 7/8] format-patch: add preset for --commit-list-format Mirko Faina ` (3 subsequent siblings) 9 siblings, 0 replies; 42+ messages in thread From: Mirko Faina @ 2026-03-23 16:57 UTC (permalink / raw) To: git; +Cc: Mirko Faina, Kristoffer Haugsbakk While most conventions should not allow for the text lines in commit messages to get too long, when they do it could make emails harder to read. Teach generate_commit_list_cover() to wrap its commit lines if they are too long. Signed-off-by: Mirko Faina <mroik@delayed.space> --- builtin/log.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/builtin/log.c b/builtin/log.c index 47126f9064..d1765ce4ad 100644 --- a/builtin/log.c +++ b/builtin/log.c @@ -40,6 +40,7 @@ #include "progress.h" #include "commit-slab.h" #include "advice.h" +#include "utf8.h" #include "commit-reach.h" #include "range-diff.h" @@ -1364,6 +1365,7 @@ static void generate_commit_list_cover(FILE *cover_file, const char *format, struct commit **list, int n) { struct strbuf commit_line = STRBUF_INIT; + struct strbuf wrapped_line = STRBUF_INIT; struct pretty_print_context ctx = {0}; struct rev_info rev = REV_INFO_INIT; @@ -1373,12 +1375,16 @@ static void generate_commit_list_cover(FILE *cover_file, const char *format, rev.nr = i; repo_format_commit_message(the_repository, list[n - i], format, &commit_line, &ctx); - fprintf(cover_file, "%s\n", commit_line.buf); + strbuf_add_wrapped_text(&wrapped_line, commit_line.buf, 0, 0, + MAIL_DEFAULT_WRAP); + fprintf(cover_file, "%s\n", wrapped_line.buf); strbuf_reset(&commit_line); + strbuf_reset(&wrapped_line); } fprintf(cover_file, "\n"); strbuf_release(&commit_line); + strbuf_release(&wrapped_line); } static void make_cover_letter(struct rev_info *rev, int use_separate_file, -- 2.53.0.1118.gaef5881109 ^ permalink raw reply related [flat|nested] 42+ messages in thread
* [PATCH v3 7/8] format-patch: add preset for --commit-list-format 2026-03-23 16:57 ` [PATCH v3 0/8] improve "git format-patch --commit-list-format" Mirko Faina ` (5 preceding siblings ...) 2026-03-23 16:57 ` [PATCH v3 6/8] format-patch: wrap generate_commit_list_cover() Mirko Faina @ 2026-03-23 16:57 ` Mirko Faina 2026-03-23 16:57 ` [PATCH v3 8/8] format-patch: --commit-list-format without prefix Mirko Faina ` (2 subsequent siblings) 9 siblings, 0 replies; 42+ messages in thread From: Mirko Faina @ 2026-03-23 16:57 UTC (permalink / raw) To: git; +Cc: Mirko Faina, Kristoffer Haugsbakk "git format-patch --commit-list-format" enables the user to make their own format for the commit list in the cover letter. It would be nice to have a ready to use format to replace shortlog. Teach make_cover_letter() the "modern" format preset. This new format is the same as: "log:[%(count)/%(total)] %s". Signed-off-by: Mirko Faina <mroik@delayed.space> --- Documentation/config/format.adoc | 2 +- Documentation/git-format-patch.adoc | 4 ++-- builtin/log.c | 3 +++ t/t4014-format-patch.sh | 20 +++++++++++++++----- 4 files changed, 21 insertions(+), 8 deletions(-) diff --git a/Documentation/config/format.adoc b/Documentation/config/format.adoc index ea5ec5df7a..ef1ed1d250 100644 --- a/Documentation/config/format.adoc +++ b/Documentation/config/format.adoc @@ -104,7 +104,7 @@ format.coverLetter:: format.commitListFormat:: When the `--cover-letter-format` option is not given, `format-patch` uses the value of this variable to decide how to format the title of - each commit. Default to `shortlog`. + each commit. Defaults to `shortlog`. format.outputDirectory:: Set a custom directory to store the resulting files instead of the diff --git a/Documentation/git-format-patch.adoc b/Documentation/git-format-patch.adoc index 45ca72e670..55cc680685 100644 --- a/Documentation/git-format-patch.adoc +++ b/Documentation/git-format-patch.adoc @@ -325,8 +325,8 @@ feeding the result to `git send-email`. --commit-list-format=<format-spec>:: Specify the format in which to generate the commit list of the patch - series. The accepted values for format-spec are "shortlog" or a format - string prefixed with `log:`. + series. The accepted values for format-spec are `shortlog`, `modern` or a + format string prefixed with `log:`. e.g. `log: %s (%an)` If not given, defaults to the `format.commitListFormat` configuration variable. diff --git a/builtin/log.c b/builtin/log.c index d1765ce4ad..c6cf04350a 100644 --- a/builtin/log.c +++ b/builtin/log.c @@ -1445,6 +1445,9 @@ static void make_cover_letter(struct rev_info *rev, int use_separate_file, generate_commit_list_cover(rev->diffopt.file, format, list, nr); else if (!strcmp(format, "shortlog")) generate_shortlog_cover_letter(&log, rev, list, nr); + else if (!strcmp(format, "modern")) + generate_commit_list_cover(rev->diffopt.file, "[%(count)/%(total)] %s", + list, nr); else die(_("'%s' is not a valid format string"), format); diff --git a/t/t4014-format-patch.sh b/t/t4014-format-patch.sh index ca37f40a6a..7571cc582b 100755 --- a/t/t4014-format-patch.sh +++ b/t/t4014-format-patch.sh @@ -392,18 +392,17 @@ test_expect_success 'cover letter with subject, author and count' ' test_grep "^\[1/1\] This is a subject (A U Thor)$" patches/0000-cover-letter.patch ' -test_expect_success 'cover letter with author and count' ' +test_expect_success 'cover letter modern format' ' test_when_finished "git reset --hard HEAD~1" && test_when_finished "rm -rf patches test_file" && touch test_file && git add test_file && git commit -m "This is a subject" && - git format-patch --commit-list-format="log:[%(count)/%(total)] %an" \ - -o patches HEAD~1 && - test_grep "^\[1/1\] A U Thor$" patches/0000-cover-letter.patch + git format-patch --commit-list-format="modern" -o patches HEAD~1 && + test_grep "^\[1/1\] This is a subject$" patches/0000-cover-letter.patch ' -test_expect_success 'cover letter shortlog' ' +test_expect_success 'cover letter shortlog format' ' test_when_finished "git reset --hard HEAD~1" && test_when_finished "rm -rf expect patches result test_file" && cat >expect <<-"EOF" && @@ -451,6 +450,17 @@ test_expect_success 'cover letter config with count and author' ' test_line_count = 2 result ' +test_expect_success 'cover letter config commitlistformat set to modern' ' + test_when_finished "rm -rf patches result" && + test_when_finished "git config unset format.coverletter" && + test_when_finished "git config unset format.commitlistformat" && + git config set format.coverletter true && + git config set format.commitlistformat modern && + git format-patch -o patches HEAD~2 && + grep -E "^[[[:digit:]]+/[[:digit:]]+] .*$" patches/0000-cover-letter.patch >result && + test_line_count = 2 result +' + test_expect_success 'cover letter config commitlistformat set to shortlog' ' test_when_finished "rm -rf patches result" && test_when_finished "git config unset format.coverletter" && -- 2.53.0.1118.gaef5881109 ^ permalink raw reply related [flat|nested] 42+ messages in thread
* [PATCH v3 8/8] format-patch: --commit-list-format without prefix 2026-03-23 16:57 ` [PATCH v3 0/8] improve "git format-patch --commit-list-format" Mirko Faina ` (6 preceding siblings ...) 2026-03-23 16:57 ` [PATCH v3 7/8] format-patch: add preset for --commit-list-format Mirko Faina @ 2026-03-23 16:57 ` Mirko Faina 2026-03-23 20:10 ` [PATCH v3 0/8] improve "git format-patch --commit-list-format" Junio C Hamano 2026-03-26 16:34 ` D. Ben Knoble 9 siblings, 0 replies; 42+ messages in thread From: Mirko Faina @ 2026-03-23 16:57 UTC (permalink / raw) To: git; +Cc: Mirko Faina, Kristoffer Haugsbakk Having to prefix a custom format-string with "log:" when passed from the CLI can be annoying. It would be great if this prefix wasn't required. Teach make_cover_letter() to accept custom format-strings without the "log:" prefix if a placeholder is detected. Note that both here and in "git log --format" the check is done naively by just checking for the presence of a '%'. Signed-off-by: Mirko Faina <mroik@delayed.space> --- Documentation/git-format-patch.adoc | 4 +++- builtin/log.c | 2 ++ t/t4014-format-patch.sh | 24 ++++++++++++++++++++++++ 3 files changed, 29 insertions(+), 1 deletion(-) diff --git a/Documentation/git-format-patch.adoc b/Documentation/git-format-patch.adoc index 55cc680685..c52dbcc170 100644 --- a/Documentation/git-format-patch.adoc +++ b/Documentation/git-format-patch.adoc @@ -326,8 +326,10 @@ feeding the result to `git send-email`. --commit-list-format=<format-spec>:: Specify the format in which to generate the commit list of the patch series. The accepted values for format-spec are `shortlog`, `modern` or a - format string prefixed with `log:`. + format-string prefixed with `log:`. e.g. `log: %s (%an)` + The user is allowed to drop the prefix if the format-string contains a + `%<placeholder>`. If not given, defaults to the `format.commitListFormat` configuration variable. This option implies the use of `--cover-letter` unless diff --git a/builtin/log.c b/builtin/log.c index c6cf04350a..ad7b7215fe 100644 --- a/builtin/log.c +++ b/builtin/log.c @@ -1448,6 +1448,8 @@ static void make_cover_letter(struct rev_info *rev, int use_separate_file, else if (!strcmp(format, "modern")) generate_commit_list_cover(rev->diffopt.file, "[%(count)/%(total)] %s", list, nr); + else if (strchr(format, '%')) + generate_commit_list_cover(rev->diffopt.file, format, list, nr); else die(_("'%s' is not a valid format string"), format); diff --git a/t/t4014-format-patch.sh b/t/t4014-format-patch.sh index 7571cc582b..7517094bd6 100755 --- a/t/t4014-format-patch.sh +++ b/t/t4014-format-patch.sh @@ -392,6 +392,30 @@ test_expect_success 'cover letter with subject, author and count' ' test_grep "^\[1/1\] This is a subject (A U Thor)$" patches/0000-cover-letter.patch ' +test_expect_success 'cover letter with custom format no prefix' ' + rm -rf patches && + test_when_finished "git reset --hard HEAD~1" && + test_when_finished "rm -rf patches test_file" && + touch test_file && + git add test_file && + git commit -m "This is a subject" && + git format-patch --commit-list-format="[%(count)/%(total)] %s (%an)" \ + -o patches HEAD~1 && + test_grep "^\[1/1\] This is a subject (A U Thor)$" patches/0000-cover-letter.patch +' + +test_expect_success 'cover letter fail when no prefix and no placeholder' ' + rm -rf patches && + test_when_finished "git reset --hard HEAD~1" && + test_when_finished "rm -rf patches test_file err" && + touch test_file && + git add test_file && + git commit -m "This is a subject" && + test_must_fail git format-patch --commit-list-format="this should fail" \ + -o patches HEAD~1 2>err && + test_grep "is not a valid format string" err +' + test_expect_success 'cover letter modern format' ' test_when_finished "git reset --hard HEAD~1" && test_when_finished "rm -rf patches test_file" && -- 2.53.0.1118.gaef5881109 ^ permalink raw reply related [flat|nested] 42+ messages in thread
* Re: [PATCH v3 0/8] improve "git format-patch --commit-list-format" 2026-03-23 16:57 ` [PATCH v3 0/8] improve "git format-patch --commit-list-format" Mirko Faina ` (7 preceding siblings ...) 2026-03-23 16:57 ` [PATCH v3 8/8] format-patch: --commit-list-format without prefix Mirko Faina @ 2026-03-23 20:10 ` Junio C Hamano 2026-03-24 16:19 ` Kristoffer Haugsbakk 2026-03-26 14:29 ` Phillip Wood 2026-03-26 16:34 ` D. Ben Knoble 9 siblings, 2 replies; 42+ messages in thread From: Junio C Hamano @ 2026-03-23 20:10 UTC (permalink / raw) To: Mirko Faina; +Cc: git, Kristoffer Haugsbakk Mirko Faina <mroik@delayed.space> writes: > Not much has changed, just applied the suggestions Kristoffer made. > Thank you again for the review > > [1/8] pretty.c: better die message %(count) and %(total) (Mirko Faina) > [2/8] format-patch: refactor generate_commit_list_cover (Mirko Faina) > [3/8] format-patch: rename --cover-letter-format option (Mirko Faina) > [4/8] docs/pretty-formats: add %(count) and %(total) (Mirko Faina) > [5/8] format.commitListFormat: strip meaning from empty (Mirko Faina) > [6/8] format-patch: wrap generate_commit_list_cover() (Mirko Faina) > [7/8] format-patch: add preset for --commit-list-format (Mirko Faina) > [8/8] format-patch: --commit-list-format without prefix (Mirko Faina) > > Documentation/config/format.adoc | 2 +- > Documentation/git-format-patch.adoc | 19 ++++---- > Documentation/pretty-formats.adoc | 4 ++ > builtin/log.c | 35 +++++++------- > pretty.c | 4 +- > t/t4014-format-patch.sh | 72 +++++++++++++++++++---------- > t/t9902-completion.sh | 1 - > 7 files changed, 84 insertions(+), 53 deletions(-) All incremental changes look reasonable to me, and it seems we have already reached the point of diminishing returns? It is possible that people are only commenting on low-hanging obvious typoes and mistakes without seeing a bigger picture, but I think I've read through an earlier iteration of the series, and found it more-or-less solid, and I do not think there was a drastic change of course since then, so I am happy to mark the topic for 'next' now. Unless other people find bigger issues remaining in the series, that is, of course ;-) Thanks. ^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH v3 0/8] improve "git format-patch --commit-list-format" 2026-03-23 20:10 ` [PATCH v3 0/8] improve "git format-patch --commit-list-format" Junio C Hamano @ 2026-03-24 16:19 ` Kristoffer Haugsbakk 2026-03-26 14:29 ` Phillip Wood 1 sibling, 0 replies; 42+ messages in thread From: Kristoffer Haugsbakk @ 2026-03-24 16:19 UTC (permalink / raw) To: Junio C Hamano, Mirko Faina; +Cc: git On Mon, Mar 23, 2026, at 21:10, Junio C Hamano wrote: >>[snip] >> 7 files changed, 84 insertions(+), 53 deletions(-) > > All incremental changes look reasonable to me, and it seems we have > already reached the point of diminishing returns? > > It is possible that people are only commenting on low-hanging > obvious typoes and mistakes without seeing a bigger picture, All my comments here are from spotting things accidentally and are not in any way holistic assessments. ;) > but I think I've read through an earlier iteration of the series, > and found it more-or-less solid, and I do not think there was a > drastic change of course since then, so I am happy to mark the topic > for 'next' now. > > Unless other people find bigger issues remaining in the series, that > is, of course ;-) ^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH v3 0/8] improve "git format-patch --commit-list-format" 2026-03-23 20:10 ` [PATCH v3 0/8] improve "git format-patch --commit-list-format" Junio C Hamano 2026-03-24 16:19 ` Kristoffer Haugsbakk @ 2026-03-26 14:29 ` Phillip Wood 2026-03-26 16:37 ` Junio C Hamano 1 sibling, 1 reply; 42+ messages in thread From: Phillip Wood @ 2026-03-26 14:29 UTC (permalink / raw) To: Junio C Hamano, Mirko Faina; +Cc: git, Kristoffer Haugsbakk On 23/03/2026 20:10, Junio C Hamano wrote: > Mirko Faina <mroik@delayed.space> writes: > >> Not much has changed, just applied the suggestions Kristoffer made. >> Thank you again for the review >> >> [1/8] pretty.c: better die message %(count) and %(total) (Mirko Faina) >> [2/8] format-patch: refactor generate_commit_list_cover (Mirko Faina) >> [3/8] format-patch: rename --cover-letter-format option (Mirko Faina) >> [4/8] docs/pretty-formats: add %(count) and %(total) (Mirko Faina) >> [5/8] format.commitListFormat: strip meaning from empty (Mirko Faina) >> [6/8] format-patch: wrap generate_commit_list_cover() (Mirko Faina) >> [7/8] format-patch: add preset for --commit-list-format (Mirko Faina) >> [8/8] format-patch: --commit-list-format without prefix (Mirko Faina) >> >> Documentation/config/format.adoc | 2 +- >> Documentation/git-format-patch.adoc | 19 ++++---- >> Documentation/pretty-formats.adoc | 4 ++ >> builtin/log.c | 35 +++++++------- >> pretty.c | 4 +- >> t/t4014-format-patch.sh | 72 +++++++++++++++++++---------- >> t/t9902-completion.sh | 1 - >> 7 files changed, 84 insertions(+), 53 deletions(-) > > All incremental changes look reasonable to me, and it seems we have > already reached the point of diminishing returns? > > It is possible that people are only commenting on low-hanging > obvious typoes and mistakes without seeing a bigger picture, > but I think I've read through an earlier iteration of the series, > and found it more-or-less solid, and I do not think there was a > drastic change of course since then, so I am happy to mark the topic > for 'next' now. > > Unless other people find bigger issues remaining in the series, that > is, of course ;-) I've just had a look at what you merged to next and it looks sound to me. The tweaks to the new feature in this series are very welcome improvements. Thanks Phillip > Thanks. > ^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH v3 0/8] improve "git format-patch --commit-list-format" 2026-03-26 14:29 ` Phillip Wood @ 2026-03-26 16:37 ` Junio C Hamano 2026-03-27 1:13 ` Mirko Faina 0 siblings, 1 reply; 42+ messages in thread From: Junio C Hamano @ 2026-03-26 16:37 UTC (permalink / raw) To: Phillip Wood; +Cc: Mirko Faina, git, Kristoffer Haugsbakk Phillip Wood <phillip.wood123@gmail.com> writes: > On 23/03/2026 20:10, Junio C Hamano wrote: >> Mirko Faina <mroik@delayed.space> writes: >> >>> Not much has changed, just applied the suggestions Kristoffer made. >>> Thank you again for the review >>> ... >>> [7/8] format-patch: add preset for --commit-list-format (Mirko Faina) >>> [8/8] format-patch: --commit-list-format without prefix (Mirko Faina) >>> ... >>> Documentation/config/format.adoc | 2 +- >>> Documentation/git-format-patch.adoc | 19 ++++---- > I've just had a look at what you merged to next and it looks sound to > me. The tweaks to the new feature in this series are very welcome > improvements. Yup, I tried "modern" and generally liked it very much. The appearance of the list looked a bit odd that each element in a list of things with heading was shown without any indentation before the heading, though. I'd probably use --commit-list-format=" %(count): %<(72,trunc)%s" or something like that myself. I seem to be getting spurious blank lines between the lines with the above, when I lengthen and shorten 72 in the format string above, though. I haven't figured out what is broken, though. ^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH v3 0/8] improve "git format-patch --commit-list-format" 2026-03-26 16:37 ` Junio C Hamano @ 2026-03-27 1:13 ` Mirko Faina 2026-03-27 16:04 ` Junio C Hamano 0 siblings, 1 reply; 42+ messages in thread From: Mirko Faina @ 2026-03-27 1:13 UTC (permalink / raw) To: Junio C Hamano; +Cc: Phillip Wood, git, Kristoffer Haugsbakk, Mirko Faina On Thu, Mar 26, 2026 at 09:37:17AM -0700, Junio C Hamano wrote: > Yup, I tried "modern" and generally liked it very much. > > The appearance of the list looked a bit odd that each element in a > list of things with heading was shown without any indentation before > the heading, though. I'd probably use > > --commit-list-format=" %(count): %<(72,trunc)%s" > > or something like that myself. > > I seem to be getting spurious blank lines between the lines with the > above, when I lengthen and shorten 72 in the format string above, > though. I haven't figured out what is broken, though. Could this be because of strbuf_add_wrapped_text()? In a previous review someone pointed out that there was no wrapping, so now each entry goes through a pass of strbuf_add_wrapped_text() which should wrap when the line gets longer than MAIL_DEFAULT_WRAP (72 characters). Since you guarantee at most 72 chars for %s, if it ever gets to that the line would be at least 76 chars long due to " n: ". ^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH v3 0/8] improve "git format-patch --commit-list-format" 2026-03-27 1:13 ` Mirko Faina @ 2026-03-27 16:04 ` Junio C Hamano 2026-03-27 16:18 ` Mirko Faina 0 siblings, 1 reply; 42+ messages in thread From: Junio C Hamano @ 2026-03-27 16:04 UTC (permalink / raw) To: Mirko Faina; +Cc: Phillip Wood, git, Kristoffer Haugsbakk Mirko Faina <mroik@delayed.space> writes: > On Thu, Mar 26, 2026 at 09:37:17AM -0700, Junio C Hamano wrote: >> Yup, I tried "modern" and generally liked it very much. >> >> The appearance of the list looked a bit odd that each element in a >> list of things with heading was shown without any indentation before >> the heading, though. I'd probably use >> >> --commit-list-format=" %(count): %<(72,trunc)%s" >> >> or something like that myself. >> >> I seem to be getting spurious blank lines between the lines with the >> above, when I lengthen and shorten 72 in the format string above, >> though. I haven't figured out what is broken, though. > > Could this be because of strbuf_add_wrapped_text()? Ahh, I think that would explain it. In general, I think it is a mistake to use strbuf_addwrapped_text() for any end-user configurable output. After all, wouldn't %w(w,i1,i2) work in the format string? > In a previous review > someone pointed out that there was no wrapping, When the payload _can_ be specified to wrap (i.e., end-user configurable output format), the wrapping should not be forced by the mechanism. A project that is not ours may want to keep a single long line for their commit list entries. I do not mind if the default "modern" were defined to include %w() to force wrapping to those who follow the default, of course. But do not unconditionally wrap what the end-user formatted to their liking. ^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH v3 0/8] improve "git format-patch --commit-list-format" 2026-03-27 16:04 ` Junio C Hamano @ 2026-03-27 16:18 ` Mirko Faina 2026-03-27 16:47 ` Junio C Hamano 0 siblings, 1 reply; 42+ messages in thread From: Mirko Faina @ 2026-03-27 16:18 UTC (permalink / raw) To: Junio C Hamano; +Cc: git, Mirko Faina On Fri, Mar 27, 2026 at 09:04:44AM -0700, Junio C Hamano wrote: > When the payload _can_ be specified to wrap (i.e., end-user > configurable output format), the wrapping should not be forced by > the mechanism. A project that is not ours may want to keep a single > long line for their commit list entries. > > I do not mind if the default "modern" were defined to include %w() > to force wrapping to those who follow the default, of course. But > do not unconditionally wrap what the end-user formatted to their > liking. I see, since there's not much to edit, I'll send the changes regarding the docs and the wrapping in a single series (I saw that you already made mf/format-patch-commit-list-format-doc but I hope it is not a problem), instead of submitting a new one. ^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH v3 0/8] improve "git format-patch --commit-list-format" 2026-03-27 16:18 ` Mirko Faina @ 2026-03-27 16:47 ` Junio C Hamano 0 siblings, 0 replies; 42+ messages in thread From: Junio C Hamano @ 2026-03-27 16:47 UTC (permalink / raw) To: Mirko Faina; +Cc: git Mirko Faina <mroik@delayed.space> writes: > On Fri, Mar 27, 2026 at 09:04:44AM -0700, Junio C Hamano wrote: >> When the payload _can_ be specified to wrap (i.e., end-user >> configurable output format), the wrapping should not be forced by >> the mechanism. A project that is not ours may want to keep a single >> long line for their commit list entries. >> >> I do not mind if the default "modern" were defined to include %w() >> to force wrapping to those who follow the default, of course. But >> do not unconditionally wrap what the end-user formatted to their >> liking. > > I see, since there's not much to edit, I'll send the changes regarding > the docs and the wrapping in a single series (I saw that you already > made mf/format-patch-commit-list-format-doc but I hope it is not a > problem), instead of submitting a new one. I do not quite know what you are planning to do with the above four lines, but you do not have to answer me here, as we'll know soon enough once you post them. I'll just have to remember *not* to merge the new -doc topic to 'next' until that happens ;-). ^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH v3 0/8] improve "git format-patch --commit-list-format" 2026-03-23 16:57 ` [PATCH v3 0/8] improve "git format-patch --commit-list-format" Mirko Faina ` (8 preceding siblings ...) 2026-03-23 20:10 ` [PATCH v3 0/8] improve "git format-patch --commit-list-format" Junio C Hamano @ 2026-03-26 16:34 ` D. Ben Knoble 2026-03-26 17:15 ` Mirko Faina 9 siblings, 1 reply; 42+ messages in thread From: D. Ben Knoble @ 2026-03-26 16:34 UTC (permalink / raw) To: Mirko Faina; +Cc: git, Kristoffer Haugsbakk On Mon, Mar 23, 2026 at 1:32 PM Mirko Faina <mroik@delayed.space> wrote: > > Not much has changed, just applied the suggestions Kristoffer made. > Thank you again for the review > > [1/8] pretty.c: better die message %(count) and %(total) (Mirko Faina) > [2/8] format-patch: refactor generate_commit_list_cover (Mirko Faina) > [3/8] format-patch: rename --cover-letter-format option (Mirko Faina) > [4/8] docs/pretty-formats: add %(count) and %(total) (Mirko Faina) > [5/8] format.commitListFormat: strip meaning from empty (Mirko Faina) > [6/8] format-patch: wrap generate_commit_list_cover() (Mirko Faina) > [7/8] format-patch: add preset for --commit-list-format (Mirko Faina) > [8/8] format-patch: --commit-list-format without prefix (Mirko Faina) I've just noticed: - we don't specify the default value in git-format-patch(1), so I have to jump from there to git-config(1) to look it up - we don't specify what the "modern" format means Maybe that was all hashed out already, in which case links appreciated :) -- D. Ben Knoble ^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH v3 0/8] improve "git format-patch --commit-list-format" 2026-03-26 16:34 ` D. Ben Knoble @ 2026-03-26 17:15 ` Mirko Faina 0 siblings, 0 replies; 42+ messages in thread From: Mirko Faina @ 2026-03-26 17:15 UTC (permalink / raw) To: D. Ben Knoble; +Cc: git, Kristoffer Haugsbakk, Mirko Faina On Thu, Mar 26, 2026 at 12:34:00PM -0400, D. Ben Knoble wrote: > On Mon, Mar 23, 2026 at 1:32 PM Mirko Faina <mroik@delayed.space> wrote: > > > > Not much has changed, just applied the suggestions Kristoffer made. > > Thank you again for the review > > > > [1/8] pretty.c: better die message %(count) and %(total) (Mirko Faina) > > [2/8] format-patch: refactor generate_commit_list_cover (Mirko Faina) > > [3/8] format-patch: rename --cover-letter-format option (Mirko Faina) > > [4/8] docs/pretty-formats: add %(count) and %(total) (Mirko Faina) > > [5/8] format.commitListFormat: strip meaning from empty (Mirko Faina) > > [6/8] format-patch: wrap generate_commit_list_cover() (Mirko Faina) > > [7/8] format-patch: add preset for --commit-list-format (Mirko Faina) > > [8/8] format-patch: --commit-list-format without prefix (Mirko Faina) > > I've just noticed: > - we don't specify the default value in git-format-patch(1), so I have > to jump from there to git-config(1) to look it up > - we don't specify what the "modern" format means > > Maybe that was all hashed out already, in which case links appreciated :) No, you're right. It doesn't say what the default is in --commit-list-format, it just says that it defaults to format.commitListFormat if not given. I will send a patch to fix the docs. I guess I should also change the text for --cover-letter as the commit list can now be something other than a shortlog. Thank you for pointing out. ^ permalink raw reply [flat|nested] 42+ messages in thread
end of thread, other threads:[~2026-03-27 16:47 UTC | newest] Thread overview: 42+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2026-03-14 23:20 [PATCH 0/7] improve "git format-patch --commit-list-format" Mirko Faina 2026-03-14 23:20 ` [PATCH 1/7] pretty.c: better die message %(count) and %(total) Mirko Faina 2026-03-14 23:20 ` [PATCH 2/7] format-patch: refactor generate_commit_list_cover Mirko Faina 2026-03-14 23:20 ` [PATCH 3/7] format-patch: rename --cover-letter-format option Mirko Faina 2026-03-14 23:20 ` [PATCH 4/7] format.commitListFormat: strip meaning from empty Mirko Faina 2026-03-14 23:20 ` [PATCH 5/7] format-patch: wrap generate_commit_list_cover() Mirko Faina 2026-03-17 15:32 ` Kristoffer Haugsbakk 2026-03-17 16:18 ` Mirko Faina 2026-03-14 23:20 ` [PATCH 6/7] format-patch: add preset for --commit-list-format Mirko Faina 2026-03-14 23:20 ` [PATCH 7/7] format-patch: --commit-list-format without prefix Mirko Faina 2026-03-17 15:29 ` Kristoffer Haugsbakk 2026-03-17 16:20 ` Mirko Faina 2026-03-19 22:38 ` [PATCH v2 0/8] improve "git format-patch --commit-list-format" Mirko Faina 2026-03-19 22:38 ` [PATCH v2 1/8] pretty.c: better die message %(count) and %(total) Mirko Faina 2026-03-19 22:38 ` [PATCH v2 2/8] format-patch: refactor generate_commit_list_cover Mirko Faina 2026-03-19 22:38 ` [PATCH v2 3/8] format-patch: rename --cover-letter-format option Mirko Faina 2026-03-19 22:38 ` [PATCH v2 4/8] docs/pretty-formats: add %(count) and %(total) Mirko Faina 2026-03-23 10:29 ` Kristoffer Haugsbakk 2026-03-23 14:00 ` Mirko Faina 2026-03-19 22:38 ` [PATCH v2 5/8] format.commitListFormat: strip meaning from empty Mirko Faina 2026-03-19 22:38 ` [PATCH v2 6/8] format-patch: wrap generate_commit_list_cover() Mirko Faina 2026-03-19 22:38 ` [PATCH v2 7/8] format-patch: add preset for --commit-list-format Mirko Faina 2026-03-19 22:38 ` [PATCH v2 8/8] format-patch: --commit-list-format without prefix Mirko Faina 2026-03-23 16:57 ` [PATCH v3 0/8] improve "git format-patch --commit-list-format" Mirko Faina 2026-03-23 16:57 ` [PATCH v3 1/8] pretty.c: better die message %(count) and %(total) Mirko Faina 2026-03-23 16:57 ` [PATCH v3 2/8] format-patch: refactor generate_commit_list_cover Mirko Faina 2026-03-23 16:57 ` [PATCH v3 3/8] format-patch: rename --cover-letter-format option Mirko Faina 2026-03-23 16:57 ` [PATCH v3 4/8] docs/pretty-formats: add %(count) and %(total) Mirko Faina 2026-03-23 16:57 ` [PATCH v3 5/8] format.commitListFormat: strip meaning from empty Mirko Faina 2026-03-23 16:57 ` [PATCH v3 6/8] format-patch: wrap generate_commit_list_cover() Mirko Faina 2026-03-23 16:57 ` [PATCH v3 7/8] format-patch: add preset for --commit-list-format Mirko Faina 2026-03-23 16:57 ` [PATCH v3 8/8] format-patch: --commit-list-format without prefix Mirko Faina 2026-03-23 20:10 ` [PATCH v3 0/8] improve "git format-patch --commit-list-format" Junio C Hamano 2026-03-24 16:19 ` Kristoffer Haugsbakk 2026-03-26 14:29 ` Phillip Wood 2026-03-26 16:37 ` Junio C Hamano 2026-03-27 1:13 ` Mirko Faina 2026-03-27 16:04 ` Junio C Hamano 2026-03-27 16:18 ` Mirko Faina 2026-03-27 16:47 ` Junio C Hamano 2026-03-26 16:34 ` D. Ben Knoble 2026-03-26 17:15 ` Mirko Faina
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox