From: Patrick Steinhardt <ps@pks.im>
To: Mahi Kassa <mahlet.takassa@gmail.com>
Cc: git@vger.kernel.org, gitster@pobox.com,
lucasseikioshiro@gmail.com, jltobler@gmail.com
Subject: Re: [PATCH v2] repo: show subcommand-specific help text
Date: Tue, 24 Mar 2026 13:52:37 +0100 [thread overview]
Message-ID: <acKJFZiDg88fON4W@pks.im> (raw)
In-Reply-To: <20260324122111.84122-1-mahlet.takassa@gmail.com>
On Tue, Mar 24, 2026 at 01:21:11PM +0100, Mahi Kassa wrote:
> Use subcommand-specific usage arrays for "git repo info" and
> "git repo structure" so that each command shows only its own
> synopsis in help output.
>
> Factor the shared usage strings into macros to avoid
> duplicating the same synopsis text in multiple arrays.
>
> Add tests to cover the subcommand help behavior.
>
> ---
> v2:
> - wrap commit message lines
> - factor shared usage strings into macros to avoid duplication
> - restore blank lines between tests and before test_done
Something most have gone wrong, as I cannot see any of the macros. We
still duplicate the usage strings.
Patrick
> diff --git a/builtin/repo.c b/builtin/repo.c
> index 55f9b9095c..5ccc5c401a 100644
> --- a/builtin/repo.c
> +++ b/builtin/repo.c
> @@ -27,6 +27,17 @@ static const char *const repo_usage[] = {
> NULL
> };
>
> +static const char *const repo_info_usage[] = {
> + "git repo info [--format=(lines|nul) | -z] [--all | <key>...]",
> + "git repo info --keys [--format=(lines|nul) | -z]",
> + NULL
> +};
> +
> +static const char *const repo_structure_usage[] = {
> + "git repo structure [--format=(table|lines|nul) | -z]",
> + NULL
> +};
> +
> typedef int get_value_fn(struct repository *repo, struct strbuf *buf);
>
> enum output_format {
next prev parent reply other threads:[~2026-03-24 12:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-23 15:29 [PATCH] repo: show subcommand-specific help text Mahi Kassa
2026-03-23 19:32 ` Derrick Stolee
2026-03-24 6:26 ` Patrick Steinhardt
2026-03-24 12:21 ` [PATCH v2] " Mahi Kassa
2026-03-24 12:52 ` Patrick Steinhardt [this message]
2026-03-24 17:07 ` Derrick Stolee
2026-03-24 18:48 ` [PATCH v3] " Mahi Kassa
2026-03-24 19:15 ` Derrick Stolee
2026-03-25 10:01 ` Patrick Steinhardt
2026-03-25 16:55 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acKJFZiDg88fON4W@pks.im \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jltobler@gmail.com \
--cc=lucasseikioshiro@gmail.com \
--cc=mahlet.takassa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox