git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Daniele Sassoli <danielesassoli@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Daniele Sassoli via GitGitGadget <gitgitgadget@gmail.com>,
	git@vger.kernel.org
Subject: Re: [PATCH] doc:clarify which remotes can be used when contributing
Date: Fri, 22 Aug 2025 11:14:20 +0200	[thread overview]
Message-ID: <acbb5f69-98bf-4eab-99ea-08b3155ce9e2@gmail.com> (raw)
In-Reply-To: <xmqqbjo98zjh.fsf@gitster.g>


On 20/08/2025 22:16, Junio C Hamano wrote:
> Daniele Sassoli <danielesassoli@gmail.com> writes:
>
>> On 19/08/2025 22:19, Junio C Hamano wrote:
>>> "Daniele Sassoli via GitGitGadget" <gitgitgadget@gmail.com> writes:
>>>>    https://github.com/gitgitgadget/git and open a PR either with the "New pull
>>>>    request" button or the convenient "Compare & pull request" button that may
>>>>    appear with the name of your newly pushed branch.
>>>> +If you're using https://github.com/git/git as your remote, you will need to
>>>> +open the pull-request from your fork, selecting `git/git` as base.
>>>> +
>>>> +The differences between using `gitgitgadget/git` and `git/git` as your base can
>>>> +be found [here](https://gitgitgadget.github.io/#should-i-use-gitgitgadget-on-gitgitgadgets-git-fork-or-on-gits-github-mirror)
>>> Looking at the table, there is no advantage to use git/git at all.
>> Most of the document, including the "Getting Started" section, points to cloning
>> from git/git. It's only when it comes to the gitgitgadget section that we
>> mention gitgitgadget/git.
>>
>> It's true that there are no advantages of using git/git over gitgitgadget/git,
>> but I would argue that the disadvantages are quite minor and definitely don't
>> impact someone at their first contribution?

First of all, thanks for taking the time to review this series, really
appreciate it.

> Even the disabled things may be rather advanced features, wouldn't
> it still impact them for them to stay to be on git/git?
>
> Those started from git/git have to learn what different things they
> need to do to use GGG by reading this extra piece of documentation,
> and then if they plan to keep using GGG, they will have to do this
> extra thing each and every time until the end of time (since your
> preference is not to teach switching to GGG/git from git/git).

I think for someone's first contribution, the most straightforward thing to do
is simply to stick with what they have setup so far. If someone finds themselves
doing this more than once, I would imagine they know what they're doing and are
not beginners, so can figure out to switch the remote themselves.

>
> I have no strong opinions as I wouldn't be the one who is doing
> something extra every time, but I'd rather see our new contributors
> having to spend less time to get their work published and more time
> to polish their work into reviewable state.

We're trying to achieve the same outcome, which is why I'm trying to have the
reader follow the path of least resistance in getting their patch to the mailing
list. If they then find themselves contributing regularly and realise they need
the more advanced features of gitgitgadget on a regular basis, I'm sure they'll
figure to switch the remote themselves.

>

  reply	other threads:[~2025-08-22  9:14 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-19 19:14 [PATCH] doc:clarify which remotes can be used when contributing Daniele Sassoli via GitGitGadget
2025-08-19 21:19 ` Junio C Hamano
2025-08-20 14:07   ` Daniele Sassoli
2025-08-20 21:16     ` Junio C Hamano
2025-08-22  9:14       ` Daniele Sassoli [this message]
2025-08-22 17:56         ` Junio C Hamano
2025-08-22 18:45 ` Elijah Newren
2025-08-23  9:12 ` [PATCH v2] " Daniele Sassoli via GitGitGadget
2025-08-25 15:39   ` Elijah Newren
2025-08-25 16:21     ` Junio C Hamano
2025-08-26  6:50       ` Daniele Sassoli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=acbb5f69-98bf-4eab-99ea-08b3155ce9e2@gmail.com \
    --to=danielesassoli@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).