Git development
 help / color / mirror / Atom feed
From: Justin Tobler <jltobler@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, christian.couder@gmail.com
Subject: Re: [PATCH v2 0/5] fast-import: extend signed object handling modes
Date: Tue, 31 Mar 2026 18:18:02 -0500	[thread overview]
Message-ID: <acxVmFy9gYITrgcl@denethor> (raw)
In-Reply-To: <xmqqtstvwsxe.fsf@gitster.g>

On 26/03/31 03:11PM, Junio C Hamano wrote:
> Justin Tobler <jltobler@gmail.com> writes:
> 
> > Changes since V1:
> > - Added a prepatory patch which unifies how unsupported signing modes
> >   are handled for git-fast-export(1). Now they are treated like any
> >   other unknown signing mode. Unsupported signing modes for
> >   '--signed-tags' in git-fast-import(1) are left alone because this
> >   series progressively adds support for all these currently unsupported
> >   modes.
> 
> Even though you have this inter-iteration change log (which is very
> good), as the cover letter is not sent as a reply to the cover
> letter of the previous iteration, the mailing list archive
> 
>   https://lore.kernel.org/git/20260326191414.3783974-1-jltobler@gmail.com/
> 
> does not help us navigate to the previous iteration
> 
>   https://lore.kernel.org/git/20260324215513.764739-1-jltobler@gmail.com/
> 
> very easily (I found the above URL by cheating---I looked at notes/amlog
> for a commit from previous iteration jt/fast-import-signed-modes@{1}---but
> that is not for everybody).

Apologies, I should have payed more attention when sending. Thanks for
linking the previous iteration.

> Looks like I was the only one who was interested enough to comment
> on the patches over these two iterations, which is a bit sad, but I
> think the patches are fairly cleanly done and are ready for 'next'.
> 
> Let me mark the topic as such in the "What's cooking" report.

Thanks,
-Justin

      reply	other threads:[~2026-03-31 23:18 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-26 19:14 [PATCH v2 0/5] fast-import: extend signed object handling modes Justin Tobler
2026-03-26 19:14 ` [PATCH v2 1/5] fast-export: check for unsupported signing modes earlier Justin Tobler
2026-03-26 19:14 ` [PATCH v2 2/5] fast-import: add 'abort-if-invalid' mode to '--signed-commits=<mode>' Justin Tobler
2026-03-26 19:14 ` [PATCH v2 3/5] fast-import: add 'strip-if-invalid' mode to '--signed-tags=<mode>' Justin Tobler
2026-03-26 19:14 ` [PATCH v2 4/5] fast-import: add 'sign-if-invalid' " Justin Tobler
2026-03-26 19:14 ` [PATCH v2 5/5] fast-import: add 'abort-if-invalid' " Justin Tobler
2026-03-31 22:11 ` [PATCH v2 0/5] fast-import: extend signed object handling modes Junio C Hamano
2026-03-31 23:18   ` Justin Tobler [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=acxVmFy9gYITrgcl@denethor \
    --to=jltobler@gmail.com \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox