From: "René Scharfe" <l.s.r@web.de>
To: Git List <git@vger.kernel.org>
Cc: Junio C Hamano <gitster@pobox.com>, Taylor Blau <me@ttaylorr.com>
Subject: [PATCH] p5326: create tag needed for shared tests
Date: Sat, 2 Oct 2021 19:22:35 +0200 [thread overview]
Message-ID: <ad6777d3-73d0-54d9-200b-88aad2d265b4@web.de> (raw)
p5326 fails with the following error:
perf 8 - rev-list with tag negated via --not --all (objects):
running:
git rev-list perf-tag --not --all --use-bitmap-index --objects >/dev/null
fatal: ambiguous argument 'perf-tag': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'
Reason: 540cdc11ad (pack-bitmap: avoid traversal of objects referenced
by uninteresting tag, 2021-03-22) added two tests and created a tag as a
prerequisite for them. 9387fbd646 (p5310: extract full and partial
bitmap tests, 2021-08-31) moved the two tests (and others) to
t/perf/lib-bitmap.sh, but not the code for creating the tag. 2d59597333
(p5326: perf tests for MIDX bitmaps, 2021-08-31) used this library, but
didn't create the tag.
Create the neccesary tag in p5326 using the code from p5310.
Signed-off-by: René Scharfe <l.s.r@web.de>
---
t/perf/p5326-multi-pack-bitmaps.sh | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/t/perf/p5326-multi-pack-bitmaps.sh b/t/perf/p5326-multi-pack-bitmaps.sh
index 5845109ac7..51b5636259 100755
--- a/t/perf/p5326-multi-pack-bitmaps.sh
+++ b/t/perf/p5326-multi-pack-bitmaps.sh
@@ -10,6 +10,12 @@ test_expect_success 'enable multi-pack index' '
git config core.multiPackIndex true
'
+# we need to create the tag up front such that it is covered by the repack and
+# thus by generated bitmaps.
+test_expect_success 'create tags' '
+ git tag --message="tag pointing to HEAD" perf-tag HEAD
+'
+
test_perf 'setup multi-pack index' '
git repack -ad &&
git multi-pack-index write --bitmap
--
2.33.0
next reply other threads:[~2021-10-02 17:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-02 17:22 René Scharfe [this message]
2021-10-03 4:58 ` [PATCH] p5326: create tag needed for shared tests Taylor Blau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad6777d3-73d0-54d9-200b-88aad2d265b4@web.de \
--to=l.s.r@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=me@ttaylorr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).