From: Patrick Steinhardt <ps@pks.im>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Ezekiel Newren <ezekielnewren@gmail.com>
Subject: Re: [PATCH 3/4] Linux: link against libdl
Date: Wed, 8 Apr 2026 12:12:14 +0200 [thread overview]
Message-ID: <adYp_l5-PxzQdqRb@pks.im> (raw)
In-Reply-To: <20260403011249.4133372-4-sandals@crustytoothpaste.net>
On Fri, Apr 03, 2026 at 01:12:48AM +0000, brian m. carlson wrote:
> Older versions of Rust on Linux, such as that used in Debian 11 in our
> CI, require linking against libdl. Were we linking with Cargo, this
> would be included automatically, but since we're not, explicitly set it
> in the system-specific config.
>
> This library is part of libc, so linking against it if it happens to be
> unnecessary will add no dependencies to the resulting binary. In
> addition, it is provided by both glibc and musl, so it should be
> portable to almost all Linux systems.
Fair. I was wondering whether we should make this conditional on
WITH_RUST, but if it doesn't make a difference anyway I don't see why we
should.
Patrick
next prev parent reply other threads:[~2026-04-08 10:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-03 1:12 [PATCH 0/4] Enable Rust by default brian m. carlson
2026-04-03 1:12 ` [PATCH 1/4] docs: update version with default Rust support brian m. carlson
2026-04-03 1:12 ` [PATCH 2/4] ci: install cargo on Alpine brian m. carlson
2026-04-08 10:12 ` Patrick Steinhardt
2026-04-03 1:12 ` [PATCH 3/4] Linux: link against libdl brian m. carlson
2026-04-08 10:12 ` Patrick Steinhardt [this message]
2026-04-03 1:12 ` [PATCH 4/4] Enable Rust by default brian m. carlson
2026-04-08 10:12 ` Patrick Steinhardt
2026-04-03 5:04 ` [PATCH 0/4] " Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adYp_l5-PxzQdqRb@pks.im \
--to=ps@pks.im \
--cc=ezekielnewren@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox