git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Santi Béjar" <santi@agolina.net>
To: Thomas Rast <trast@student.ethz.ch>
Cc: git@vger.kernel.org, Junio C Hamano <junio@pobox.com>,
	Johannes Schindelin <johannes.schindelin@gmx.de>,
	"Boyd Stephen Smith Jr." <bss@iguanasuicide.net>,
	Teemu Likonen <tlikonen@iki.fi>
Subject: Re: [PATCH v4 0/7] customizable --color-words
Date: Sun, 18 Jan 2009 16:29:54 +0100	[thread overview]
Message-ID: <adf1fd3d0901180729u3da69108i6140aa7f68bda972@mail.gmail.com> (raw)
In-Reply-To: <adf1fd3d0901180705s260f0051wb4e3a978601618ec@mail.gmail.com>

2009/1/18 Santi Béjar <santi@agolina.net>:
> 2009/1/17 Thomas Rast <trast@student.ethz.ch>:
>> Johannes Schindelin wrote:
>>> Thomas, could you pick up the patches from my 'my-next' branch and
>>> maintain an "official" topic branch?
>>
>> I cherry-picked the three commits you had there, and rebuilt on top.
>> I pushed them to
>>
>>  git://repo.or.cz/git/trast.git tr/word-diff-p2
>>
>> again (js/word-diff-p1 again points directly at your half).
>
> I've tested tr/word-diff-p2 and I have not found any issues. I've even
> tested that nothing changed from the tradicional word diff to:
>
> git log -p --color-words="[^[:space:]]+"
>
> for the whole git history.
>

What I tested is that the new code produces the same result for this
two commands:

git log -p --color-words="[^[:space:]]+"
git log -p --color-words

The old code produced color codes before and after each word, while
the new only at the begining of the color and the end of the color. So
they cannot produce the same output but equivalent.

Santi

  reply	other threads:[~2009-01-18 15:31 UTC|newest]

Thread overview: 109+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-11 19:58 [PATCH 0/4] refactor the --color-words to make it more hackable Johannes Schindelin
2009-01-11 19:59 ` [PATCH 1/4] Add color_fwrite(), a function coloring each line individually Johannes Schindelin
2009-01-11 22:43   ` Junio C Hamano
2009-01-11 23:49     ` Johannes Schindelin
2009-01-11 23:49       ` [PATCH v2 " Johannes Schindelin
2009-01-12  1:27         ` Jakub Narebski
2009-01-11 19:59 ` [PATCH 2/4] color-words: refactor word splitting and use ALLOC_GROW() Johannes Schindelin
2009-01-11 19:59 ` [PATCH 3/4] color-words: refactor to allow for 0-character word boundaries Johannes Schindelin
2009-01-11 23:08   ` Junio C Hamano
2009-01-11 23:38     ` Johannes Schindelin
2009-01-12  8:47   ` Thomas Rast
2009-01-12  9:36     ` Junio C Hamano
2009-01-11 20:00 ` [PATCH 4/4] color-words: take an optional regular expression describing words Johannes Schindelin
2009-01-11 21:53 ` [PATCH 0/4] refactor the --color-words to make it more hackable Thomas Rast
2009-01-11 23:02   ` Johannes Schindelin
2009-01-12  6:25     ` Thomas Rast
2009-01-14 13:00 ` Santi Béjar
2009-01-14 17:49   ` [PATCH take 3 0/4] color-words improvements Johannes Schindelin
2009-01-14 17:50     ` [PATCH 1/4] Add color_fwrite_lines(), a function coloring each line individually Johannes Schindelin
2009-01-14 17:50     ` [PATCH 2/4] color-words: refactor word splitting and use ALLOC_GROW() Johannes Schindelin
2009-01-14 17:51     ` [PATCH 3/4] color-words: change algorithm to allow for 0-character word boundaries Johannes Schindelin
2009-01-14 18:08       ` Johannes Schindelin
2009-01-14 17:51     ` [PATCH 4/4] color-words: take an optional regular expression describing words Johannes Schindelin
2009-01-14 19:55       ` Thomas Rast
2009-01-14 18:54     ` [PATCH take 3 0/4] color-words improvements Teemu Likonen
2009-01-14 18:57       ` Teemu Likonen
2009-01-14 19:28         ` Johannes Schindelin
2009-01-14 19:32           ` Johannes Schindelin
2009-01-14 20:44             ` [PATCH replacement for take 3 3/4] color-words: change algorithm to allow for 0-character word boundaries Johannes Schindelin
2009-01-14 20:46               ` [PATCH replacement for take 3 4/4] color-words: take an optional regular expression describing words Johannes Schindelin
2009-01-15  0:32                 ` Thomas Rast
2009-01-15  1:12                   ` Johannes Schindelin
2009-01-15  1:36                     ` Johannes Schindelin
2009-01-15  8:30                       ` Thomas Rast
2009-01-15 10:40                         ` Thomas Rast
2009-01-15 12:54                           ` Johannes Schindelin
2009-01-14 19:58       ` [PATCH take 3 0/4] color-words improvements Thomas Rast
2009-01-14 22:06         ` Johannes Schindelin
2009-01-14 22:11           ` Thomas Rast
2009-01-14 22:24           ` Boyd Stephen Smith Jr.
2009-01-15  4:56           ` Teemu Likonen
2009-01-15 12:41             ` Johannes Schindelin
2009-01-15 13:03               ` Teemu Likonen
2009-01-15 13:27                 ` Thomas Rast
2009-01-15 18:15               ` Junio C Hamano
2009-01-15 19:25                 ` Johannes Schindelin
2009-01-16  0:10                   ` Santi Béjar
2009-01-16  1:37                     ` Junio C Hamano
2009-01-16  1:42                     ` Boyd Stephen Smith Jr.
2009-01-16  1:55                     ` Johannes Schindelin
2009-01-16  9:02                       ` Santi Béjar
2009-01-16 11:57                         ` Johannes Schindelin
2009-01-16 12:01                         ` Santi Béjar
2009-01-16 12:40                           ` Johannes Schindelin
2009-01-16 19:04                           ` Thomas Rast
2009-01-16 21:09                             ` Johannes Schindelin
2009-01-17 16:29                               ` [PATCH v4 0/7] customizable --color-words Thomas Rast
2009-01-17 16:29                                 ` [PATCH v4 1/7] Add color_fwrite_lines(), a function coloring each line individually Thomas Rast
2009-01-17 16:29                                   ` [PATCH v4 2/7] color-words: refactor word splitting and use ALLOC_GROW() Thomas Rast
2009-01-17 16:29                                     ` [PATCH v4 3/7] color-words: change algorithm to allow for 0-character word boundaries Thomas Rast
2009-01-17 16:29                                       ` [PATCH v4 4/7] color-words: take an optional regular expression describing words Thomas Rast
2009-01-17 16:29                                         ` [PATCH v4 5/7] color-words: enable REG_NEWLINE to help user Thomas Rast
2009-01-17 16:29                                           ` [PATCH v4 6/7] color-words: expand docs with precise semantics Thomas Rast
2009-01-17 16:29                                             ` [PATCH v4 7/7] color-words: make regex configurable via attributes Thomas Rast
2009-01-18 15:05                                 ` [PATCH v4 0/7] customizable --color-words Santi Béjar
2009-01-18 15:29                                   ` Santi Béjar [this message]
2009-01-19 22:47                                 ` Santi Béjar
2009-01-19 23:35                                   ` Johannes Schindelin
2009-01-20  2:17                                     ` [PATCH] Add tests for diff.color-words configuration option Boyd Stephen Smith Jr.
2009-01-20  3:45                                       ` [PATCH] diff: Support diff.color-words config option Boyd Stephen Smith Jr.
2009-01-20  6:59                                         ` Junio C Hamano
2009-01-20 17:42                                           ` Markus Heidelberg
2009-01-20 17:58                                             ` Boyd Stephen Smith Jr.
2009-01-20 21:08                                             ` Johannes Schindelin
2009-01-21 10:27                                               ` Junio C Hamano
2009-01-21 19:37                                               ` Markus Heidelberg
2009-01-20 10:02                                         ` Johannes Schindelin
2009-01-20 16:52                                           ` Boyd Stephen Smith Jr.
2009-01-20 17:14                                             ` Johannes Schindelin
2009-01-20 17:09                                           ` Junio C Hamano
2009-01-20 17:28                                             ` Johannes Schindelin
2009-01-20 20:27                                               ` Junio C Hamano
2009-01-20 21:02                                                 ` Johannes Schindelin
2009-01-21  3:46                                           ` [PATCH] color-words: " Boyd Stephen Smith Jr.
2009-01-21  4:59                                             ` [PATCH] Change the spelling of "wordregex" Boyd Stephen Smith Jr.
2009-01-21  8:26                                               ` Johannes Schindelin
2009-01-21  9:22                                                 ` Thomas Rast
2009-01-21 15:33                                                 ` Boyd Stephen Smith Jr.
2009-01-21  8:25                                             ` [PATCH] color-words: Support diff.color-words config option Johannes Schindelin
2009-01-21 16:09                                               ` Boyd Stephen Smith Jr.
2009-01-21 10:27                                             ` [PATCH] color-words: Support diff.wordregex " Junio C Hamano
2009-01-20 14:38                                         ` [PATCH] diff: Support diff.color-words " Jakub Narebski
2009-01-20  9:58                                       ` [PATCH] Add tests for diff.color-words configuration option Johannes Schindelin
2009-01-20 16:34                                         ` Boyd Stephen Smith Jr.
2009-01-20 16:54                                           ` Johannes Schindelin
2009-01-16 16:11                         ` [PATCH take 3 0/4] color-words improvements Boyd Stephen Smith Jr.
2009-01-14 19:46     ` [PATCH] color-words: make regex configurable via attributes Thomas Rast
2009-01-14 20:12       ` Johannes Schindelin
2009-01-14 20:17         ` Thomas Rast
2009-01-14 22:26         ` [PATCH 1/4] color-words: fix quoting in t4034 Thomas Rast
2009-01-14 22:41           ` Johannes Schindelin
2009-01-14 22:26         ` [PATCH 2/4] color-words: enable REG_NEWLINE to help user Thomas Rast
2009-01-14 22:26         ` [PATCH 3/4] color-words: expand docs with precise semantics Thomas Rast
2009-01-14 22:26         ` [PATCH 4/4] color-words: make regex configurable via attributes Thomas Rast
2009-01-15  1:33           ` Johannes Schindelin
2009-01-15  1:43             ` Johannes Schindelin
2009-01-14 20:04     ` [PATCH take 3 0/4] color-words improvements Thomas Rast
2009-01-14 21:07       ` Johannes Schindelin
2009-01-14 22:37         ` Thomas Rast

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=adf1fd3d0901180729u3da69108i6140aa7f68bda972@mail.gmail.com \
    --to=santi@agolina.net \
    --cc=bss@iguanasuicide.net \
    --cc=git@vger.kernel.org \
    --cc=johannes.schindelin@gmx.de \
    --cc=junio@pobox.com \
    --cc=tlikonen@iki.fi \
    --cc=trast@student.ethz.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).