From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-1?Q?Santi_B=E9jar?= Subject: Re: [PATCH v4 0/7] customizable --color-words Date: Sun, 18 Jan 2009 16:29:54 +0100 Message-ID: References: <1232209788-10408-1-git-send-email-trast@student.ethz.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: git@vger.kernel.org, Junio C Hamano , Johannes Schindelin , "Boyd Stephen Smith Jr." , Teemu Likonen To: Thomas Rast X-From: git-owner@vger.kernel.org Sun Jan 18 16:31:51 2009 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1LOZcg-0003WE-An for gcvg-git-2@gmane.org; Sun, 18 Jan 2009 16:31:38 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933808AbZARPaA convert rfc822-to-quoted-printable (ORCPT ); Sun, 18 Jan 2009 10:30:00 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S933826AbZARP36 (ORCPT ); Sun, 18 Jan 2009 10:29:58 -0500 Received: from mail-bw0-f21.google.com ([209.85.218.21]:50481 "EHLO mail-bw0-f21.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933551AbZARP35 convert rfc822-to-8bit (ORCPT ); Sun, 18 Jan 2009 10:29:57 -0500 Received: by bwz14 with SMTP id 14so7074763bwz.13 for ; Sun, 18 Jan 2009 07:29:54 -0800 (PST) Received: by 10.103.175.8 with SMTP id c8mr2097655mup.117.1232292594491; Sun, 18 Jan 2009 07:29:54 -0800 (PST) In-Reply-To: Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: 2009/1/18 Santi B=E9jar : > 2009/1/17 Thomas Rast : >> Johannes Schindelin wrote: >>> Thomas, could you pick up the patches from my 'my-next' branch and >>> maintain an "official" topic branch? >> >> I cherry-picked the three commits you had there, and rebuilt on top. >> I pushed them to >> >> git://repo.or.cz/git/trast.git tr/word-diff-p2 >> >> again (js/word-diff-p1 again points directly at your half). > > I've tested tr/word-diff-p2 and I have not found any issues. I've eve= n > tested that nothing changed from the tradicional word diff to: > > git log -p --color-words=3D"[^[:space:]]+" > > for the whole git history. > What I tested is that the new code produces the same result for this two commands: git log -p --color-words=3D"[^[:space:]]+" git log -p --color-words The old code produced color codes before and after each word, while the new only at the begining of the color and the end of the color. So they cannot produce the same output but equivalent. Santi