From: "Santi Béjar" <santi@agolina.net>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] commit: more compact summary and without extra quotes
Date: Tue, 20 Jan 2009 01:00:30 +0100 [thread overview]
Message-ID: <adf1fd3d0901191600k6fd7a364h3e55f9600960df03@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.1.00.0901200043400.3586@pacific.mpi-cbg.de>
2009/1/20 Johannes Schindelin <Johannes.Schindelin@gmx.de>:
> Hi,
>
> On Mon, 19 Jan 2009, Santi Béjar wrote:
>
>> Original:
>> [master]: created d9a5491: "foo:bar"
>>
>> While with the patch it becomes:
>> [master d9a5491] foo:bar
>
> Maybe you want to mention that it saves screen estate. After all, the
> commit message is _the_ place to relate your motivation to the gentle
> reader.
I thought it was enough with the "more compact" in the title line.
>
>> As discussed in the git mailing list:
>>
>> http://marc.info/?l=git&m=122765031208922&w=2
>>
>> Signed-off-by: Santi Béjar <santi@agolina.net>
>> ---
>
> You really want to move the link after the ---. I often read commit
> messages off-line, and let me tell you: I am not really happy reading
> links then. Not at all.
OK, less work for me :-)
Santi
next prev parent reply other threads:[~2009-01-20 0:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-19 22:45 [PATCH] commit: more compact summary and without extra quotes Santi Béjar
2009-01-19 23:46 ` Johannes Schindelin
2009-01-20 0:00 ` Santi Béjar [this message]
2009-01-20 3:49 ` Junio C Hamano
2009-01-20 10:10 ` Johannes Schindelin
2009-01-20 10:29 ` Santi Béjar
2009-01-20 4:14 ` Jeff King
2009-01-20 7:04 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adf1fd3d0901191600k6fd7a364h3e55f9600960df03@mail.gmail.com \
--to=santi@agolina.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).