git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Derrick Stolee <stolee@gmail.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	Alex Henrie <alexhenrie24@gmail.com>
Cc: git@vger.kernel.org, dstolee@microsoft.com
Subject: Re: [PATCH v2] commit-graph: remove a duplicate assignment
Date: Fri, 27 Sep 2019 08:45:27 -0400	[thread overview]
Message-ID: <adf9c41a-47af-04dd-d1ed-c181eba80dab@gmail.com> (raw)
In-Reply-To: <nycvar.QRO.7.76.6.1909271418170.15067@tvgsbejvaqbjf.bet>

On 9/27/2019 8:21 AM, Johannes Schindelin wrote:
> Hi,
> 
> 
> On Thu, 26 Sep 2019, Alex Henrie wrote:
> 
>> Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
> 
> Hrm, the commit message should reflect Stolee's careful consideration,
> no? An empty commit message won't be helpful e.g. when cherry-picking on
> top of a branch that already has your v1.

I agree that we need more in the commit messages here. It is
helpful to include _why_ you are doing this. Keep in mind
that your cover letter is not recorded with the commit at all.

Further, when updating a patch series, you should re-roll the
entire series as a v2 (preferably as a reply to the original
series). Keep in mind that this patch should NOT be applied
on top of your other series because then 'g' is not assigned
at all. Mechanically, it COULD apply, but it would break
in tests.

Patches 2 and 3 in your series also have feedback that would
be good to apply in your v2.

Thanks,
-Stolee

      reply	other threads:[~2019-09-27 12:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-27  2:19 [PATCH v2] commit-graph: remove a duplicate assignment Alex Henrie
2019-09-27 12:21 ` Johannes Schindelin
2019-09-27 12:45   ` Derrick Stolee [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=adf9c41a-47af-04dd-d1ed-c181eba80dab@gmail.com \
    --to=stolee@gmail.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=alexhenrie24@gmail.com \
    --cc=dstolee@microsoft.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).