git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Jean-Baptiste Quenot" <jbq@caraldi.com>
To: git@vger.kernel.org
Subject: [PATCH] Do not chop HTML tags in commit search result
Date: Wed, 13 Feb 2008 18:37:24 +0100	[thread overview]
Message-ID: <ae63f8b50802130937mddf9df9re2a95bee44661ee3@mail.gmail.com> (raw)

Hi there,

Thanks for Git! It's a great program.  I encountered an annoying bug
with gitweb 1.5.4.1, when searching for commits, if the search string
is too long, the generated HTML is munged leading to an ill-formed
XHTML document.

Here is the patch, hope it helps:

diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index ae2d057..2c0b990 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -3780,7 +3780,10 @@ sub git_search_grep_body {
                                my $trail = esc_html($3) || "";
                                $trail = chop_str($trail, 30, 10);
                                my $text = "$lead<span
class=\"match\">$match</span>$trail";
-                               print chop_str($text, 80, 5) . "<br/>\n";
+                               # Do not chop $text as match can be
long, and we don't want to
+                               # munge HTML tags!
+                               #print chop_str($text, 80, 5) . "<br/>\n";
+                               print $text . "<br/>\n";
                        }
                }
                print "</td>\n" .
-- 
1.5.4.1-dirty

             reply	other threads:[~2008-02-13 17:38 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-13 17:37 Jean-Baptiste Quenot [this message]
2008-02-13 19:16 ` [PATCH] Do not chop HTML tags in commit search result Jakub Narebski
2008-02-13 19:43 ` Junio C Hamano
2008-02-22 16:33   ` [PATCH] gitweb: Better chopping in commit search results Jakub Narebski
2008-02-22 17:14     ` Junio C Hamano
2008-02-22 17:49       ` Jakub Narebski
2008-02-22 19:14         ` Jakub Narebski
2008-02-23 21:44           ` [RFC/PATCH] gitweb: Option to chop at beginning and in the middle in chop_str Jakub Narebski
2008-02-23 22:04           ` [PATCH] gitweb: Better chopping in commit search results Junio C Hamano
2008-02-23 23:36             ` Jakub Narebski
2008-02-24 13:01           ` [RFC/PATCH v2] gitweb: Option to chop at beginning and in the middle in chop_str Jakub Narebski
2008-02-25  1:46             ` Junio C Hamano
2008-02-25 20:07               ` [RFC/PATCH v3] gitweb: Better cutting matched string and its context Jakub Narebski
2008-02-25 20:18                 ` Junio C Hamano
2008-02-23  9:27     ` [PATCH] gitweb: Better chopping in commit search results Karl Hasselström
2008-02-23 10:20       ` Jakub Narebski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ae63f8b50802130937mddf9df9re2a95bee44661ee3@mail.gmail.com \
    --to=jbq@caraldi.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).