From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fout-a5-smtp.messagingengine.com (fout-a5-smtp.messagingengine.com [103.168.172.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C7A183148C9 for ; Mon, 20 Apr 2026 08:11:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.148 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776672709; cv=none; b=lW9qmt4jAs9EwD7KyZGO8XUdrx+yyATrs/F+rR62IS7NEZCRvfBt3LG9ZEZHawD5VIpn3IEJuWGHtg1FmmaX3tTYdc0uWSm+Pr50lmEG+hVcYpAN5pfOzEHdjHmevmCJy5RH6n5FSKRy6QctFc02QXp4zcqHZsQq/SKGyVgxMnE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776672709; c=relaxed/simple; bh=yvavsz4dJVfOl+YCnCTx08ZHl1AsWQHrjTz5UpHl8GA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=LERo+zxqZ+7NVcPb7GRokmhEHGoyQA6Up6e2iV+IKsyKnE2JwzLK8bFpufRu51WeHQ7mznE2lMLqnx0zgA7a+hH3oRiuy8xfB2PNhRC7r77rRnSTLm8N82bmwVe/ZWfW+7aXinpMtST0qYZ0fxBrMP0yum2MeALOxbTkWgNEePs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=pks.im; spf=pass smtp.mailfrom=pks.im; dkim=pass (2048-bit key) header.d=pks.im header.i=@pks.im header.b=SM0KVlKk; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=jjaEi7Zj; arc=none smtp.client-ip=103.168.172.148 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=pks.im Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pks.im Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=pks.im header.i=@pks.im header.b="SM0KVlKk"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="jjaEi7Zj" Received: from phl-compute-02.internal (phl-compute-02.internal [10.202.2.42]) by mailfout.phl.internal (Postfix) with ESMTP id 0C8EFEC011D; Mon, 20 Apr 2026 04:11:47 -0400 (EDT) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-02.internal (MEProxy); Mon, 20 Apr 2026 04:11:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pks.im; h=cc:cc :content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1776672707; x=1776759107; bh=yvavsz4dJV fOl+YCnCTx08ZHl1AsWQHrjTz5UpHl8GA=; b=SM0KVlKkbZ9XAeneK+zzpgrW4K TNt9f5eNNz1WkXKyD6h2P6HDvf/5ZVvdEt85No1UP8QmsLZgEKeSxkCrf6CFfqRL WfN8aU7+2FWreeKIM8zLlXsZw0vahAi5W8C8OJ7SIWWJI15LdaJOnmYjQa+P8tZ/ NxqCft/x6yN+xvRI15ibbPNq2zlnB7j2beVyerbFV3xjJUMv89egJ7E/h/HFUcj6 UbHc9N30ZchZAVO7RfmqOvnZtZzgirrto/rKldwMel+1iPsmN/dU9W0CnY81Rm/I d8IO6o26AnvlsXxegvMySgJKAxQzTMbgbFZCGBR4tWU/+bUhywvUvPP1GHwA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1776672707; x=1776759107; bh=yvavsz4dJVfOl+YCnCTx08ZHl1AsWQHrjTz 5UpHl8GA=; b=jjaEi7Zjre5SwABKLWl6slgz1Vwo5hpuzwJ+eq+XY/gGDLgwv1O r2D1u0oOk18oAtsvQQb/EEwOfvhGHfvJM8TrkR9sNajBJX3qG8Zto8ugGx87pSjB 6gyn9hJxG4eBlMKDNz3WfIsvExg4rFBkxskaByS1qOB5duAyhy6vwi8uYQ/u25cr HKduLQ7gkGy4HkuxK6lfUgrYbHrlKJj9SgeFpuozFODbtOwZSE/hkuwyFUFu4i1p vB2/PwfICTDcYWi9kgsQ+Bsxm8gz0zcIZX7Du09ei7ru1VZRLd+j8OY2/dsQVQLT UjA2srLp6lBiHkCIeuo6oVk9A12rFnzEmZQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefhedrtddtgdehkedtudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjug hrpeffhffvvefukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefrrghtrhhitghk ucfuthgvihhnhhgrrhguthcuoehpshesphhkshdrihhmqeenucggtffrrghtthgvrhhnpe evkeekfffhiedtleduiefgjedttedvledvudehgfeugedugffhueekhfejvdektdenucev lhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehpshesphhksh drihhmpdhnsggprhgtphhtthhopeegpdhmohguvgepshhmthhpohhuthdprhgtphhtthho pehgihhtghhithhgrggughgvthesghhmrghilhdrtghomhdprhgtphhtthhopehgihhtse hvghgvrhdrkhgvrhhnvghlrdhorhhgpdhrtghpthhtohepshhtohhlvggvsehgmhgrihhl rdgtohhmpdhrtghpthhtohepghhithhsthgvrhesphhosghogidrtghomh X-ME-Proxy: Feedback-ID: i197146af:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 20 Apr 2026 04:11:45 -0400 (EDT) Received: by mail (OpenSMTPD) with ESMTPSA id 09ae263e (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Mon, 20 Apr 2026 08:11:44 +0000 (UTC) Date: Mon, 20 Apr 2026 10:11:40 +0200 From: Patrick Steinhardt To: Derrick Stolee via GitGitGadget Cc: git@vger.kernel.org, gitster@pobox.com, Derrick Stolee Subject: Re: [PATCH v2 3/7] transport: rename negotiation_tips Message-ID: References: <0f89665aee679636d1c6ea801e54b2b53161d4df.1776266066.git.gitgitgadget@gmail.com> Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0f89665aee679636d1c6ea801e54b2b53161d4df.1776266066.git.gitgitgadget@gmail.com> On Wed, Apr 15, 2026 at 03:14:22PM +0000, Derrick Stolee via GitGitGadget wrote: > diff --git a/builtin/fetch.c b/builtin/fetch.c > index 3bcb0c9686..4c3c5f2faa 100644 > --- a/builtin/fetch.c > +++ b/builtin/fetch.c Don't we want to also rename the local `negotiation_tip` variable in `cmd_fetch()`? Patrick