From: Patrick Steinhardt <ps@pks.im>
To: Siddharth Shrimali <r.siddharth.shrimali@gmail.com>
Cc: git@vger.kernel.org, gitster@pobox.com, abdobngad@gmail.com,
bence@ferdinandy.com, john.a.passaro@gmail.com
Subject: Re: [PATCH v2 0/3] t7004: cleanup and modernize brittle tests
Date: Tue, 21 Apr 2026 07:38:59 +0200 [thread overview]
Message-ID: <aecNc-BNwaqFlg5c@pks.im> (raw)
In-Reply-To: <20260421053334.5414-1-r.siddharth.shrimali@gmail.com>
On Tue, Apr 21, 2026 at 11:03:31AM +0530, Siddharth Shrimali wrote:
> This patch series addresses brittle testing patterns in t7004-tag.sh.
>
> In this second version, the first patch has been updated to follow
> Junio's "belt-and-suspenders" suggestion. Instead of simply removing
> the tag count check, it now uses 'test_cmp' to verify that the repository
> state remains unchanged after failed tag creation attempts. This
> maintains verification while removing the reliance on a hardcoded
> global tag count.
>
> Subsequent patches continue to modernize the script by removing
> hardcoded global state and replacing subshell patterns that could
> otherwise suppress Git exit codes, ensuring that crashes (like
> segmentation faults) are properly detected.
>
> Thanks to Patrick and Junio for the feedback on v1 regarding
> state verification.
Thanks, this version looks good to me!
Patrick
prev parent reply other threads:[~2026-04-21 5:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-14 14:18 [PATCH 0/3] t7004: cleanup and modernize brittle tests Siddharth Shrimali
2026-04-14 14:18 ` [PATCH 1/3] t7004: drop hardcoded tag count in invalid name test Siddharth Shrimali
2026-04-14 16:54 ` Junio C Hamano
2026-04-20 7:13 ` Patrick Steinhardt
2026-04-14 14:18 ` [PATCH 2/3] t7004: dynamically grab expected state in tests Siddharth Shrimali
2026-04-14 17:00 ` Junio C Hamano
2026-04-14 14:18 ` [PATCH 3/3] t7004: avoid subshells to capture git exit codes Siddharth Shrimali
2026-04-21 5:33 ` [PATCH v2 0/3] t7004: cleanup and modernize brittle tests Siddharth Shrimali
2026-04-21 5:33 ` [PATCH v2 1/3] t7004: drop hardcoded tag count for state verification Siddharth Shrimali
2026-04-21 5:33 ` [PATCH v2 2/3] t7004: dynamically grab expected state in tests Siddharth Shrimali
2026-04-21 5:33 ` [PATCH v2 3/3] t7004: avoid subshells to capture git exit codes Siddharth Shrimali
2026-04-21 5:38 ` Patrick Steinhardt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aecNc-BNwaqFlg5c@pks.im \
--to=ps@pks.im \
--cc=abdobngad@gmail.com \
--cc=bence@ferdinandy.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=john.a.passaro@gmail.com \
--cc=r.siddharth.shrimali@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox