From: "Rubén Justo" <rjusto@gmail.com>
To: Isoken June Ibizugbe via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org
Cc: Isoken June Ibizugbe <isokenjune@gmail.com>
Subject: Re: [PATCH 0/2] [Outreachy][PATCH v2] branch.c: adjust error messages to coding guidelines
Date: Fri, 13 Oct 2023 20:30:35 +0200 [thread overview]
Message-ID: <aed9523e-0ce9-49f6-bdda-90fd1e275691@gmail.com> (raw)
In-Reply-To: <pull.1590.git.git.1697211227.gitgitgadget@gmail.com>
On 13-oct-2023 15:33:45, Isoken June Ibizugbe via GitGitGadget wrote:
> As per the CodingGuidelines document, it is recommended that a single-line
> message provided to error messages such as die(), error() and warning(),
> should start with a lowercase letter and should not end with a period.
>
> Signed-off-by: Isoken June Ibizugbe isokenjune@gmail.com
>
> Isoken June Ibizugbe (2):
> branch.c: ammend error messages for die()
> branch.c: adjust error messages to coding guidelines
I don't understand why two commits. Maybe it was unintentional and you
want to merge all changes into one commit, using git rebase.
>
> builtin/branch.c | 66 ++++++++++++++++++++++++------------------------
> 1 file changed, 33 insertions(+), 33 deletions(-)
You still need to adjust the tests. Take a look at:
https://github.com/git/git/actions/runs/6509642887/job/17681596358
prev parent reply other threads:[~2023-10-13 18:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-13 15:33 [PATCH 0/2] [Outreachy][PATCH v2] branch.c: adjust error messages to coding guidelines Isoken June Ibizugbe via GitGitGadget
2023-10-13 15:33 ` [PATCH 1/2] branch.c: ammend error messages for die() Isoken June Ibizugbe via GitGitGadget
2023-10-13 15:33 ` [PATCH 2/2] branch.c: adjust error messages to coding guidelines Isoken June Ibizugbe via GitGitGadget
2023-10-13 15:40 ` Isoken Ibizugbe
2023-10-13 18:29 ` Junio C Hamano
2023-10-13 18:25 ` Rubén Justo
2023-10-13 18:30 ` Rubén Justo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aed9523e-0ce9-49f6-bdda-90fd1e275691@gmail.com \
--to=rjusto@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=isokenjune@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).