From: Patrick Steinhardt <ps@pks.im>
To: Koutian Wu via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Koutian Wu <ktwu01@gmail.com>
Subject: Re: [PATCH] gitattributes: fix eol attribute for Perl scripts
Date: Mon, 15 Jun 2026 09:22:06 +0200 [thread overview]
Message-ID: <ai-oHtHFsyhnLDWA@pks.im> (raw)
In-Reply-To: <pull.2151.git.1781497525828.gitgitgadget@gmail.com>
On Mon, Jun 15, 2026 at 04:25:25AM +0000, Koutian Wu via GitGitGadget wrote:
> From: ktwu01 <ktwu01@gmail.com>
>
> The *.pl pattern currently sets eof=lf, which is not a built-in
> attribute used for line-ending normalization.
>
> Use eol=lf instead, matching the neighboring *.perl and *.pm rules, so
> Perl scripts are checked out with LF line endings.
>
> Signed-off-by: ktwu01 <ktwu01@gmail.com>
The Signed-off-by and commit author should use your real name, if
possible. See [1].
> diff --git a/.gitattributes b/.gitattributes
> index 556322be01..26490ad60a 100644
> --- a/.gitattributes
> +++ b/.gitattributes
> @@ -2,7 +2,7 @@
> *.[ch] whitespace=indent,trail,space,incomplete diff=cpp
> *.sh whitespace=indent,trail,space,incomplete text eol=lf
> *.perl text eol=lf diff=perl
> -*.pl text eof=lf diff=perl
> +*.pl text eol=lf diff=perl
> *.pm text eol=lf diff=perl
> *.py text eol=lf diff=python
> *.bat text eol=crlf
Yeah, this looks obviously correct to me. Thanks for the fix!
Patrick
[1]: https://git-scm.com/docs/SubmittingPatches#real-name
next prev parent reply other threads:[~2026-06-15 7:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-15 4:25 [PATCH] gitattributes: fix eol attribute for Perl scripts Koutian Wu via GitGitGadget
2026-06-15 7:22 ` Patrick Steinhardt [this message]
2026-06-15 7:53 ` [PATCH v2] " Koutian Wu via GitGitGadget
2026-06-15 8:37 ` Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ai-oHtHFsyhnLDWA@pks.im \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=ktwu01@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox