From: Weijie Yuan <wy@wyuan.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, ps@pks.im
Subject: Re: [RFC PATCH 2/2] doc: advise batching patch rerolls
Date: Sun, 14 Jun 2026 01:05:04 +0800 [thread overview]
Message-ID: <ai2NwMS-i_UTWR5T@wyuan.org> (raw)
In-Reply-To: <xmqqwlw2e8dc.fsf@gitster.g>
On Sat, Jun 13, 2026 at 09:02:39AM -0700, Junio C Hamano wrote:
> Weijie Yuan <wy@wyuan.org> writes:
>
> > Contributors often need guidance on how quickly to send later iterations
> > of a patch series. Add a rough default of no more than one new version
> > of the same series per day so feedback can be batched and reviewers have
> > time to comment.
> >
> > Mention factors that can affect the timing, such as series size, review
> > depth, substantial rework, and how close the topic is to being accepted.
>
> Another good thing to discourage yourself from rerolling too quickly
> is that such a practice forces you to think twice and be very
> careful before sending patches out. As you have only one chance to
> get it right before, say, 24 hours, you'd want to make sure that you
> would not distract your reviewers with stupid typoes, off-by-one
> errors, and such, and concentrate their reviews more on what matters
> more, i.e., the higher level design, choice of algorithms, etc.
>
> > +This consideration applies not only when going from the initial patch to v2, but
> > +also to later iterations of the same series. There is no fixed rule for how long
> > +to wait before sending a new version. A useful default is to send at most one
> > +new version of the same patch series per day. This gives multiple reviewers time
> > +to comment, lets you batch feedback together, and gives you time to think
> > +through the comments you received.
>
> And the 24-hour gives equal chance to comment on your patches to
> anybody no matter where they live ;-)
Thanks for your comments above! Let me think about how to integrate
these contents with the patch.
> I see you CC'ed Patrick, and I am sure he'll give us more useful
> suggestions than I do here ;-)
This is his practical advice, and I just stole Patrick´s wording, to be
fair ;-) so of course I should CC him and let him know I am a wording
thief :-P, hope it wouldn't disturb him ;-)
Thank you very much.
prev parent reply other threads:[~2026-06-13 17:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-13 14:08 [RFC PATCH 0/2] doc: clarify review replies and reroll timing Weijie Yuan
2026-06-13 14:08 ` [RFC PATCH 1/2] doc: encourage review replies before rerolling Weijie Yuan
2026-06-13 14:09 ` [RFC PATCH 2/2] doc: advise batching patch rerolls Weijie Yuan
2026-06-13 16:02 ` Junio C Hamano
2026-06-13 17:05 ` Weijie Yuan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ai2NwMS-i_UTWR5T@wyuan.org \
--to=wy@wyuan.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox