From: Patrick Steinhardt <ps@pks.im>
To: Karthik Nayak <karthik.188@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v2 01/18] odb/source-loose: move loose source into "odb/" subsystem
Date: Wed, 3 Jun 2026 18:15:36 +0200 [thread overview]
Message-ID: <aiBTKKtj-evY4Xzx@pks.im> (raw)
In-Reply-To: <CAOLa=ZSRQpAMGDwfP8vAiJi+G=WPW=YPrrs21pVt1O4j2Uh-zQ@mail.gmail.com>
On Wed, Jun 03, 2026 at 06:07:14AM -0700, Karthik Nayak wrote:
> Patrick Steinhardt <ps@pks.im> writes:
>
> > In subsequent patches we'll be turning `struct odb_source_loose` into a
> > proper `struct odb_source`. As a first step towards this goal, move its
>
> s/its/this?
>
> > struct out of "object-file.c" and into "odb/source-loose.c".
Hm. I agree it would read more naturally with "this" instead of "its",
but I'm not even sure whether it's wrong. In any case, I'd prefer to not
reroll this topic for this one nit, if that's alright with you.
Thanks!
Patrick
next prev parent reply other threads:[~2026-06-03 16:15 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-21 8:22 [PATCH 00/18] odb: make loose object source a proper `struct odb_source` Patrick Steinhardt
2026-05-21 8:22 ` [PATCH 01/18] odb/source-loose: move loose source into "odb/" subsystem Patrick Steinhardt
2026-05-21 8:22 ` [PATCH 02/18] odb/source-loose: store pointer to "files" instead of generic source Patrick Steinhardt
2026-05-21 8:22 ` [PATCH 03/18] odb/source-loose: start converting to a proper `struct odb_source` Patrick Steinhardt
2026-05-21 15:49 ` Junio C Hamano
2026-05-21 8:22 ` [PATCH 04/18] odb/source-loose: wire up `reprepare()` callback Patrick Steinhardt
2026-05-21 8:22 ` [PATCH 05/18] odb/source-loose: wire up `close()` callback Patrick Steinhardt
2026-05-21 8:22 ` [PATCH 06/18] odb/source-loose: wire up `read_object_info()` callback Patrick Steinhardt
2026-05-21 8:22 ` [PATCH 07/18] odb/source-loose: wire up `read_object_stream()` callback Patrick Steinhardt
2026-05-21 8:22 ` [PATCH 08/18] odb/source-loose: wire up `for_each_object()` callback Patrick Steinhardt
2026-05-21 8:22 ` [PATCH 09/18] odb/source-loose: wire up `find_abbrev_len()` callback Patrick Steinhardt
2026-05-21 8:22 ` [PATCH 10/18] odb/source-loose: wire up `count_objects()` callback Patrick Steinhardt
2026-05-21 8:22 ` [PATCH 11/18] odb/source-loose: drop `odb_source_loose_has_object()` Patrick Steinhardt
2026-05-21 8:22 ` [PATCH 12/18] odb/source-loose: wire up `freshen_object()` callback Patrick Steinhardt
2026-05-21 8:22 ` [PATCH 13/18] loose: refactor object map to operate on `struct odb_source_loose` Patrick Steinhardt
2026-05-21 8:22 ` [PATCH 14/18] odb/source-loose: wire up `write_object()` callback Patrick Steinhardt
2026-05-21 8:22 ` [PATCH 15/18] object-file: refactor writing objects to use loose source Patrick Steinhardt
2026-05-21 8:22 ` [PATCH 16/18] odb/source-loose: wire up `write_object_stream()` callback Patrick Steinhardt
2026-05-21 17:49 ` Junio C Hamano
2026-05-22 6:12 ` Patrick Steinhardt
2026-05-21 8:22 ` [PATCH 17/18] odb/source-loose: stub out remaining callbacks Patrick Steinhardt
2026-05-21 8:22 ` [PATCH 18/18] odb/source-loose: drop pointer to the "files" source Patrick Steinhardt
2026-06-01 8:20 ` [PATCH v2 00/18] odb: make loose object source a proper `struct odb_source` Patrick Steinhardt
2026-06-01 8:20 ` [PATCH v2 01/18] odb/source-loose: move loose source into "odb/" subsystem Patrick Steinhardt
2026-06-03 13:07 ` Karthik Nayak
2026-06-03 16:15 ` Patrick Steinhardt [this message]
2026-06-01 8:20 ` [PATCH v2 02/18] odb/source-loose: store pointer to "files" instead of generic source Patrick Steinhardt
2026-06-01 8:20 ` [PATCH v2 03/18] odb/source-loose: start converting to a proper `struct odb_source` Patrick Steinhardt
2026-06-01 8:20 ` [PATCH v2 04/18] odb/source-loose: wire up `reprepare()` callback Patrick Steinhardt
2026-06-01 8:20 ` [PATCH v2 05/18] odb/source-loose: wire up `close()` callback Patrick Steinhardt
2026-06-01 8:20 ` [PATCH v2 06/18] odb/source-loose: wire up `read_object_info()` callback Patrick Steinhardt
2026-06-01 8:20 ` [PATCH v2 07/18] odb/source-loose: wire up `read_object_stream()` callback Patrick Steinhardt
2026-06-01 8:20 ` [PATCH v2 08/18] odb/source-loose: wire up `for_each_object()` callback Patrick Steinhardt
2026-06-01 8:20 ` [PATCH v2 09/18] odb/source-loose: wire up `find_abbrev_len()` callback Patrick Steinhardt
2026-06-01 8:20 ` [PATCH v2 10/18] odb/source-loose: wire up `count_objects()` callback Patrick Steinhardt
2026-06-01 8:20 ` [PATCH v2 11/18] odb/source-loose: drop `odb_source_loose_has_object()` Patrick Steinhardt
2026-06-01 8:20 ` [PATCH v2 12/18] odb/source-loose: wire up `freshen_object()` callback Patrick Steinhardt
2026-06-01 8:20 ` [PATCH v2 13/18] loose: refactor object map to operate on `struct odb_source_loose` Patrick Steinhardt
2026-06-01 8:20 ` [PATCH v2 14/18] odb/source-loose: wire up `write_object()` callback Patrick Steinhardt
2026-06-01 8:20 ` [PATCH v2 15/18] object-file: refactor writing objects to use loose source Patrick Steinhardt
2026-06-01 8:20 ` [PATCH v2 16/18] odb/source-loose: wire up `write_object_stream()` callback Patrick Steinhardt
2026-06-01 8:20 ` [PATCH v2 17/18] odb/source-loose: stub out remaining callbacks Patrick Steinhardt
2026-06-01 8:20 ` [PATCH v2 18/18] odb/source-loose: drop pointer to the "files" source Patrick Steinhardt
2026-06-01 21:33 ` [PATCH 00/18] odb: make loose object source a proper `struct odb_source` Junio C Hamano
2026-06-01 22:14 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aiBTKKtj-evY4Xzx@pks.im \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=karthik.188@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox