Re: [PATCH v2 0/8] setup: centralize object database creation

[Patrick Steinhardt <ps@pks.im>]

On Wed, Jun 03, 2026 at 06:04:01AM -0700, Karthik Nayak wrote:
> Patrick Steinhardt <ps@pks.im> writes:
> 
> > Hi,
> >
> > this small patch series refactors the logic for how we discover and
> > configure repositories. Most importantly, this involves the following
> > two steps:
> >
> >   1. We unify the logic to apply the repository format, which is
> >      currently open-coded across multiple sites. These sites have
> >      already diverged, where some repository extensions are not
> >      consistently applied.
> >
> >   2. We then centralize creation of the object database to happen at the
> >      same time we apply the repository format.
> >
> > The end result is that we apply the repository format exactly once, and
> > that's also the point in time where we can finalize the setup of the
> > repo's data structures as we know about all details of the repo at that
> > time. Ultimately, this makes it trivial to introduce the "objectStorage"
> > extension, even though that's not part of this patch series.
> >
> > The series is built on top of aec3f58750 (Sync with 'maint', 2026-05-21)
> > with ps/setup-wo-the-repository at df69f40c34 (setup: stop using
> > `the_repository` in `init_db()`, 2026-05-19) merged into it.
> >
> 
> Apart from some questions/comments, the series looks good. Thanks

Thanks for your review! Will send v3 in a bit.

Patrick