Git development
 help / color / mirror / Atom feed
From: Weijie Yuan <wy@wyuan.org>
To: Tuomas Ahola <taahol@utu.fi>,
	Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] docs: fix typos
Date: Sat, 6 Jun 2026 02:26:08 +0800	[thread overview]
Message-ID: <aiMT-U9YhMNzXEkB@wyuan.org> (raw)
In-Reply-To: <20260604165557.MWQuu%taahol@utu.fi>

On Thu, Jun 04, 2026 at 07:55:57PM +0300, Tuomas Ahola wrote:
> "Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail.com> wrote:
> 
> > On Thu, Jun 4, 2026, at 15:14, Tuomas Ahola wrote:
> > > [PATCH] docs: fix typos
> > 
> > The area `docs` isn´t correct since you are also changing comments in
> > source files.
> > 
> > `*` could be used (as in a wildcard). Other people have used other
> > things for "treewide" changes.
> > 
> 
> Hmm, I took that from the other typofix patches we have currently in `seen`.

Hi all,

Yup, my patch 8570d9ba31 (Merge branch 'wy/docs-typofixes' into seen, 2026-06-04)
used "docs" as the scope of the commit message.

I thought for a while what would be the preferred scope for a typofixes
commit that touches a quite wide range of the tree. And I didn't know we
could use "*".

On the one hand, I would rather let the typofix thing be simple and easy
in one commit, since the actual changes were sort of logically unified.
On the other hand, splitting them apart makes it easier to name the
scope of each commit, while it would make much "meaningless" noise. So I
was torn at that time.

"Luckily", Junio didn't say something about that, and my topic is
waiting for more comments. So it just happens when I am struggling with
re-roll it or not, I saw this thread. Therefore, could you please also
raise it again in my topic in order to  give it a final decision? (Or
start a new thread as my patch is actually in Andrew's thread, really
sorry Andrew)

Message-ID of my previous patch:
<7b502e20e9495cd4720496bd6738a1fbeb453410.1780041658.git.wy@wyuan.org>

Thanks!

      reply	other threads:[~2026-06-05 18:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-04 13:14 [PATCH] docs: fix typos Tuomas Ahola
2026-06-04 14:45 ` Kristoffer Haugsbakk
2026-06-04 16:55   ` Tuomas Ahola
2026-06-05 18:26     ` Weijie Yuan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aiMT-U9YhMNzXEkB@wyuan.org \
    --to=wy@wyuan.org \
    --cc=git@vger.kernel.org \
    --cc=kristofferhaugsbakk@fastmail.com \
    --cc=taahol@utu.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox