Git development
 help / color / mirror / Atom feed
From: Patrick Steinhardt <ps@pks.im>
To: "SZEDER Gábor" <szeder.dev@gmail.com>
Cc: Weijie Yuan <wy@wyuan.org>, Tuomas Ahola <taahol@utu.fi>,
	git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 1/2] b4: introduce configuration for the Git project
Date: Mon, 8 Jun 2026 08:48:44 +0200	[thread overview]
Message-ID: <aiZlzBEB_AnQ4mVK@pks.im> (raw)
In-Reply-To: <aiAK9eLvew+mgWt+@szeder.dev>

On Wed, Jun 03, 2026 at 01:07:33PM +0200, SZEDER Gábor wrote:
> On Wed, Jun 03, 2026 at 08:55:04AM +0200, Patrick Steinhardt wrote:
> > On Wed, Jun 03, 2026 at 10:12:22AM +0800, Weijie Yuan wrote:
> > > On Tue, Jun 02, 2026 at 08:09:55PM +0300, Tuomas Ahola wrote:
> > > > Huh?  Doesn't MyFirstContribution speak *against* shallow threading?
> > > >
> > > > 	        [...]  make sure to replace it with the correct Message-ID for your
> > > > 	**previous cover letter** - that is, if you're sending v2, use the Message-ID
> > > > 	from v1; if you're sending v3, use the Message-ID from v2.
> > > 
> > > I don't get it. Doesn't shallow threading means every following patches
> > > are replying to the cover letter? Replying to the previous one is
> > > --chain-reply-to, if I'm not mistaken.
> > 
> > Shallow threading basically means that all patches are sent as a
> > response to the current cover letter, and the current cover letter is
> > always attached to the cover letter of the _first_ version.
> 
> No, in Git shallow threading means that all patches are sent as a
> respose to the current cover letter, period.  It has nothing to do
> with whether the current cover letter is sent as a reply to the cover
> letter of the first or the previous version.
> 
> > So this quote is definitely at odds with the configuration I have
> > proposed. It's actually quite surprising to me that we recommend deep
> > threading -- I personally find it extremely hard to navigate as the
> > nesting eventually gets way too deep.
> 
> Deep threading means that every mail is a reply to the previous one.
> Again, it has nothing to do with the relation of the current cover
> letter and the previous cover letters.
> 
> Therefore, we do not recommend deep threading.

Oh, you're right of course. I totally forgot that we even had this
style.

Patrick

  parent reply	other threads:[~2026-06-08  6:48 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-02 11:59 [PATCH 0/2] Documentation: recommend the use of b4 Patrick Steinhardt
2026-06-02 11:59 ` [PATCH 1/2] b4: introduce configuration for the Git project Patrick Steinhardt
2026-06-02 13:32   ` Junio C Hamano
2026-06-02 14:56     ` Patrick Steinhardt
2026-06-02 16:23     ` Ramsay Jones
2026-06-03  2:59       ` Junio C Hamano
2026-06-03  6:52         ` Patrick Steinhardt
2026-06-02 17:09   ` Tuomas Ahola
2026-06-03  2:12     ` Weijie Yuan
2026-06-03  6:55       ` Patrick Steinhardt
2026-06-03  7:50         ` Weijie Yuan
2026-06-03  9:51           ` Weijie Yuan
2026-06-03 11:07         ` SZEDER Gábor
2026-06-03 12:23           ` Weijie Yuan
2026-06-03 13:30           ` Tuomas Ahola
2026-06-04  1:11           ` Junio C Hamano
2026-06-08  6:48             ` Patrick Steinhardt
2026-06-08  6:48           ` Patrick Steinhardt [this message]
2026-06-02 11:59 ` [PATCH 2/2] Documentation/MyFirstContribution: recommend the use of b4 Patrick Steinhardt
2026-06-02 16:09   ` Weijie Yuan
2026-06-03  6:54     ` Patrick Steinhardt
2026-06-03  7:53       ` Weijie Yuan
2026-06-03  8:00         ` Weijie Yuan
2026-06-03  6:58 ` [PATCH v2 0/3] Documentation: " Patrick Steinhardt
2026-06-03  6:58   ` [PATCH v2 1/3] Documentation/MyFirstContribution: recommend shallow threading Patrick Steinhardt
2026-06-03 10:01     ` Tuomas Ahola
2026-06-08  6:48       ` Patrick Steinhardt
2026-06-03 10:29     ` Weijie Yuan
2026-06-08  6:48       ` Patrick Steinhardt
2026-06-08  8:31         ` Weijie Yuan
2026-06-03 20:09     ` Kristoffer Haugsbakk
2026-06-08  6:48       ` Patrick Steinhardt
2026-06-03  6:59   ` [PATCH v2 2/3] Documentation/MyFirstContribution: recommend the use of b4 Patrick Steinhardt
2026-06-04  5:25     ` Toon Claes
2026-06-08  6:48       ` Patrick Steinhardt
2026-06-03  6:59   ` [PATCH v2 3/3] b4: introduce configuration for the Git project Patrick Steinhardt
2026-06-03 13:58     ` Toon Claes
2026-06-08  6:48       ` Patrick Steinhardt
2026-06-08  6:49 ` [PATCH v3 0/3] Documentation: recommend the use of b4 Patrick Steinhardt
2026-06-08  6:49   ` [PATCH v3 1/3] MyFirstContribution: recommend shallow threading of cover letters Patrick Steinhardt
2026-06-08  6:49   ` [PATCH v3 2/3] MyFirstContribution: recommend the use of b4 Patrick Steinhardt
2026-06-08  6:49   ` [PATCH v3 3/3] b4: introduce configuration for the Git project Patrick Steinhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aiZlzBEB_AnQ4mVK@pks.im \
    --to=ps@pks.im \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=szeder.dev@gmail.com \
    --cc=taahol@utu.fi \
    --cc=wy@wyuan.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox