Re: [PATCH v3 15/17] odb/source-packed: stub out remaining functions

[Patrick Steinhardt <ps@pks.im>]

On Thu, Jun 18, 2026 at 10:59:32AM -0700, Junio C Hamano wrote:
> Patrick Steinhardt <ps@pks.im> writes:
> 
> Just FYI (i.e. nothing wrong in this patch)
> 
> > +static int odb_source_packed_write_object(struct odb_source *source UNUSED,
> > +					  const void *buf UNUSED,
> > +					  unsigned long len UNUSED,
> 
> The type of this parameter will become size_t via another topic in
> flight; I prepared an evil merge to address it (otherwise winbuild
> would barf, as expected).
> 
> -- >8 --
> Author: Junio C Hamano <gitster@pobox.com>
> Date:   Thu Jun 18 10:49:10 2026 -0700
> 
>     merge-fix po/hash-object-size-t vs ps/odb-source-packed
> 
> diff --git a/odb/source-packed.c b/odb/source-packed.c
> index 42c28fba0e..decc81aa52 100644
> --- a/odb/source-packed.c
> +++ b/odb/source-packed.c
> @@ -503,7 +503,7 @@ static int odb_source_packed_freshen_object(struct odb_source *source,
>  
>  static int odb_source_packed_write_object(struct odb_source *source UNUSED,
>  					  const void *buf UNUSED,
> -					  unsigned long len UNUSED,
> +					  size_t len UNUSED,
>  					  enum object_type type UNUSED,
>  					  struct object_id *oid UNUSED,
>  					  struct object_id *compat_oid UNUSED,

Thanks for the heads up, the change looks obviously correct to me. I'm
also happy to send a rebased version -- just give me a nudge and I'll do
that.

Patrick