Re: [PATCH v6 09/10] builtin/history: split handling of ref updates into two phases

[Patrick Steinhardt <ps@pks.im>]

On Thu, Jun 25, 2026 at 03:37:42PM +0200, Christian Couder wrote:
> On Mon, Jun 15, 2026 at 3:56 PM Patrick Steinhardt <ps@pks.im> wrote:
> 
> > @@ -414,14 +389,43 @@ static int handle_reference_updates(struct rev_info *revs,
> >                     !detached_head)
> >                         continue;
> >
> > +               ALLOC_GROW(result->updates, result->updates_nr + 1, result->updates_alloc);
> > +               result->updates[result->updates_nr].refname = xstrdup(decoration->name);
> > +               result->updates[result->updates_nr].old_oid = original->object.oid;
> > +               result->updates[result->updates_nr].new_oid = rewritten->object.oid;
> > +               result->updates_nr++;
> 
> It looks like this duplicates what replay_result_queue_update() from
> replay.c does.

It indeed is. That function is internal to "replay.c" though. We could
expose it, but I wonder whether that's worth it. Goes looking... you
know, let me just do it.

Thanks!

Patrick