From: Patrick Steinhardt <ps@pks.im>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Bryan B. Lima" <bblima@usp.br>,
git@vger.kernel.org, gustavoscorrea@usp.br,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: Re: [PATCH] submodule absorbgitdirs tests: use test_* helper functions
Date: Wed, 1 Jul 2026 10:04:45 +0200 [thread overview]
Message-ID: <akTKHfKPsP3-Rn31@pks.im> (raw)
In-Reply-To: <xmqqmrwbsybn.fsf@gitster.g>
On Tue, Jun 30, 2026 at 11:00:28AM -0700, Junio C Hamano wrote:
> "Bryan B. Lima" <bblima@usp.br> writes:
>
> > Use modern helper functions from test-lib-functions.sh to provide nice error messages.
> >
> > Signed-off-by: Bryan B. Lima <bblima@usp.br>
> > Co-authored-by: Gustavo S. Correa <gustavoscorrea@usp.br>
> > Signed-off-by: Gustavo S. Correa <gustavoscorrea@usp.br>
> > ---
> > t/t7412-submodule-absorbgitdirs.sh | 22 +++++++++++-----------
> > 1 file changed, 11 insertions(+), 11 deletions(-)
>
> Welcome to the Git development community.
Welcome indeed!
> It is rare, but it happens from time to time, that we see a patch by
> somebody we haven't seen on this list, and the patch looks perfect.
> Very delighted.
Sorry to spoil it: the order of SOBs is incorrect. The patch is authored
by Bryan, so that signoff needs to come last.
The patch itself looks good though, thanks!
Patrick
prev parent reply other threads:[~2026-07-01 8:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-30 2:02 [PATCH] submodule absorbgitdirs tests: use test_* helper functions Bryan B. Lima
2026-06-30 18:00 ` Junio C Hamano
2026-07-01 8:04 ` Patrick Steinhardt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=akTKHfKPsP3-Rn31@pks.im \
--to=ps@pks.im \
--cc=avarab@gmail.com \
--cc=bblima@usp.br \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=gustavoscorrea@usp.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox