From: "brian m. carlson" <sandals@crustytoothpaste.net>
To: Jan Palus <jpalus@fastmail.com>
Cc: git@vger.kernel.org
Subject: Re: RUST_LIB dependency on LIB_FILE in Makefile
Date: Wed, 1 Jul 2026 16:28:19 +0000 [thread overview]
Message-ID: <akVAI4dJlC_ZdguT@fruit.crustytoothpaste.net> (raw)
In-Reply-To: <akO9JTUIlHqBrgny@pine.grzadka>
[-- Attachment #1: Type: text/plain, Size: 782 bytes --]
On 2026-06-30 at 13:07:29, Jan Palus wrote:
> According to Makefile $(RUST_LIB) target depends on $(LIB_FILE):
>
> $(RUST_LIB): Cargo.toml $(RUST_SOURCES) $(LIB_FILE)
>
> but is that really the case? As far as I can tell $(RUST_LIB) does not
> use $(LIB_FILE) in any way and there's no such dependency in
> meson.build.
It is really the case. The Rust code in `src/hash.rs` requires C
functions in `libgit.a`. The tests won't run via `cargo test` if it's
not built. There will be additional uses of this code in the relatively
near future and they will definitely require calls to `libgit.a`.
The lack of Meson functionality is likely an oversight and I'm sure a
patch to fix that would be accepted.
--
brian m. carlson (they/them)
Toronto, Ontario, CA
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 325 bytes --]
prev parent reply other threads:[~2026-07-01 16:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-30 13:07 RUST_LIB dependency on LIB_FILE in Makefile Jan Palus
2026-07-01 16:28 ` brian m. carlson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=akVAI4dJlC_ZdguT@fruit.crustytoothpaste.net \
--to=sandals@crustytoothpaste.net \
--cc=git@vger.kernel.org \
--cc=jpalus@fastmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox