From: Taylor Blau <ttaylorr@openai.com>
To: tnyman@openai.com
Cc: git@vger.kernel.org, Derrick Stolee <stolee@gmail.com>,
Taylor Blau <me@ttaylorr.com>, Jeff King <peff@peff.net>,
Victoria Dye <vdye@github.com>
Subject: Re: [PATCH 2/2] stash: avoid sparse-index expansion for in-cone paths
Date: Mon, 20 Jul 2026 18:54:57 -0500 [thread overview]
Message-ID: <al61UTM0aK9j9eiP@com-79390> (raw)
In-Reply-To: <20260720223118.62821-6-tnyman@openai.com>
On Mon, Jul 20, 2026 at 03:31:21PM -0700, tnyman@openai.com wrote:
> Signed-off-by: Ted Nyman <tnyman@openai.com>
> ---
> builtin/stash.c | 4 +-
> t/perf/p2000-sparse-operations.sh | 1 +
> t/t1092-sparse-checkout-compatibility.sh | 55 ++++++++++++++++++++++++
> 3 files changed, 58 insertions(+), 2 deletions(-)
All looks reasonable, and it's very nice indeed to see another one of
these /* TODO */ comments go away ;-).
Very pleasant read, this series is
Reviewed-by: Taylor Blau <ttaylorr@openai.com>
, and looks good to me.
Thanks,
Taylor
next prev parent reply other threads:[~2026-07-20 23:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-20 22:31 [PATCH 0/2] stash: avoid sparse-index expansion for in-cone paths tnyman
2026-07-20 22:31 ` [PATCH 1/2] pathspec: use match for sparse-index expansion checks tnyman
2026-07-20 23:53 ` Taylor Blau
2026-07-20 22:31 ` [PATCH 2/2] stash: avoid sparse-index expansion for in-cone paths tnyman
2026-07-20 23:54 ` Taylor Blau [this message]
2026-07-21 19:34 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=al61UTM0aK9j9eiP@com-79390 \
--to=ttaylorr@openai.com \
--cc=git@vger.kernel.org \
--cc=me@ttaylorr.com \
--cc=peff@peff.net \
--cc=stolee@gmail.com \
--cc=tnyman@openai.com \
--cc=vdye@github.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).